[rpc] signer send and fee bump convenience methods #15876
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@MarcoFalke I think we should turn @DrahtBot off for draft PRs. |
Sjors
force-pushed
the
2019/04/signerbumpfee
branch
from
9c4d970 to
287a635
Compare
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Sjors
force-pushed
the
2019/04/signerbumpfee
branch
from
287a635 to
ce6e421
Compare
Sjors
force-pushed
the
2019/04/signerbumpfee
branch
2 times, most recently
from
4ff734c to
afaea2f
Compare
Sjors
force-pushed
the
2019/04/signerbumpfee
branch
from
afaea2f to
d23d7ee
Compare
Sjors
changed the title
Sjors
force-pushed
the
2019/04/signerbumpfee
branch
from
d23d7ee to
892e9c1
Compare
Sjors
force-pushed
the
2019/04/signerbumpfee
branch
from
892e9c1 to
428dfe0
Compare
This was referenced Jul 11, 2019
Merged
* AppVeyor boost-process vcpkg package. * Add HAVE_BOOST_PROCESS for MSVC build (bitcoin_config.h) * Tell Boost linter to ignore it
Create basic ExternalSigner class with contructor. A Signer(<cmd>) is added to CWallet on load if -signer=<cmd> is set.
Sjors
force-pushed
the
2019/04/signerbumpfee
branch
from
428dfe0 to
fd64d93
Compare
Member
Author
Includes a mock to mimick the HWI interace.
When the user doesn't specificy inputs, it makes sense to automatically select them. But when the user does specify inputs, we now fail if the amount is insufficient, unless addInputs is set to true.
Sjors
force-pushed
the
2019/04/signerbumpfee
branch
from
fd64d93 to
83fe48f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two convenience methods on top of #14912.
signersend: a convenience method that Just Works(tm) by combining the functionality ofwalletcreatefundedpsbt,signerprocesspsbt,finalizepsbtandsendrawtransactionsignerbumpfee: combinessignersendwithbumpfeeUsage:
signerbumpfeeis a bit of a hack. In particular it breaks regular fee bump functionality for some wallets because I replacedISMINE_SPENDABLEwithISMINE_ALL. I'd also like to make the code more reusable, but this can wait until the upstream PR is closer to merge.