-
Notifications
You must be signed in to change notification settings - Fork 38.7k
[test] combine_logs: append node stderr and stdout if it exists #15841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa9669d to
fa7670f
Compare
fa7670f to
fa90a89
Compare
Member
Author
|
See for example https://travis-ci.org/bitcoin/bitcoin/jobs/521311218 where a node crashes(?) and the stderr is not accessible anymore on travis for debugging. |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
Member
|
utACK fa90a89 |
maflcko
pushed a commit
that referenced
this pull request
May 1, 2019
…t exists fa90a89 [test] combine_logs: append node stderr and stdout if it exists (MarcoFalke) Pull request description: See issue: * tests: bitcoind stdout and error should be passed to the logger #13519 ACKs for commit fa90a8: laanwj: utACK fa90a89 Tree-SHA512: 39c4596e2e133c9011ab01bc4dc24e884d0a8cce7a67d3765f17c288d3ffbd438e1ff6016d0f817a981b27fce17fa77a1ff56787ddb1ea55123ce9ecffb44c08
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 1, 2019
…ut if it exists fa90a89 [test] combine_logs: append node stderr and stdout if it exists (MarcoFalke) Pull request description: See issue: * tests: bitcoind stdout and error should be passed to the logger bitcoin#13519 ACKs for commit fa90a8: laanwj: utACK fa90a89 Tree-SHA512: 39c4596e2e133c9011ab01bc4dc24e884d0a8cce7a67d3765f17c288d3ffbd438e1ff6016d0f817a981b27fce17fa77a1ff56787ddb1ea55123ce9ecffb44c08
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 7, 2020
Summary: Description of issue that motivated this PR: >Currently the stdout of bitcoinds in functional tests is written to a file in self.datadir of the node. It is only read/examined after the node is shut down. To aid debugging it should (also?) be passed to the logger for visibility and timestamps. Backport of Core [[bitcoin/bitcoin#15841 | PR15841]] Depends on D7795 Test Plan: Intentionaly modify a functional test to make it fail, then check that node stdout is now part of the combined logs. ``` ninja ../test/functional/feature_bip68_sequence.py --configfile=./test/config.ini ../test/functional/combine_logs.py -c ``` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D7796
dzutto
pushed a commit
to dzutto/dash
that referenced
this pull request
Oct 12, 2021
…ut if it exists fa90a89 [test] combine_logs: append node stderr and stdout if it exists (MarcoFalke) Pull request description: See issue: * tests: bitcoind stdout and error should be passed to the logger bitcoin#13519 ACKs for commit fa90a8: laanwj: utACK fa90a89 Tree-SHA512: 39c4596e2e133c9011ab01bc4dc24e884d0a8cce7a67d3765f17c288d3ffbd438e1ff6016d0f817a981b27fce17fa77a1ff56787ddb1ea55123ce9ecffb44c08
UdjinM6
added a commit
to dashpay/dash
that referenced
this pull request
Oct 13, 2021
Merge bitcoin PRs: bitcoin#14683, bitcoin#15841, bitcoin#14984 and bitcoin#15943
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
…ut if it exists fa90a89 [test] combine_logs: append node stderr and stdout if it exists (MarcoFalke) Pull request description: See issue: * tests: bitcoind stdout and error should be passed to the logger bitcoin#13519 ACKs for commit fa90a8: laanwj: utACK fa90a89 Tree-SHA512: 39c4596e2e133c9011ab01bc4dc24e884d0a8cce7a67d3765f17c288d3ffbd438e1ff6016d0f817a981b27fce17fa77a1ff56787ddb1ea55123ce9ecffb44c08
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue: