Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Apr 17, 2019

See issue:

@maflcko maflcko changed the title test: append node stderr and stdout if it exists [test] combine_logs: append node stderr and stdout if it exists Apr 17, 2019
@maflcko maflcko force-pushed the 1904-testLogStdErr branch from fa9669d to fa7670f Compare April 17, 2019 21:05
@maflcko
Copy link
Member Author

maflcko commented Apr 17, 2019

See for example https://travis-ci.org/bitcoin/bitcoin/jobs/521311218 where a node crashes(?) and the stderr is not accessible anymore on travis for debugging.

@fanquake fanquake added the Tests label Apr 17, 2019
@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 18, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@laanwj
Copy link
Member

laanwj commented May 1, 2019

utACK fa90a89
this definitely seems useful

@maflcko maflcko merged commit fa90a89 into bitcoin:master May 1, 2019
maflcko pushed a commit that referenced this pull request May 1, 2019
…t exists

fa90a89 [test] combine_logs: append node stderr and stdout if it exists (MarcoFalke)

Pull request description:

  See issue:

  * tests: bitcoind stdout and error should be passed to the logger #13519

ACKs for commit fa90a8:
  laanwj:
    utACK fa90a89

Tree-SHA512: 39c4596e2e133c9011ab01bc4dc24e884d0a8cce7a67d3765f17c288d3ffbd438e1ff6016d0f817a981b27fce17fa77a1ff56787ddb1ea55123ce9ecffb44c08
@maflcko maflcko deleted the 1904-testLogStdErr branch May 1, 2019 12:42
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 1, 2019
…ut if it exists

fa90a89 [test] combine_logs: append node stderr and stdout if it exists (MarcoFalke)

Pull request description:

  See issue:

  * tests: bitcoind stdout and error should be passed to the logger bitcoin#13519

ACKs for commit fa90a8:
  laanwj:
    utACK fa90a89

Tree-SHA512: 39c4596e2e133c9011ab01bc4dc24e884d0a8cce7a67d3765f17c288d3ffbd438e1ff6016d0f817a981b27fce17fa77a1ff56787ddb1ea55123ce9ecffb44c08
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Oct 7, 2020
Summary:
Description of issue that motivated this PR:

>Currently the stdout of bitcoinds in functional tests is written to a file in self.datadir of the node. It is only read/examined after the node is shut down. To aid debugging it should (also?) be passed to the logger for visibility and timestamps.

Backport of Core [[bitcoin/bitcoin#15841 | PR15841]]
Depends on D7795

Test Plan:
Intentionaly modify a functional test to make it fail, then check that node stdout is now part of the combined logs.
```
ninja
../test/functional/feature_bip68_sequence.py --configfile=./test/config.ini
../test/functional/combine_logs.py -c
```

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7796
dzutto pushed a commit to dzutto/dash that referenced this pull request Oct 12, 2021
…ut if it exists

fa90a89 [test] combine_logs: append node stderr and stdout if it exists (MarcoFalke)

Pull request description:

  See issue:

  * tests: bitcoind stdout and error should be passed to the logger bitcoin#13519

ACKs for commit fa90a8:
  laanwj:
    utACK fa90a89

Tree-SHA512: 39c4596e2e133c9011ab01bc4dc24e884d0a8cce7a67d3765f17c288d3ffbd438e1ff6016d0f817a981b27fce17fa77a1ff56787ddb1ea55123ce9ecffb44c08
UdjinM6 added a commit to dashpay/dash that referenced this pull request Oct 13, 2021
pravblockc pushed a commit to pravblockc/dash that referenced this pull request Nov 18, 2021
…ut if it exists

fa90a89 [test] combine_logs: append node stderr and stdout if it exists (MarcoFalke)

Pull request description:

  See issue:

  * tests: bitcoind stdout and error should be passed to the logger bitcoin#13519

ACKs for commit fa90a8:
  laanwj:
    utACK fa90a89

Tree-SHA512: 39c4596e2e133c9011ab01bc4dc24e884d0a8cce7a67d3765f17c288d3ffbd438e1ff6016d0f817a981b27fce17fa77a1ff56787ddb1ea55123ce9ecffb44c08
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants