doc: describe onlynet option in doc/tor.md #15792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
reviewed
Apr 11, 2019
laanwj
reviewed
Apr 11, 2019
as per http://www.erisian.com.au/bitcoin-core-dev/log-2019-04-11.html#l-102. Description adapted from https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L429. Also fixes a typo in doc/dependencies.md.
jonatack
force-pushed
the
add-onlynet-option-to-tor-docs
branch
from
cdf47e8 to
140bbee
Compare
Member
Author
|
Thanks for reviewing! Updated as per feedback. |
Member
|
thanks, utACK |
Member
Author
|
If merged, might be worth backporting to 0.18.0 before final. |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
Author
|
DrahtBot appears to be mistaken; the other PR does not change these 2 documentation files. Perhaps it is from the link to source code in the commit message or the PR description? |
Contributor
|
ACK 140bbee |
Member
|
utACK 140bbee |
Closed
laanwj
added a commit
that referenced
this pull request
Apr 15, 2019
140bbee doc: describe onlynet option in doc/tor.md (Jon Atack) Pull request description: as per http://www.erisian.com.au/bitcoin-core-dev/log-2019-04-11.html#l-102. Description adapted from [/src/init.cpp#L429](https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L429). Please verify if this is the best place to add it in the documentation. This commit also fixes a typo in doc/dependencies.md. [skip ci] ACKs for commit 140bbe: practicalswift: ACK 140bbee fanquake: utACK 140bbee Tree-SHA512: 05064cc155de5a855e26f70ac5741a137ee5050573007a19e10dba0b5b2c89148ef30f765b50fc76f73dfad17df082f4e68e174b93e2bf7e169e8bd1f9426673
Merged
Member
|
Backported in #15818. |
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Apr 16, 2019
as per http://www.erisian.com.au/bitcoin-core-dev/log-2019-04-11.html#l-102. Description adapted from https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L429. Also fixes a typo in doc/dependencies.md. Github-Pull: bitcoin#15792 Rebased-From: 140bbee
laanwj
added a commit
that referenced
this pull request
Apr 18, 2019
a644780 doc: Clarify RPC versioning (MarcoFalke) 194226f doc: describe onlynet option in doc/tor.md (Jon Atack) 6d2448c doc/dependencies: Fix typo libsrvg->librsvg (Luke Dashjr) 9c572e3 doc: mention creating application support bitcoin folder on OSX (Jack Mallers) c69138a gitignore: add *.plist (clang-check) (James O'Beirne) 8f7cfb0 gitignore: add *.dat (James O'Beirne) Pull request description: Backports #15684, #15792, #15802, #15809 to the `0.18` branch. ACKs for commit a64478: Tree-SHA512: 6ed524a7b94242f8a738710d4321b98b9e80d6625d384fd83280b38fcb6bb8c468bcec1d980789ad2f4c91a5629ffe5c5314a7353181f08884c5a081840431cc
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Apr 19, 2019
as per http://www.erisian.com.au/bitcoin-core-dev/log-2019-04-11.html#l-102. Description adapted from https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L429. Also fixes a typo in doc/dependencies.md. Github-Pull: bitcoin#15792 Rebased-From: 140bbee
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 20, 2020
Summary: > as per http://www.erisian.com.au/bitcoin-core-dev/log-2019-04-11.html#l-102. The typo in dependencies.md fixed by this PR was already corrected on our side. Backport of Core [[bitcoin/bitcoin#15792 | PR15792]] Depends on D8001 Test Plan: Proof-reading Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D8002
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 18, 2021
140bbee doc: describe onlynet option in doc/tor.md (Jon Atack) Pull request description: as per http://www.erisian.com.au/bitcoin-core-dev/log-2019-04-11.html#l-102. Description adapted from [/src/init.cpp#L429](https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L429). Please verify if this is the best place to add it in the documentation. This commit also fixes a typo in doc/dependencies.md. [skip ci] ACKs for commit 140bbe: practicalswift: ACK 140bbee fanquake: utACK 140bbee Tree-SHA512: 05064cc155de5a855e26f70ac5741a137ee5050573007a19e10dba0b5b2c89148ef30f765b50fc76f73dfad17df082f4e68e174b93e2bf7e169e8bd1f9426673
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per http://www.erisian.com.au/bitcoin-core-dev/log-2019-04-11.html#l-102.
Description adapted from /src/init.cpp#L429.
Please verify if this is the best place to add it in the documentation.
This commit also fixes a typo in doc/dependencies.md.
[skip ci]