test: Add wallet_balance benchmark #15779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
force-pushed
the
1904-benchWallet
branch
6 times, most recently
from
2887a25 to
fa5944a
Compare
Member
Author
|
Going to reopen next week |
maflcko
force-pushed
the
1904-benchWallet
branch
4 times, most recently
from
fac783b to
fabbac8
Compare
maflcko
force-pushed
the
1904-benchWallet
branch
from
fabbac8 to
fa46ac3
Compare
Member
Author
|
this is ready for review now |
Member
|
utACK fa46ac3 |
ryanofsky
approved these changes
Apr 17, 2019
| WalletTestingSetup wallet_t{}; | ||
| auto& wallet = wallet_t.m_wallet; | ||
| { | ||
| bool first_run; |
Contributor
There was a problem hiding this comment.
I think there's no need for this to be indented, but I guess it's reasonable to limit the scope the first_run variable.
Further stylistic cleanups in touched files: * Sort the includes * Wrap long single-line constructors into multiple lines
maflcko
force-pushed
the
1904-benchWallet
branch
from
fa0c89b to
fad7c33
Compare
Member
Author
|
Added a method to the wallet to handle notifications (and removed the |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Apr 17, 2019
fad7c33 refactor: Add handleNotifications method to wallet (MarcoFalke) fa46ac3 bench: Add wallet_balance benchmarks (MarcoFalke) Pull request description: ACKs for commit fad7c3: ryanofsky: utACK fad7c33. I might squash or rearrange the commits to avoid adding code in one commit that just gets deleted in the next one. But overall this looks good and the cleanup is nice. Tree-SHA512: 231faac168cbe9bb0ab4bf10ac1d5b042c610364406d75061fba27f1e9d16c71867e74cc4606e9f42659aa980d7133c00e29fcc18bbba7da2fa7a80178b3246c
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
May 23, 2020
Summary: This is a partial backport of Core [[bitcoin/bitcoin#15779 | PR15779]] : bitcoin/bitcoin@fa46ac3 Also include pieces of [[bitcoin/bitcoin#15788 | PR15788]] that previously were ignored becauseit was dead code. Test Plan: ninja all check-all Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D6236
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
May 23, 2020
Summary: Further stylistic cleanups in touched files: * Sort the includes * Wrap long single-line constructors into multiple lines This is a partial backport of Core [[bitcoin/bitcoin#15779 | PR15779]] : bitcoin/bitcoin@fad7c33 Depends on D6236 Test Plan: ninja all check-all ./src/bench/bitcoin-bench Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D6239
|
|
||
| #include <boost/thread.hpp> | ||
|
|
||
| const std::string ADDRESS_BCRT1_UNSPENDABLE = "bcrt1qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq3xueyj"; |
Contributor
There was a problem hiding this comment.
interesting. just curious, how to create this un-spendable address? @MarcoFalke
11 tasks
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Oct 25, 2021
UdjinM6
added a commit
to dashpay/dash
that referenced
this pull request
Oct 25, 2021
merge bitcoin#13219...bitcoin#15779: benchmarks
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Oct 31, 2021
This was referenced Oct 31, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Nov 6, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Nov 14, 2021
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.