gui: Add close window shortcut #15768

IPGlider · 2019-04-07T19:54:51Z

CMD+W is the standard shortcut in macOS to close a window without
exiting the program.

This adds support to use the shortcut in both main and debug windows.

jonasschnelli · 2019-04-08T09:20:10Z

Thanks!
Tested ACK 20859aef8b571542772a42b4c413c4a71a6576c5

The macOS HIG about Command+W:
https://developer.apple.com/design/human-interface-guidelines/macos/user-interaction/keyboard/

promag

Pressing ESC also closes the dialogs (except the main window). Is this something to keep in macos? (not suggesting it though, just want to mention the redundancy)

promag · 2019-04-08T13:58:20Z

src/qt/bitcoingui.cpp

Do you mind moving this to something like GUIUtil::handleHideShortcut(QWdiget*)? There are dialogs, like coin control dialog, transaction details, that could use the same feature.

promag · 2019-04-08T14:00:19Z

src/qt/bitcoingui.cpp

No need to lambda, could just be ... , &QShortcut::activated, this, &QWidget::hide)?

practicalswift · 2019-04-09T14:29:53Z

FWIW: I've verified that a disassembly of the bitcoind binary built on a Ubuntu 18.04 machine with this patch applied is identical to a disassembly of the bitcoind binary built against master (as expected).

laanwj · 2019-04-10T10:41:12Z

utACK, ideally this kind of stuff would be handled by the cross-platform windowing system, so it's a bit disappointing that it's not, but also, this is only a few lines and increases user friendliness.

BTW: CTRL-W is also quite a common shortcut for closing windows in applications outside of OS-X, for example in browsers it closes the tab.

IPGlider · 2019-04-10T10:54:19Z

I will do the suggested changes and add the functionality to all the windows.

Thanks for the review.

laanwj · 2019-04-10T11:43:11Z

QShortcut has a Qt::ApplicationShortcut for application-global shortcuts (see https://doc.qt.io/Qt-5/qt.html#ShortcutContext-enum )—would this be useful here?

luke-jr · 2019-04-18T18:45:18Z

Any reason not to enable this on all platforms?

IPGlider · 2019-04-19T10:26:19Z

I have updated the PR with the given suggestions and added the shortcut to most windows.

The only one without this shortcut is the 'About Qt' as it is part of Qt and I have not been able to add the shortcut to it.

If I have missed any other window please let me know.

@laanwj Qt::ApplicationShortcut does not work for the intended purpose. It makes the shortcut works even if it is not focused.

@luke-jr CMD+W is usually only used on macOS, more information can be found in the macOS HID posted by @jonasschnelli and in Wikepedia's Table of keyboard shortcuts.

luke-jr · 2019-04-19T16:20:46Z

I use Ctrl+W on Linux all the time to close browser tabs. My IRC client seems to use it for closing tabs too.

Furthermore, if macOS is using it, we can't use it for anything else (eg, closing wallets?).

So overall, I'd say it makes sense to just support it on all platforms.

luke-jr · 2019-04-20T20:59:26Z

Note: When extending it to support other platforms, care needs to be taken that the main window is not actually hidden if there's no system tray icon. Probably should minimise in that case? Not sure...

luke-jr · 2019-04-20T21:03:20Z

src/qt/utilitydialog.cpp

Do we want this to be hide-able??

The criteria I followed to make windows hide-able has been what I understand is the common usage in macOS, meaning that every window that has a close button can also be closed using the CMD+W shortcut.

luke-jr · 2019-04-20T21:03:39Z

Probably a number of windows ought to be closed normally, not merely hidden?

jonasschnelli · 2019-04-29T06:55:45Z

src/qt/guiutil.cpp

I haven't looked closely at this,... but is there a proper deallocation of that QShortcut?

I have followed the official documentation in this regard[0]. If you consider that this is not a correct application please let me know a more appropriate way.

[0] https://doc.qt.io/qt-5/qobject.html

hebasto · 2019-08-01T09:59:02Z

@IPGlider Could you address reviewers' comments?

IPGlider · 2019-08-02T06:37:41Z

Is working in this PR still worth it? I would like to finish it.

@hebasto I will address the comments in a few days.

hebasto · 2019-08-03T11:25:16Z

@IPGlider

Is working in this PR still worth it?

Yes, IMO.

IPGlider · 2019-08-05T19:58:15Z

@luke-jr

I use Ctrl+W on Linux all the time to close browser tabs. My IRC client seems to use it for closing tabs too.

Furthermore, if macOS is using it, we can't use it for anything else (eg, closing wallets?).

So overall, I'd say it makes sense to just support it on all platforms.

I wasn't aware that this shortcut was also commonly used in other OSs other than macOS. Considering this I will remove the ifdef to support all OSs.

Probably a number of windows ought to be closed normally, not merely hidden?

I agree and after reading the QT documentation I will replace the hide call with a close call.

Should I continue working on this PR considering that the name of the branch is add_cmd_w_support_in_macos or would it be preferable to create another PR?

fanquake · 2019-08-06T01:15:41Z

@IPGlider No need for a new PR. Just update the PR title, body etc if required.

CMD+W/CTRL+W is the standard shortcut to close a window without exiting the program. Github-Pull: bitcoin#15768 Rebased-From: e0cd6f3c9c809f9876ff7d69ae91a9e67434be58

CMD+W/CTRL+W is the standard shortcut to close a window without exiting the program. Github-Pull: bitcoin#15768 Rebased-From: 77b0232fcb0f7b7c28a041ebbe18b6205aea5db2

Fix intro dialog labels when the prune button is toggled (bitcoin#17453) Rename debug window (bitcoin#17096) Add close window shortcut (bitcoin#15768) Add privacy to the Overview page (bitcoin#16432) Remove WalletView and BitcoinGUI circular dependency (bitcoin#17937) Force set nPruneSize in QSettings after the intro dialog (bitcoin#17696)

CMD+W/CTRL+W is the standard shortcut to close a window without exiting the program.

hebasto

ACK f5a3a5b, tested on Linux Mint 19.3 by manually opening available dialogs and sub-windows, and applying the Ctrl+W shortcut. Also tested with "Minimize on close" option enabled / disabled.

jonasschnelli · 2020-05-04T09:52:58Z

Tested ACK f5a3a5b

f5a3a5b gui: Add close window shortcut (Miguel Herranz) Pull request description: CMD+W is the standard shortcut in macOS to close a window without exiting the program. This adds support to use the shortcut in both main and debug windows. ACKs for top commit: jonasschnelli: Tested ACK f5a3a5b hebasto: ACK f5a3a5b, tested on Linux Mint 19.3 by manually opening available dialogs and sub-windows, and applying the `Ctrl+W` shortcut. Also tested with "Minimize on close" option enabled / disabled. Tree-SHA512: 39851f6680cf97c334d5759c6f8597cb45685359417493ff8b0566672edbd32303fa15ac4260ec8ab5ea1458a600a329153014f25609e1db9cf399aa851ae2f9

CMD+W/CTRL+W is the standard shortcut to close a window without exiting the program. Github-Pull: bitcoin#15768 Rebased-From: f5a3a5b

Summary: > CMD+W/CTRL+W is the standard shortcut to close a window without > exiting the program. This is a backport of Core [[bitcoin/bitcoin#15768 | PR15768]] Test Plan: `ninja && src/qt/bitcoin-qt` Try Ctrl+W in various dialogs (e.g. in the RPC console) Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D9070

fanquake added GUI macOS labels Apr 7, 2019

promag reviewed Apr 8, 2019

View reviewed changes

laanwj mentioned this pull request Apr 15, 2019

gui: Add shortcuts for tab tools #15756

Merged

IPGlider force-pushed the add_cmd_w_support_in_macos branch from 20859ae to 263c383 Compare April 19, 2019 10:25

luke-jr reviewed Apr 20, 2019

View reviewed changes

jonasschnelli reviewed Apr 29, 2019

View reviewed changes

laanwj mentioned this pull request Aug 1, 2019

gui: Close console with CTRL+D ala terminal #16515

Closed

fanquake added the Up for grabs label Aug 2, 2019

fanquake closed this Aug 2, 2019

fanquake removed the Up for grabs label Aug 2, 2019

fanquake reopened this Aug 2, 2019

IPGlider changed the title ~~gui: Add CMD+W shortcut in macOS~~ gui: Add close window shortcut Aug 6, 2019

IPGlider force-pushed the add_cmd_w_support_in_macos branch 2 times, most recently from 8eec051 to ab589f0 Compare August 6, 2019 15:00

DrahtBot removed the Needs rebase label Oct 13, 2019

DrahtBot added the Needs rebase label Oct 26, 2019

IPGlider force-pushed the add_cmd_w_support_in_macos branch from e0cd6f3 to fa166a9 Compare November 10, 2019 13:39

DrahtBot removed the Needs rebase label Nov 10, 2019

MarkLTZ added a commit to litecoinz-core/litecoinz that referenced this pull request Nov 17, 2019

[gui] Add close window shortcut (bitcoin#15768)

2b39e98

fanquake removed the Waiting for author label Dec 9, 2019

DrahtBot added the Needs rebase label Dec 9, 2019

IPGlider force-pushed the add_cmd_w_support_in_macos branch from fa166a9 to 77b0232 Compare December 22, 2019 14:04

DrahtBot removed the Needs rebase label Dec 22, 2019

DrahtBot added the Needs rebase label Jan 8, 2020

IPGlider force-pushed the add_cmd_w_support_in_macos branch from 77b0232 to 7d99b3b Compare January 24, 2020 06:15

DrahtBot removed the Needs rebase label Jan 24, 2020

DrahtBot added the Needs rebase label Feb 1, 2020

gui: Add close window shortcut

f5a3a5b

CMD+W/CTRL+W is the standard shortcut to close a window without exiting the program.

IPGlider force-pushed the add_cmd_w_support_in_macos branch from 7d99b3b to f5a3a5b Compare February 5, 2020 06:16

DrahtBot removed the Needs rebase label Feb 5, 2020

This was referenced Feb 11, 2020

gui: Paste button in Open URI dialog #17955

Closed

qt: Fix height of QR-less ReceiveRequestDialog #17597

Merged

This was referenced Mar 2, 2020

wip: gui: Drop connectSlotsByName usage #18246

Closed

wip: gui: Refactor to drop client and wallet models setters #18239

Closed

hebasto approved these changes May 4, 2020

View reviewed changes

jonasschnelli merged commit afa577c into bitcoin:master May 4, 2020

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Jun 9, 2020

gui: Add close window shortcut

7d2ece8

CMD+W/CTRL+W is the standard shortcut to close a window without exiting the program. Github-Pull: bitcoin#15768 Rebased-From: f5a3a5b

bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022

gui: Add close window shortcut #15768

gui: Add close window shortcut #15768

Uh oh!

Conversation

IPGlider commented Apr 7, 2019

Uh oh!

jonasschnelli commented Apr 8, 2019

Uh oh!

promag left a comment

Choose a reason for hiding this comment

Uh oh!

promag Apr 8, 2019

Choose a reason for hiding this comment

Uh oh!

promag Apr 8, 2019

Choose a reason for hiding this comment

Uh oh!

practicalswift commented Apr 9, 2019

Uh oh!

laanwj commented Apr 10, 2019

Uh oh!

IPGlider commented Apr 10, 2019

Uh oh!

laanwj commented Apr 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luke-jr commented Apr 18, 2019

Uh oh!

IPGlider commented Apr 19, 2019

Uh oh!

luke-jr commented Apr 19, 2019

Uh oh!

luke-jr commented Apr 20, 2019

Uh oh!

luke-jr Apr 20, 2019

Choose a reason for hiding this comment

Uh oh!

IPGlider Aug 5, 2019

Choose a reason for hiding this comment

Uh oh!

luke-jr commented Apr 20, 2019

Uh oh!

jonasschnelli Apr 29, 2019

Choose a reason for hiding this comment

Uh oh!

IPGlider Aug 5, 2019

Choose a reason for hiding this comment

Uh oh!

hebasto commented Aug 1, 2019

Uh oh!

IPGlider commented Aug 2, 2019

Uh oh!

hebasto commented Aug 3, 2019

Uh oh!

IPGlider commented Aug 5, 2019

Uh oh!

fanquake commented Aug 6, 2019

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

jonasschnelli commented May 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

laanwj commented Apr 10, 2019 •

edited

Loading