-
Notifications
You must be signed in to change notification settings - Fork 38.7k
List new RPCs in psbt.md and descriptors.md #15757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
utACK ece60eb |
jonatack
reviewed
Apr 5, 2019
Member
jonatack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK ece60eb
Member
|
utACK 9b085f4 |
laanwj
added a commit
that referenced
this pull request
Apr 9, 2019
9b085f4 Mention new descriptor RPCs in descriptors.md (Pieter Wuille) 28d78de Mention new PSBT RPCs in psbt.md (Pieter Wuille) Pull request description: The documentation in `psbt.md` and `descriptors.md` does not list new and updated RPCs (`analyzepsbt`, `utxoupdatepsbt`, `joinpsbts`, `deriveaddresses`, `getdescriptorinfo`, `listunspent`). Fix this. It'd be good to have this in 0.18 (only documentation). ACKs for commit 9b085f: fanquake: utACK 9b085f4 Tree-SHA512: ee16907e8c15351a530f11fc0a585c50835a7bf5aec997ac0e897949d9b9e41a28ddebbeaba69753fee7d2de75e518091518185085fcd1f6ada94b7231097b2e
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Apr 9, 2019
Github-Pull: bitcoin#15757 Rebased-From: 28d78de
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Apr 9, 2019
Github-Pull: bitcoin#15757 Rebased-From: 9b085f4
Member
|
Backported in #15775. |
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Apr 19, 2019
Github-Pull: bitcoin#15757 Rebased-From: 28d78de
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Apr 19, 2019
Github-Pull: bitcoin#15757 Rebased-From: 9b085f4
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 5, 2020
Summary: Backport of Core [[bitcoin/bitcoin#15757 | PR15757]] and [[bitcoin/bitcoin#16047 | PR16047]] Depends on D7758 Test Plan: Check rendering of markdown in a viewer. Verify all commands added to the doc are listed in `bitcoin-cli help` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D7759
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation in
psbt.mdanddescriptors.mddoes not list new and updated RPCs (analyzepsbt,utxoupdatepsbt,joinpsbts,deriveaddresses,getdescriptorinfo,listunspent). Fix this.It'd be good to have this in 0.18 (only documentation).