Skip to content

Conversation

@sipa
Copy link
Member

@sipa sipa commented Apr 5, 2019

The documentation in psbt.md and descriptors.md does not list new and updated RPCs (analyzepsbt, utxoupdatepsbt, joinpsbts, deriveaddresses, getdescriptorinfo, listunspent). Fix this.

It'd be good to have this in 0.18 (only documentation).

@fanquake fanquake added the Docs label Apr 5, 2019
@maflcko maflcko added this to the 0.18.0 milestone Apr 5, 2019
@instagibbs
Copy link
Member

utACK ece60eb

Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK ece60eb

@sipa sipa force-pushed the 201904_docupdate branch from ece60eb to 9b085f4 Compare April 6, 2019 15:18
@fanquake
Copy link
Member

fanquake commented Apr 7, 2019

utACK 9b085f4

@laanwj laanwj merged commit 9b085f4 into bitcoin:master Apr 9, 2019
laanwj added a commit that referenced this pull request Apr 9, 2019
9b085f4 Mention new descriptor RPCs in descriptors.md (Pieter Wuille)
28d78de Mention new PSBT RPCs in psbt.md (Pieter Wuille)

Pull request description:

  The documentation in `psbt.md` and `descriptors.md` does not list new and updated RPCs (`analyzepsbt`, `utxoupdatepsbt`, `joinpsbts`, `deriveaddresses`, `getdescriptorinfo`, `listunspent`). Fix this.

  It'd be good to have this in 0.18 (only documentation).

ACKs for commit 9b085f:
  fanquake:
    utACK 9b085f4

Tree-SHA512: ee16907e8c15351a530f11fc0a585c50835a7bf5aec997ac0e897949d9b9e41a28ddebbeaba69753fee7d2de75e518091518185085fcd1f6ada94b7231097b2e
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Apr 9, 2019
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Apr 9, 2019
@fanquake
Copy link
Member

fanquake commented Apr 9, 2019

Backported in #15775.

HashUnlimited pushed a commit to HashUnlimited/chaincoin that referenced this pull request Apr 19, 2019
HashUnlimited pushed a commit to HashUnlimited/chaincoin that referenced this pull request Apr 19, 2019
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Oct 5, 2020
Summary:
Backport of Core [[bitcoin/bitcoin#15757 | PR15757]] and [[bitcoin/bitcoin#16047 | PR16047]]

Depends on D7758

Test Plan:
Check rendering of markdown in a viewer.
Verify all commands added to the doc are listed in `bitcoin-cli help`

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7759
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants