Speed up deriveaddresses for large ranges #15751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I've tried using Regardless, I do think this is a good change, so utACK 41a46cb |
Member
|
tACK 41a46cb I'm seeing a substantial speedup using 41a46cb over master (66ce95a).
Using a command like |
Contributor
|
utACK 41a46cb |
Member
|
makes sense |
laanwj
added a commit
that referenced
this pull request
Apr 15, 2019
41a46cb Speed up deriveaddresses for large ranges (Pieter Wuille) Pull request description: `deriveaddresses` dumps all generated addresses into a single `FlatSigningProvider`, which is also used for looking up information for future derivations. @achow101 points out that the growing data structures may unnecessary increase lookup time for later derivations. Fix this by separating the provider used for lookups (`key_provider`) and the one we dump things into. This gives a 10x speedup for a range of 7000 elements, and probably a larger speedup for larger ranges. ACKs for commit 41a46c: achow101: Regardless, I do think this is a good change, so utACK 41a46cb fanquake: tACK 41a46cb meshcollider: utACK 41a46cb Tree-SHA512: a1b894ce9d5195d8f9760f44acc6d67a90bb259283fd8c1524c38a222fe53e8c1d35b6653a508b121b7ad91e155c97d26c658f6bdcebf6c360546931e4a26a22
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jun 23, 2020
Summary: bitcoin/bitcoin@41a46cb --- Depends on D6626 Backport of Core [[bitcoin/bitcoin#15751 | PR15751]] Test Plan: ninja check test_runner.py wallet_importmulti rpc_scantxoutset Reviewers: #bitcoin_abc, nakihito Reviewed By: nakihito Differential Revision: https://reviews.bitcoinabc.org/D6641
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Nov 4, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Nov 11, 2021
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deriveaddressesdumps all generated addresses into a singleFlatSigningProvider, which is also used for looking up information for future derivations. @achow101 points out that the growing data structures may unnecessary increase lookup time for later derivations.Fix this by separating the provider used for lookups (
key_provider) and the one we dump things into.This gives a 10x speedup for a range of 7000 elements, and probably a larger speedup for larger ranges.