Fix: importmulti only imports origin info for PKH outputs #15749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
|
utACK, thanks for the quick fix! |
Member
|
utACK 6e59700 |
Member
Author
sipa
force-pushed
the
201904_importallorigins
branch
from
a6a1e3e to
b5d3987
Compare
Contributor
|
@sipa tACK! Confirmed this fixes both problems. Thanks again! |
Member
Author
|
I'm marking this as a bug, as the current |
Contributor
|
utACK b5d3987 |
meshcollider
added a commit
that referenced
this pull request
Apr 9, 2019
b5d3987 Take non-importing keys into account for spendability warning in descriptor import (Pieter Wuille) 6e59700 Import all origin info in importmulti; even for non-importing pubkeys (Pieter Wuille) 9a93c91 Keep full pubkeys in FlatSigningProvider::origins (Pieter Wuille) Pull request description: This fixes #15743 and #15742. Since #15263, pubkeys are no longer imported for non-PKH (or WPKH, or any wrapped form of those) outputs, as that would incorrectly mark outputs to single-key versions of multisig policies as watched. As a side effect, this change also caused origin info not to be imported anymore for multisig policies. Fix this by plumbing through the full pubkey information for origins in FlatSigningProvider, and then importing all origin info we have in `importmulti` (knowing more never hurts, and additional origin information has no negative consequences like importing the pubkeys themselves). ACKs for commit b5d398: MeshCollider: utACK b5d3987 Tree-SHA512: 37caa2be8d01b8baa12f70a58eaa7c583f5f0afbe012e02936dd8790dc5dc852f880b77258b34ddb68cae30c029585f2d1c4f5d00015380557a1e8b471e500f3
maflcko
pushed a commit
that referenced
this pull request
Apr 16, 2019
…info for PKH outputs 235550d Take non-importing keys into account for spendability warning in descriptor import (Pieter Wuille) 802dcd3 Import all origin info in importmulti; even for non-importing pubkeys (Pieter Wuille) 7fcbe7d Keep full pubkeys in FlatSigningProvider::origins (Pieter Wuille) Pull request description: Clean backport of #15749 by sipa to 0.18 ACKs for commit 235550: fanquake: utACK 235550d MarcoFalke: ACK 235550d (Checked that they are clean cherry-picks) Tree-SHA512: 1ccc19f51137ac4ef971c0bcca4c87ab2383610aa51c5d02680c485b9ce6abd698dddd7f4a45946d56b1aa741cc3fd94b4180ff15901824d20eeba89b4f12853
Member
|
Backported in #15803. |
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Apr 19, 2019
Github-Pull: bitcoin#15749 Rebased-From: 9a93c91
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Apr 19, 2019
Github-Pull: bitcoin#15749 Rebased-From: 6e59700
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Apr 19, 2019
…riptor import Github-Pull: bitcoin#15749 Rebased-From: b5d3987
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jun 5, 2020
Summary: * Keep full pubkeys in FlatSigningProvider::origins * Import all origin info in importmulti; even for non-importing pubkeys * Take non-importing keys into account for spendability warning in descriptor import This is a backport of Core [[bitcoin/bitcoin#15749 | PR15749]] Test Plan: ninja all check-all Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Subscribers: majcosta Differential Revision: https://reviews.bitcoinabc.org/D6385
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Oct 29, 2021
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #15743 and #15742.
Since #15263, pubkeys are no longer imported for non-PKH (or WPKH, or any wrapped form of those) outputs, as that would incorrectly mark outputs to single-key versions of multisig policies as watched.
As a side effect, this change also caused origin info not to be imported anymore for multisig policies.
Fix this by plumbing through the full pubkey information for origins in FlatSigningProvider, and then importing all origin info we have in
importmulti(knowing more never hurts, and additional origin information has no negative consequences like importing the pubkeys themselves).