[rpc] remove dead mining code #15748
Conversation
src/rpc/mining.cpp
Outdated
There was a problem hiding this comment.
Just out of curiosity, how come the use of mixed casing?
coinbase_script, nMaxTries all in the same function?
There was a problem hiding this comment.
Variable (including function arguments) and namespace names are all lowercase, and may use _ to separate words (snake_case).
https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#coding-style-c
Patchsets should always be focused. For example, a pull request could add a feature, fix a bug, or refactor code; but not a mixture.
https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md
|
Concept ACK Good catch! |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Removes dead code from after the generate method was removed
jnewbery
force-pushed
the
2019_04_simplify_generate
branch
from
ebb1dc9 to
1b46a48
Compare
|
rebased |
|
utACK 1b46a48 |
|
utACK 1b46a48 |
|
utACK 1b46a48 |
|
utACK 1b46a48 |
1b46a48 [cleanup] Remove unused CReserveKey (John Newbery) 9819ad6 [rpc] simplify generate RPC (John Newbery) Pull request description: Removes dead code from after the generate method was removed ACKs for commit 1b46a4: MarcoFalke: utACK 1b46a48 meshcollider: utACK 1b46a48 scravy: utACK 1b46a48 Empact: utACK 1b46a48 Tree-SHA512: d1fab1bf76ac3036b85cf33be89868bc016f912575545ecaa16f958397b0ec4f1ce4de8fe254d4f21aabeea9c83a8928530cc520de26af0d1a8bdb4ca0f2cb77
Summary: Removes dead code from after the generate method was removed bitcoin/bitcoin@9819ad6 --- Depends on D6710 Partial backport of Core [[bitcoin/bitcoin#15748 | PR15748]] Test Plan: ninja check Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6712
Summary: bitcoin/bitcoin@1b46a48 --- Depends on D6712 Concludes backport of Core [[bitcoin/bitcoin#15748 | PR15748]] Test Plan: ninja check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6714
1b46a48 [cleanup] Remove unused CReserveKey (John Newbery) 9819ad6 [rpc] simplify generate RPC (John Newbery) Pull request description: Removes dead code from after the generate method was removed ACKs for commit 1b46a4: MarcoFalke: utACK 1b46a48 meshcollider: utACK bitcoin@1b46a48 scravy: utACK 1b46a48 Empact: utACK bitcoin@1b46a48 Tree-SHA512: d1fab1bf76ac3036b85cf33be89868bc016f912575545ecaa16f958397b0ec4f1ce4de8fe254d4f21aabeea9c83a8928530cc520de26af0d1a8bdb4ca0f2cb77
8 participants
Removes dead code from after the generate method was removed