init: Throw error when network specific config is ignored #15629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tested ACK dddd6f0. $ cat bitcoin.conf
rpcport=54321
bitcoind -testnet
2019-03-21T14:58:35Z Bitcoin Core version v0.18.99.0-dddd6f0f5 (release build)
2019-03-21T14:58:35Z Error: Config setting for -rpcport only applied on test network when in [test] section.
Error: Config setting for -rpcport only applied on test network when in [test] section.Deserves a small release note, just to point to if someone reports this behavior change? |
Contributor
|
Concept ACK Nice usability improvement! |
Contributor
|
@MarcoFalke here's a test for your consideration 53469f7. |
maflcko
force-pushed
the
1903-InitErrorConf
branch
from
faed503 to
fad6ec6
Compare
maflcko
force-pushed
the
1903-InitErrorConf
branch
from
fad6ec6 to
fa9058f
Compare
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Apr 10, 2019
…s ignored fae38c3 doc: Fix all typos reported by codespell (MarcoFalke) fa9058f doc: Add release notes for 15629 (MarcoFalke) fa4a922 qa: Add test for missing testnet section in conf file (MarcoFalke) dddd6f0 init: Throw error when network specific config is ignored (MarcoFalke) Pull request description: This should have no effect on mainnet users, but simplifies testing, where config settings are currently ignored with only a warning. Fix this by making it an error. Issues: * bitcoin client 0.17.0 ignores wallet's name (file) bitcoin#14523 * Can't set custom rpcport on testnet bitcoin#13777 * ... ACKs for commit fae38c: Tree-SHA512: 2e209526898eea6e444c803ec2666989cee4ca137492d32984998733c50a70056cb54657df8dc3027a6a0612738a8afce0bc35824b868c5f22281e00e0188530
Contributor
|
utACK fae38c3. |
vijaydasmp
added a commit
to vijaydasmp/dash
that referenced
this pull request
Oct 19, 2021
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Oct 21, 2021
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Nov 21, 2021
Summary --- This is a backport of bitcoin/bitcoin@dddd6f0 See bitcoin/bitcoin#15629 Test plan --- * `ninja all check-all`
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Nov 21, 2021
Summary --- This is a backport of bitcoin/bitcoin@fa4a922 See bitcoin/bitcoin#15629 The missing is_wallet_compiled condition from [https://github.com/bitcoin/bitcoin/pull/15629](PR 16097) is added. Test plan --- * `ninja all check-all`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have no effect on mainnet users, but simplifies testing, where config settings are currently ignored with only a warning. Fix this by making it an error.
Issues: