0.18: [p2p] Enable reject messages by default #15602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnewbery
force-pushed
the
reject_message_by_default
branch
from
2188763 to
a756363
Compare
Contributor
Author
|
Oops. Accidentally changed some unrelated formatting in the release-notes docs. Force pushed to fix. |
maflcko
changed the title
Member
|
utACK a756363, but the release notes change should (also) be done upstream in the wiki. Otherwise you risk it getting overwritten. |
Contributor
|
utACK |
Member
|
utACK a756363 |
maflcko
pushed a commit
that referenced
this pull request
Mar 14, 2019
a756363 [docs] document BIP 61 deprecation (John Newbery) da14d90 [p2p] Enable BIP 61 REJECT messages by default (John Newbery) Pull request description: This PR reverts #14054 following discussion on the bitcoin-dev mailing list. It also adds release notes to clearly document that the `enablebip61` option will be disabled by default in a future release before being removed entirely. Tree-SHA512: 0c9162045a4fb95689a0cb2de19f98a83636c9a6fb7ffa6809773b593c6c00b14e0480683e4d1c48e9b7f90e89cf7c2dca18bff42f5d2da2a43c522039e9f1ee
Member
Contributor
Author
Thanks Marco |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #14054 following discussion on the bitcoin-dev mailing list.
It also adds release notes to clearly document that the
enablebip61option will be disabled by default in a future release before being removed entirely.