Fix remaining compile warnings. #1555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ACK |
jgarzik
pushed a commit
that referenced
this pull request
Jul 4, 2012
Fix remaining compile warnings.
nifgraup
pushed a commit
to nifgraup/auroracoin-project
that referenced
this pull request
Mar 30, 2014
Fix remaining compile warnings.
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
In the case of (for example) an already-running bitcoind, the shutdown sequence begins before CConnman has been created, leading to a null-pointer dereference when g_connman->Stop() is called. Instead, Just let the CConnman dtor take care of stopping.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(aside from some boost::thread ones on win32)
Fixes:
src/net.h: In member function ‘void CNode::EndMessage()’:
src/net.h:374: warning: invalid access to non-static data member ‘CMessageHeader::nMessageSize’ of NULL object
src/net.h:374: warning: (perhaps the ‘offsetof’ macro was used incorrectly)
src/net.h:380: warning: invalid access to non-static data member ‘CMessageHeader::nChecksum’ of NULL object
src/net.h:380: warning: (perhaps the ‘offsetof’ macro was used incorrectly)
src/net.h:381: warning: invalid access to non-static data member ‘CMessageHeader::nChecksum’ of NULL object
src/net.h:381: warning: (perhaps the ‘offsetof’ macro was used incorrectly)
Or, put better by clang++:
src/net.h:377:46: warning: offset of on non-POD type 'CMessageHeader' [-Winvalid-offsetof]