build: use full version string in setup.exe #15548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Concept ACK. mv ${SOURCEDIR}/bitcoin-osx-signed.dmg ${DESTDIR}/bitcoin-${VERSIONTO}-osx.dmg |
Member
|
One concern: how does this interact with the |
Member
Author
|
I think it signs anything that ends with |
Contributor
|
Gitian builds for commit d211edb (master):
Gitian builds for commit ccc2958ac8ebd3a706590dc6b96770abf4485b6b (master and this pull):
|
promag
reviewed
Mar 11, 2019
| BrandingText " " | ||
| ShowInstDetails show | ||
| VIProductVersion ${VERSION}.@CLIENT_VERSION_BUILD@ | ||
| VIProductVersion @CLIENT_VERSION_MAJOR@.@CLIENT_VERSION_MINOR@.@CLIENT_VERSION_REVISION@.@CLIENT_VERSION_BUILD@ |
Contributor
There was a problem hiding this comment.
There are other places where this is done, like
bitcoin/src/bitcoin-cli-res.rc
Line 5 in 257f750
Makes sense to define this in configure.ac (other PR)?
Member
Author
There was a problem hiding this comment.
Yeah, other PR. The goal of this one is really only to change the OutFile
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Mar 12, 2019
Github-Pull: bitcoin#15548 Rebased-From: fa55104 Tree-SHA512: 195d9d459431ae879a27e26d01962f020ddbbf648da26e52121c4fa7eb3438330f1ce34de431757e5079bf248f7129539e1d1a83c9c795ab57dc8c51545384bb
random-zebra
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Nov 25, 2019
298528c build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString (fanquake) 04f5d5b build: use full version string in setup.exe (MarcoFalke) c787618 Update release-process.md to include RC version bumping (Andrew Chow) 32a69da build: include rc number in version number (Andrew Chow) 8c2b28b build: if VERSION_BUILD is non-zero, include it in the package version (Andrew Chow) Pull request description: This is a backport of the following 3 upstream PRs that result in more precise file names in gitian outputs and in macOS app version info; namely that they are no longer limited to only 3 levels deep (`3.4.0` for example) and will now include the 4th level and/or the RC version if needed (`4.0.0rc1` or `4.0.0.1` for example). bitcoin#14612 bitcoin#14701 bitcoin#15548 Top commit has no ACKs. Tree-SHA512: 1195e9c0af92f4d6c2f7546530d1d5c1046f9139c8f9a03d2d8e092bbbcf5e5c5d046523e8a3712bde3d84bf81252dcc8dbb1ac3f1cdaaa863b1d14c3251fe95
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
fa55104 build: use full version string in setup.exe (MarcoFalke) Pull request description: Fixes: bitcoin#15546 Tree-SHA512: a8ccbfef6b9fdd10bd0facadb25019b9296579eee6c8f7b4e5298cc4df52bba61864135ab8f46b900f7a3888fbcc921e039412d5a8127e44d8f2dd2c8fc56f86
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 10, 2021
fa55104 build: use full version string in setup.exe (MarcoFalke) Pull request description: Fixes: bitcoin#15546 Tree-SHA512: a8ccbfef6b9fdd10bd0facadb25019b9296579eee6c8f7b4e5298cc4df52bba61864135ab8f46b900f7a3888fbcc921e039412d5a8127e44d8f2dd2c8fc56f86
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15546