Remove duplicate GetHash() in ConnectBlock #1554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
::addUnchecked()'s only caller already takes the necessary lock, and has already calculated the TX's hash.
Contributor
Author
|
Added new commit, to eliminate a dup GetHash in mempool code |
Member
There was a problem hiding this comment.
This BIP30 test has to happen before any transactions are connected. It is not allowed to create a new transaction whose last output is spent within the same block.
Contributor
There was a problem hiding this comment.
No changes to txdb are written in the loop, only to mapQueuedChanges.
Member
There was a problem hiding this comment.
Right, my mistake. I changed this in my ultraprune branch, however.
Contributor
Contributor
|
ACK |
jgarzik
pushed a commit
that referenced
this pull request
Jul 5, 2012
Remove duplicate GetHash() in ConnectBlock
nifgraup
pushed a commit
to nifgraup/auroracoin-project
that referenced
this pull request
Mar 30, 2014
Remove duplicate GetHash() in ConnectBlock
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #1486 contains a bunch of BlueMatt commits in a stack. Pulled out this one out of the stack, and rebased it on top of current HEAD.