add rpc_misc.py, mv test getmemoryinfo, add test mallocinfo #15485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
utACK 2e957b6ccaa41d13190bc5197865979f5f5265bf Good to split up the overly large |
maflcko
suggested changes
Feb 26, 2019
Member
maflcko
left a comment
maflcko
left a comment
There was a problem hiding this comment.
Oops, one assert issue I missed
adamjonas
force-pushed
the
test_rpc_misc
branch
from
2e957b6 to
8032a97
Compare
jnewbery
reviewed
Feb 26, 2019
Contributor
jnewbery
left a comment
jnewbery
left a comment
There was a problem hiding this comment.
Looks great. Thanks for doing this.
You'll need to update the file mode bits so this is executable. Run chmod 755 rpc_misc.py, then commit the file and push.
I've left some style nits inline. Up to you whether you take them or not.
adamjonas
force-pushed
the
test_rpc_misc
branch
from
8032a97 to
2fa85eb
Compare
maflcko
approved these changes
Feb 26, 2019
Member
|
re-utACK 2fa85eb |
Contributor
|
ACK 2fa85eb. Nice work! |
Contributor
|
Concept ACK What an excellent first-time contribution! Hope I'll see more contributions from you going forward! :-) |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Coverage
Updated at: 2019-02-26T21:19:47.481840. |
maflcko
reviewed
Feb 28, 2019
test/functional/rpc_misc.py
Outdated
| assert_greater_than(memory['used'], 0) | ||
| assert_greater_than(memory['free'], 0) | ||
| assert_greater_than(memory['total'], 0) | ||
| assert_greater_than(memory['locked'], 0) |
Member
There was a problem hiding this comment.
This fails on appveyor:
AssertionError: 0 <= 0
Contributor
There was a problem hiding this comment.
See assert_greater_than_or_equal()
| # Distributed under the MIT software license, see the accompanying | ||
| # file COPYING or http://www.opensource.org/licenses/mit-license.php. | ||
| """Test RPC misc output.""" | ||
| import xml.etree.ElementTree as ET |
Contributor
There was a problem hiding this comment.
Worth being aware of regarding the security of xml.etree.ElementTree:
Warning The xml.etree.ElementTree module is not secure against maliciously constructed data. If you need to parse untrusted or unauthenticated data see XML vulnerabilities.
We'll only be parsing trusted data from what I can think of, so likely not a problem in the testing code :-)
Member
Author
There was a problem hiding this comment.
Thanks for flagging @practicalswift. I was looking for other examples of xml libraries and this precedent that I tried to follow.
maflcko
pushed a commit
that referenced
this pull request
Mar 1, 2019
…info f13ad1c modify test for memory locked in case locking pages failed at some point (Adam Jonas) 2fa85eb add rpc_misc.py, mv test getmemoryinfo, add test mallocinfo (Adam Jonas) Pull request description: Creating the `rpc_misc.py` functional test file to add space for adding tests to a file that doesn't have a lot of coverage. - Removing the `getmemoryinfo()` smoke test from wallet basic rather than moving it to keep the wallet decoupled. Feel like testing for reasonable memory allocation values should suffice. - Adding coverage for `mallocinfo()`. Introduced standard lib XML parser since the function exports an XML string that describes the current state of the memory-allocation implementation in the caller. Tree-SHA512: ced30115622916c88d1e729969ee331272ec9f2881eb36dee4bb7331bf633a6810a57fed63a0cfaf86de698edb5162e6a035efd07c89ece1df56b69d61288072
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Mar 31, 2020
…info
Summary:
f13ad1cae0 modify test for memory locked in case locking pages failed at some point (Adam Jonas)
2fa85ebd1c add rpc_misc.py, mv test getmemoryinfo, add test mallocinfo (Adam Jonas)
Pull request description:
Creating the `rpc_misc.py` functional test file to add space for adding tests to a file that doesn't have a lot of coverage.
- Removing the `getmemoryinfo()` smoke test from wallet basic rather than moving it to keep the wallet decoupled. Feel like testing for reasonable memory allocation values should suffice.
- Adding coverage for `mallocinfo()`. Introduced standard lib XML parser since the function exports an XML string that describes the current state of the memory-allocation implementation in the caller.
Tree-SHA512: ced30115622916c88d1e729969ee331272ec9f2881eb36dee4bb7331bf633a6810a57fed63a0cfaf86de698edb5162e6a035efd07c89ece1df56b69d61288072
Backport of Core [[bitcoin/bitcoin#15485 | PR15485]]
Test Plan:
ninja check-functional
Verify `rpc_misc.py` is run and passes.
Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix
Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix
Differential Revision: https://reviews.bitcoinabc.org/D5626
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Aug 17, 2020
…info
Summary:
f13ad1cae0 modify test for memory locked in case locking pages failed at some point (Adam Jonas)
2fa85ebd1c add rpc_misc.py, mv test getmemoryinfo, add test mallocinfo (Adam Jonas)
Pull request description:
Creating the `rpc_misc.py` functional test file to add space for adding tests to a file that doesn't have a lot of coverage.
- Removing the `getmemoryinfo()` smoke test from wallet basic rather than moving it to keep the wallet decoupled. Feel like testing for reasonable memory allocation values should suffice.
- Adding coverage for `mallocinfo()`. Introduced standard lib XML parser since the function exports an XML string that describes the current state of the memory-allocation implementation in the caller.
Tree-SHA512: ced30115622916c88d1e729969ee331272ec9f2881eb36dee4bb7331bf633a6810a57fed63a0cfaf86de698edb5162e6a035efd07c89ece1df56b69d61288072
Backport of Core [[bitcoin/bitcoin#15485 | PR15485]]
Test Plan:
ninja check-functional
Verify `rpc_misc.py` is run and passes.
Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix
Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix
Differential Revision: https://reviews.bitcoinabc.org/D5626
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Sep 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating the
rpc_misc.pyfunctional test file to add space for adding tests to a file that doesn't have a lot of coverage.getmemoryinfo()smoke test from wallet basic rather than moving it to keep the wallet decoupled. Feel like testing for reasonable memory allocation values should suffice.mallocinfo(). Introduced standard lib XML parser since the function exports an XML string that describes the current state of the memory-allocation implementation in the caller.