rest/rpc: Make mempoolinfo atomic #15474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sounds good but need to review more thoroughly |
Member
|
So what is the point of locking in the public mempool calls in the first place? If there is no reason, I'd rather remove those locks and pass the responsibility (and flexibility) to lock to the caller. |
Contributor
Author
|
@MarcoFalke I was going that way but the change started to get big. Since it's a recursive mutex (for now) this is also correct. But I agree with you that some should just require the lock. |
maflcko
reviewed
Mar 6, 2019
promag
force-pushed
the
2019-02-atomic-mempoolinfo
branch
from
051ebac to
87a60eb
Compare
maflcko
reviewed
Mar 8, 2019
promag
force-pushed
the
2019-02-atomic-mempoolinfo
branch
from
87a60eb to
e377846
Compare
maflcko
pushed a commit
that referenced
this pull request
Apr 17, 2019
e377846 rest/rpc: Make mempoolinfo atomic (João Barbosa) Pull request description: Make `/rest/mempool/info.json` endpoint and `getmempoolinfo` RPC atomic. ACKs for commit e37784: Tree-SHA512: 6b40844df813e180d68731fc263bd9a2c2a01fe143a4f5a8974e3e0023e6e2e1e9bc46669ddfdf44f0e47142feda2a2aad1ea02ef8837081e11522347f314b0b
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 12, 2020
Summary: This is a backport of Core [[bitcoin/bitcoin#15474 | PR15474]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D8364
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Nov 4, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Nov 11, 2021
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Nov 12, 2021
merge bitcoin#15474...bitcoin#16774: miscellaneous backports
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
/rest/mempool/info.jsonendpoint andgetmempoolinfoRPC atomic.