wallet: Use fsbridge::ifstream to fix Windows path issue #15468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
Member
|
utACK 6ad79cb |
ryanofsky
approved these changes
Feb 25, 2019
Contributor
ryanofsky
left a comment
ryanofsky
left a comment
There was a problem hiding this comment.
utACK 6ad79cb. I was going to suggest that maybe there should be a linter only allowing use of fsbridge::ifstream, and not other ifstream classes. But this might be too strict because in a lot of cases we can know that filename being opened is ascii.
Contributor
|
Gitian builds for commit b4fc525 (master):
Gitian builds for commit fef7c84b5f7fbda799c55888f05fd7f06d5e5705 (master and this pull):
|
Member
|
utACK 6ad79cb |
Member
File system access should always go through the fsbridge when possible, this is better for sandboxing. So I think this would be appropriate, as well as mentioning this in the developer notes of course. |
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Mar 24, 2020
Summary: ``` If compiled with mingw, use glibc++ extension stdio_filebuf to open the file by FILE* instead of filename. In other condition, we can use boost::fstream. ``` Backport of core [[bitcoin/bitcoin#13878 | PR13878]] and [[bitcoin/bitcoin#15468 | PR15468]] (related bug fix). Depends on D5539. Test Plan: ninja check make check Run the Gitian builds. Build and run for Windows. Run `test_bitcoin` on Windows. Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D5539
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 11, 2021
…th issue 6ad79cb wallet: Use fsbridge::ifstream to fix Windows path issue (Chun Kuan Lee) Pull request description: Fix bitcoin#15460 Tree-SHA512: 1dab04184608543d49c86cbcfb679d63d35cb7bf3bde2e2d9ddf25ec8977de42b7131db5e81a305f3452858079dbcf68f6ad4624c89575d3d7e5b550687fc6ad
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15460