gui: Drop unused return values in WalletFrame #15464
Conversation
|
The first question that comes to mind for me is: should these return values be used? |
|
Not currently, and if there's a need then it should be used and tagged not discarded. |
|
So the intent is to ignore errors in these functions at the moment? |
|
What errors? |
|
I guess what @laanwj meant was if we should silently ignore things like if the wallet is already loaded or if we should transport that "error" to the user... I guess its captured earlier so I'm fine with this change. |
|
utACK 28c86de |
|
@jonasschnelli Yap, WalletController should validate those things, at this point these methods should simply work. I also plan to reduce those conditions so it's easier to reason about how these widgets work. |
|
utACK 28c86de (post 0.18 branch-off) |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
|
re-utACK 28c86de |
28c86de gui: Drop unused return values in WalletFrame (João Barbosa) Pull request description: This is a small cleanup since the return value of `WalletFrame` methods are not used. This is in line with the usual async slot declaration. Tree-SHA512: ff0ca098804118bba200a58cd796ff90e853a6430e58125bd178b7bfa9b2b763c13d17b81e8f3ebd94395cac249d80379ba1529680c47682ba6a2ed81492ba33
Summary: This is a backport of Core [[bitcoin/bitcoin#15464 | PR15464]] `addWallet` is not modified because the return value is added back and used in [[bitcoin/bitcoin#16963 | PR16963]] which was backported in D7699. Test Plan: `ninja && src/qt/bitcoin-qt` Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D8363
28c86de gui: Drop unused return values in WalletFrame (João Barbosa) Pull request description: This is a small cleanup since the return value of `WalletFrame` methods are not used. This is in line with the usual async slot declaration. Tree-SHA512: ff0ca098804118bba200a58cd796ff90e853a6430e58125bd178b7bfa9b2b763c13d17b81e8f3ebd94395cac249d80379ba1529680c47682ba6a2ed81492ba33
7 participants
This is a small cleanup since the return value of
WalletFramemethods are not used. This is in line with the usual async slot declaration.