[0.17] backport #14409 #15445
Closed
[0.17] backport #14409 #15445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@hebasto This is missing the |
The blocks directory is net specific by definition. Also this prevents the side effect of calling GetBlocksDir(false) in the non-mainnet environment. Github-Pull: bitcoin#14409 Rebased-From: c3f1821
A new node should not create an unused `blocks` directory in the root of the data directory when `-testnet` or `-regtest` is specified. Github-Pull: bitcoin#14409 Rebased-From: e4a0c35
hebasto
force-pushed
the
20190219-backport-pr14409
branch
from
e8d6c0a to
8cdd72e
Compare
Member
Author
Thank you. Fixed. |
Member
Author
|
|
Contributor
|
Is is necessary to be backported? It seems like a breaking change. |
Member
|
I don't think this is a breaking change. Otherwise this was missed in the original review |
laanwj
added a commit
that referenced
this pull request
Aug 29, 2019
0bd04c5 doc: update release notes for 0.17.2 (fanquake) 6b42df8 qt: 0.17.2 translation update (fanquake) c56c9ad doc: update manpages for 0.17.2 (fanquake) b4472f5 build: bump version to 0.17.2 (fanquake) Pull request description: Initial preparations for a 0.17.2 release. Needs a look over by laanwj (especially translations). Also need to check that everyone that should be included in the release notes has been included. #15445 is the last open [0.17.2 milestone](https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+is%3Apr+milestone%3A0.17.2) tagged PR. I'm not sure that it's a requirement though. ACKs for top commit: laanwj: ACK 0bd04c5 Tree-SHA512: b9017b2372f13188b69d90b3c08ce24abefff55afcbdadd405e47de4c1ba33add90b14222e773f5baa661027703a5285c30a463ff76f35a9b83e0d029f65bdbc
Member
|
Thanks, however I don't think this needs backporting into 0.17.2. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #14409 to the 0.17 branch.
#14409 makes the blocks directory net-specific by definition.