tests: remove byte.hex() to keep compatibility #15439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use test_framework.util.bytes_to_hex_str() instead of bytes.hex() that new in Python 3.5, to support minimum version of Python(test).
Member
|
Let's merge this after the branch off to 0.18 |
Member
To be clear: you want to merge this to the 0.18 branch after there is a 0.18 branch? |
Member
|
Yes, there is no reason to have this in the 0.19 brach |
Member
|
OK makes sense—let's ask @AkioNak to change the target branch when it's there |
Member
|
tACK 1a062b8. I'm OK with merging it into the 0.18 branch. Although it took me some time to find this after running into these test failures myself. |
Member
|
Ok, it appears at least two devs are using pyenv and would be unable to run the tests at all for the next two weeks. Going to merge this now and then revert in #14954 |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Feb 20, 2019
1a062b8 tests: remove byte.hex() to keep compatibility (Akio Nakamura) Pull request description: Use ```test_framework.util.bytes_to_hex_str()``` instead of ```bytes.hex()``` that new in Python 3.5 to support minimum version of Python(test). ```test/functional/test_framework/wallet_util.py``` is also reported to have '\.hex()' in bitcoin#15397, but it does not matter because it calls CScript.hex() defined in wallet_util.py. Tree-SHA512: 1019212e965f0848d235fab4da11959dffa42e8adfcd41216c10795cfc63c804b5deb5a3317f25d29940b9dcf088ab76fe3fa80d2679dc19f5f482dc5bde3283
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
test_framework.util.bytes_to_hex_str()instead ofbytes.hex()that new in Python 3.5 to support minimum version of Python(test).test/functional/test_framework/wallet_util.pyis also reported to have '.hex()' in #15397,but it does not matter because it calls CScript.hex() defined in wallet_util.py.