Skip to content

build: Bump minimum Qt version to 5.5.1 #15393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonasschnelli merged 1 commit into from
Feb 14, 2019
Merged

build: Bump minimum Qt version to 5.5.1 #15393

jonasschnelli merged 1 commit into from
Feb 14, 2019

Conversation

@Sjors
Copy link
Member

@Sjors Sjors commented Feb 12, 2019

Fixes #13478

Compiled and lightly tested on 10.14.3 against QT 5.12.0.

@maflcko maflcko changed the title Bump minimum Qt version to 5.5.1 build: Bump minimum Qt version to 5.5.1 Feb 12, 2019
@maflcko maflcko added this to the 0.18.0 milestone Feb 12, 2019
@luke-jr
Copy link
Member

luke-jr commented Feb 12, 2019

Is there an actual benefit to this?

Has anyone done a check for what versions come with current stable distros?

@maflcko
Copy link
Member

maflcko commented Feb 12, 2019 •
edited
Loading

Examples:

Also,

  • 5.5.1 is long EOL anyway and it'd be better if the user built qt from our depends
  • Bitcoin Core wouldn't compile with qt5.2 anyway

@fanquake
Copy link
Member

fanquake commented Feb 13, 2019

Concept ACK

fanquake
fanquake reviewed Feb 13, 2019
View reviewed changes
fanquake
fanquake reviewed Feb 13, 2019
View reviewed changes
@jonasschnelli
Copy link
Contributor

jonasschnelli commented Feb 13, 2019

Concept ACK

@Sjors
Copy link
Member Author

Sjors commented Feb 13, 2019

@luke-jr wrote:

Is there an actual benefit to this?

See discussion in #13478

I added a link to that discussion in doc/dependencies.md and dropped the Q_IMPORT_PLUGIN(AccessibleFactory) line.

practicalswift
practicalswift reviewed Feb 13, 2019
View reviewed changes
src/qt/test/apptests.cpp Outdated
Copy link
Contributor

@practicalswift practicalswift Feb 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could sort includes :-)

flack
flack reviewed Feb 13, 2019
View reviewed changes
build-aux/m4/bitcoin_qt.m4 Outdated
Copy link
Contributor

@flack flack Feb 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the QT_VERSION_MAJOR clause still needed? At first glance, it looks like a leftover from when Qt 4 was still supported

Copy link
Member Author

@Sjors Sjors Feb 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was assuming this is a generic check to see if QT >=5.5.1 is present at all, but haven't tried what happens with older QT versions.

Copy link
Contributor

@flack flack Feb 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to https://doc.qt.io/qt-5/qtglobal.html#QT_VERSION if QT_MAJOR_VERSION is 4, then QT_VERSION should be something like 0x040102, so it would already fail the first clause. IOW, I don't think there is any constellation where the first clause is false and the second one is true

Copy link
Member

@maflcko maflcko Feb 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could ask @TheCharlatan if there was a reason to do this in 28482ef

Copy link
Member Author

@Sjors Sjors Feb 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flack I thought you were referring to the entire line. Yes, I agree the || QT_VERSION_MAJOR < 5 bit seems redundant. That maybe have been in order to support both 4.x and 5.x from certain minor versions onward.

Copy link
Contributor

@sedited sedited Feb 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused about what the actual supported minor version was at the time. Either way, it is definitely redundant with this pr.

@fanquake
Copy link
Member

fanquake commented Feb 14, 2019

@Sjors Could you add release notes to this PR as well?

@DrahtBot
Copy link
Contributor

DrahtBot commented Feb 14, 2019

Gitian builds for commit 0d1160e (master):

Gitian builds for commit 1dae32ea42ef252b3b4be62858b73afb81adff81 (master and this pull):

@Sjors
Copy link
Member Author

Sjors commented Feb 14, 2019

Added release note. The gitian binaries should still be valid.

@Sjors
Copy link
Member Author

Sjors commented Feb 14, 2019

I removed the redundant || QT_VERSION_MAJOR < 5.

@maflcko
Copy link
Member

maflcko commented Feb 14, 2019 •
edited
Loading

There was a discussion on IRC that debian 8 comes with 5.3 (https://packages.debian.org/jessie/qt5-default)

The conclusion was that anyone on debian 8 should use our ./depends qt package: http://www.erisian.com.au/bitcoin-core-dev/log-2019-02-14.html#l-405

@hebasto
Copy link
Member

hebasto commented Feb 14, 2019

utACK fd46c4c

1 similar comment
@maflcko
Copy link
Member

maflcko commented Feb 14, 2019

utACK fd46c4c

@jonasschnelli jonasschnelli merged commit fd46c4c into bitcoin:master Feb 14, 2019
jonasschnelli added a commit that referenced this pull request Feb 14, 2019
@jonasschnelli
Merge #15393: build: Bump minimum Qt version to 5.5.1
3b33cbc 
fd46c4c Bump minimum Qt version to 5.5.1 (Sjors Provoost)

Pull request description:

  Fixes #13478

  Compiled and lightly tested on 10.14.3 against QT 5.12.0.

Tree-SHA512: 6890331969bbf4c66dc0993b8817b1f0831d008f5863554e9c09a38f4700260b84044ff961664c377decc9fb8300e3543c267f935ec64fbc97b20f8fb396247a
@Sjors Sjors deleted the 2019/02/qt-5_5 branch February 14, 2019 20:21
@Sjors Sjors mentioned this pull request Feb 21, 2019
Closed
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 29, 2019
@laanwj @sidhujag
Merge bitcoin#16708: qt: Replace obsolete functions of QSslSocket
d286a22 
2e1455c Replace obsolete functions of QSslSocket (Hennadii Stepanov)

Pull request description:

  The [`QSslSocket::setDefaultCaCertificates()`](https://doc.qt.io/qt-5/qsslsocket-obsolete.html#setDefaultCaCertificates) and [`QSslSocket::systemCaCertificates()`](https://doc.qt.io/qt-5/qsslsocket-obsolete.html#systemCaCertificates) member functions are [obsolete](https://doc.qt.io/qt-5.12/qsslsocket-obsolete.html) since Qt 5.12.

  This PR replaces them, does not change behavior and keeps compatibility with [Qt 5.5.1](bitcoin#15393).

ACKs for top commit:
  laanwj:
    ACK 2e1455c
  promag:
    ACK 2e1455c.

Tree-SHA512: 4182cd22a3e7a998d62a0fe84e748803a6962a65920b74da9fcf5666a700507468bb6e428054ccb70c2fbb7969a56933f450bc405c7a32ecbc1f8af4c1f983a3
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 29, 2019
@jonasschnelli @sidhujag
Merge bitcoin#16707: qt: Remove obsolete QModelIndex::child()
718fc65 
c536677 qt: Remove obsolete QModelIndex::child() (Hennadii Stepanov)

Pull request description:

  The `QModelIndex::child()` member function is [obsolete](https://doc.qt.io/qt-5.12/qmodelindex-obsolete.html) since Qt 5.12.

  This PR removes it, does not change behavior and keeps compatibility with [Qt 5.5.1](bitcoin#15393).

  Here is an excerpt from the master build log:
  ```
  qt/receivecoinsdialog.cpp: In member function ‘void ReceiveCoinsDialog::copyColumnToClipboard(int)’:
  qt/receivecoinsdialog.cpp:264:111: warning: ‘QModelIndex QModelIndex::child(int, int) const’ is deprecated: Use QAbstractItemModel::index [-Wdeprecated-declarations]
       GUIUtil::setClipboard(model->getRecentRequestsTableModel()->data(firstIndex.child(firstIndex.row(), column), Qt::EditRole).toString());
                                                                                                                 ^
  In file included from /home/hebasto/Qt/5.13.0/gcc_64/include/QtWidgets/qabstractitemview.h:45:0,
                   from /home/hebasto/Qt/5.13.0/gcc_64/include/QtWidgets/qheaderview.h:44,
                   from /home/hebasto/Qt/5.13.0/gcc_64/include/QtWidgets/QHeaderView:1,
                   from ./qt/guiutil.h:12,
                   from ./qt/receivecoinsdialog.h:8,
                   from qt/receivecoinsdialog.cpp:7:
  /home/hebasto/Qt/5.13.0/gcc_64/include/QtCore/qabstractitemmodel.h:457:20: note: declared here
   inline QModelIndex QModelIndex::child(int arow, int acolumn) const
                      ^~~~~~~~~~~
  ```

ACKs for top commit:
  laanwj:
    Code review ACK c536677
  promag:
    ACK c536677, just read the change.
  jonasschnelli:
    utACK c536677

Tree-SHA512: 99fcb6ff60a6d47b925bda9f14006269eaad09ba4f7a41ac4975c6cf04bd906b58aed721cbfa0be7da8e6613d92e30d4be18b7e4d3960f026c7226558a4c3196
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Feb 29, 2020
@laanwj @majcosta
[backport] qt: Replace obsolete functions of QSslSocket #16708
8d97e27 
Summary:
2e1455c4a100170c322165af3ecbbcd3004b2f9d Replace obsolete functions of QSslSocket (Hennadii Stepanov)

Pull request description:

The [`QSslSocket::setDefaultCaCertificates()`](https://doc.qt.io/qt-5/qsslsocket-obsolete.html#setDefaultCaCertificates) and [`QSslSocket::systemCaCertificates()`](https://doc.qt.io/qt-5/qsslsocket-obsolete.html#systemCaCertificates) member functions are [obsolete](https://doc.qt.io/qt-5.12/qsslsocket-obsolete.html) since Qt 5.12.

This PR replaces them, does not change behavior and keeps compatibility with [Qt 5.5.1](bitcoin/bitcoin#15393).

---

This is a backport of Core [[bitcoin/bitcoin#16708 | PR16708]]

Test Plan:
   ninja check

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5382
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Feb 29, 2020
@jonasschnelli @majcosta
[backport] qt: Remove obsolete QModelIndex::child() #16707
5bd3474 
Summary:
c53667764ea65c0f8661358759b0124f808ce587 qt: Remove obsolete QModelIndex::child() (Hennadii Stepanov)

Pull request description:

The `QModelIndex::child()` member function is [obsolete](https://doc.qt.io/qt-5.12/qmodelindex-obsolete.html) since Qt 5.12.

This PR removes it, does not change behavior and keeps compatibility with [Qt 5.5.1](bitcoin/bitcoin#15393).

---

This is a backport of Core [[bitcoin/bitcoin#16707 | PR16707]]

Test Plan:
   ninja check

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5385
ftrader pushed a commit to bitcoin-cash-node/bitcoin-cash-node that referenced this pull request Apr 16, 2020
@laanwj @cculianu
[backport] qt: Replace obsolete functions of QSslSocket #16708
4570248 
Summary:
2e1455c4a100170c322165af3ecbbcd3004b2f9d Replace obsolete functions of QSslSocket (Hennadii Stepanov)

Pull request description:

The [`QSslSocket::setDefaultCaCertificates()`](https://doc.qt.io/qt-5/qsslsocket-obsolete.html#setDefaultCaCertificates) and [`QSslSocket::systemCaCertificates()`](https://doc.qt.io/qt-5/qsslsocket-obsolete.html#systemCaCertificates) member functions are [obsolete](https://doc.qt.io/qt-5.12/qsslsocket-obsolete.html) since Qt 5.12.

This PR replaces them, does not change behavior and keeps compatibility with [Qt 5.5.1](bitcoin/bitcoin#15393).

---

This is a backport of Core [[bitcoin/bitcoin#16708 | PR16708]]

Test Plan:
   ninja check

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5382
ftrader pushed a commit to bitcoin-cash-node/bitcoin-cash-node that referenced this pull request Apr 16, 2020
@jonasschnelli @cculianu
[backport] qt: Remove obsolete QModelIndex::child() #16707
9149f81 
Summary:
c53667764ea65c0f8661358759b0124f808ce587 qt: Remove obsolete QModelIndex::child() (Hennadii Stepanov)

Pull request description:

The `QModelIndex::child()` member function is [obsolete](https://doc.qt.io/qt-5.12/qmodelindex-obsolete.html) since Qt 5.12.

This PR removes it, does not change behavior and keeps compatibility with [Qt 5.5.1](bitcoin/bitcoin#15393).

---

This is a backport of Core [[bitcoin/bitcoin#16707 | PR16707]]

Test Plan:
   ninja check

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5385
@10xcryptodev 10xcryptodev mentioned this pull request May 12, 2020
Merged
10xcryptodev pushed a commit to 10xcryptodev/dash that referenced this pull request Jun 12, 2020
@jonasschnelli @10xcryptodev
Merge bitcoin#15393: build: Bump minimum Qt version to 5.5.1
76cfc7c 
fd46c4c Bump minimum Qt version to 5.5.1 (Sjors Provoost)

Pull request description:

  Fixes bitcoin#13478

  Compiled and lightly tested on 10.14.3 against QT 5.12.0.

Tree-SHA512: 6890331969bbf4c66dc0993b8817b1f0831d008f5863554e9c09a38f4700260b84044ff961664c377decc9fb8300e3543c267f935ec64fbc97b20f8fb396247a
(cherry picked from commit 3b33cbc)

# Conflicts:
#	build-aux/m4/bitcoin_qt.m4
#	doc/dependencies.md
#	src/qt/test/apptests.cpp
#	src/qt/test/rpcnestedtests.cpp
monstrobishi pushed a commit to DeFiCh/ain that referenced this pull request Jul 30, 2020
@laanwj
Merge #16708: qt: Replace obsolete functions of QSslSocket
290cc97 
2e1455c Replace obsolete functions of QSslSocket (Hennadii Stepanov)

Pull request description:

  The [`QSslSocket::setDefaultCaCertificates()`](https://doc.qt.io/qt-5/qsslsocket-obsolete.html#setDefaultCaCertificates) and [`QSslSocket::systemCaCertificates()`](https://doc.qt.io/qt-5/qsslsocket-obsolete.html#systemCaCertificates) member functions are [obsolete](https://doc.qt.io/qt-5.12/qsslsocket-obsolete.html) since Qt 5.12.

  This PR replaces them, does not change behavior and keeps compatibility with [Qt 5.5.1](bitcoin/bitcoin#15393).

ACKs for top commit:
  laanwj:
    ACK 2e1455c
  promag:
    ACK 2e1455c.

Tree-SHA512: 4182cd22a3e7a998d62a0fe84e748803a6962a65920b74da9fcf5666a700507468bb6e428054ccb70c2fbb7969a56933f450bc405c7a32ecbc1f8af4c1f983a3
monstrobishi pushed a commit to DeFiCh/ain that referenced this pull request Jul 30, 2020
@jonasschnelli
Merge #16707: qt: Remove obsolete QModelIndex::child()
601838d 
c536677 qt: Remove obsolete QModelIndex::child() (Hennadii Stepanov)

Pull request description:

  The `QModelIndex::child()` member function is [obsolete](https://doc.qt.io/qt-5.12/qmodelindex-obsolete.html) since Qt 5.12.

  This PR removes it, does not change behavior and keeps compatibility with [Qt 5.5.1](bitcoin/bitcoin#15393).

  Here is an excerpt from the master build log:
  ```
  qt/receivecoinsdialog.cpp: In member function ‘void ReceiveCoinsDialog::copyColumnToClipboard(int)’:
  qt/receivecoinsdialog.cpp:264:111: warning: ‘QModelIndex QModelIndex::child(int, int) const’ is deprecated: Use QAbstractItemModel::index [-Wdeprecated-declarations]
       GUIUtil::setClipboard(model->getRecentRequestsTableModel()->data(firstIndex.child(firstIndex.row(), column), Qt::EditRole).toString());
                                                                                                                 ^
  In file included from /home/hebasto/Qt/5.13.0/gcc_64/include/QtWidgets/qabstractitemview.h:45:0,
                   from /home/hebasto/Qt/5.13.0/gcc_64/include/QtWidgets/qheaderview.h:44,
                   from /home/hebasto/Qt/5.13.0/gcc_64/include/QtWidgets/QHeaderView:1,
                   from ./qt/guiutil.h:12,
                   from ./qt/receivecoinsdialog.h:8,
                   from qt/receivecoinsdialog.cpp:7:
  /home/hebasto/Qt/5.13.0/gcc_64/include/QtCore/qabstractitemmodel.h:457:20: note: declared here
   inline QModelIndex QModelIndex::child(int arow, int acolumn) const
                      ^~~~~~~~~~~
  ```

ACKs for top commit:
  laanwj:
    Code review ACK c536677
  promag:
    ACK c536677, just read the change.
  jonasschnelli:
    utACK c536677

Tree-SHA512: 99fcb6ff60a6d47b925bda9f14006269eaad09ba4f7a41ac4975c6cf04bd906b58aed721cbfa0be7da8e6613d92e30d4be18b7e4d3960f026c7226558a4c3196
@hebasto hebasto mentioned this pull request Aug 9, 2020
Merged
fanquake added a commit that referenced this pull request Aug 24, 2020
@fanquake
Merge #19689: build: Add Qt version checking
38c13a4 
4af4672 build, qt: Add Qt version checking (Hennadii Stepanov)
30e336f build: Drop unused bitcoin_cv_qt58 (Hennadii Stepanov)

Pull request description:

  Now `configure` script checks that Qt version is not less then minimum required (currently [5.5.1](#15393)).

  This PR is an alternative to #15706 (see #15706 (comment)).

  Closes #15688.

  The first commit removes dead code (see #18297 (comment)).

ACKs for top commit:
  fanquake:
    ACK 4af4672 - this looks ok. I've tested this with Qt 5.15.0 and Qt 5.7.1 system libs, as well as 5.9.8 from depends.

Tree-SHA512: 8e3b82fa3a98926814923331038185633fabad962c271f31bd158e1ab293dcde52ab1dbf997745540a9ed27e16835cf5b5f3701d405876d877fa561eb03cc619
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 24, 2020
@fanquake
Merge bitcoin#19689: build: Add Qt version checking
dafb919 
4af4672 build, qt: Add Qt version checking (Hennadii Stepanov)
30e336f build: Drop unused bitcoin_cv_qt58 (Hennadii Stepanov)

Pull request description:

  Now `configure` script checks that Qt version is not less then minimum required (currently [5.5.1](bitcoin#15393)).

  This PR is an alternative to bitcoin#15706 (see bitcoin#15706 (comment)).

  Closes bitcoin#15688.

  The first commit removes dead code (see bitcoin#18297 (comment)).

ACKs for top commit:
  fanquake:
    ACK 4af4672 - this looks ok. I've tested this with Qt 5.15.0 and Qt 5.7.1 system libs, as well as 5.9.8 from depends.

Tree-SHA512: 8e3b82fa3a98926814923331038185633fabad962c271f31bd158e1ab293dcde52ab1dbf997745540a9ed27e16835cf5b5f3701d405876d877fa561eb03cc619
ShengguangXiao pushed a commit to DeFiCh/ain that referenced this pull request Aug 28, 2020
@laanwj
Merge #16708: qt: Replace obsolete functions of QSslSocket
fdfcde0 
7e1a6bd Replace obsolete functions of QSslSocket (Hennadii Stepanov)

Pull request description:

  The [`QSslSocket::setDefaultCaCertificates()`](https://doc.qt.io/qt-5/qsslsocket-obsolete.html#setDefaultCaCertificates) and [`QSslSocket::systemCaCertificates()`](https://doc.qt.io/qt-5/qsslsocket-obsolete.html#systemCaCertificates) member functions are [obsolete](https://doc.qt.io/qt-5.12/qsslsocket-obsolete.html) since Qt 5.12.

  This PR replaces them, does not change behavior and keeps compatibility with [Qt 5.5.1](bitcoin/bitcoin#15393).

ACKs for top commit:
  laanwj:
    ACK 7e1a6bd
  promag:
    ACK 7e1a6bd.

Tree-SHA512: 4182cd22a3e7a998d62a0fe84e748803a6962a65920b74da9fcf5666a700507468bb6e428054ccb70c2fbb7969a56933f450bc405c7a32ecbc1f8af4c1f983a3
ShengguangXiao pushed a commit to DeFiCh/ain that referenced this pull request Aug 28, 2020
@jonasschnelli
Merge #16707: qt: Remove obsolete QModelIndex::child()
f038d96 
41f91ae qt: Remove obsolete QModelIndex::child() (Hennadii Stepanov)

Pull request description:

  The `QModelIndex::child()` member function is [obsolete](https://doc.qt.io/qt-5.12/qmodelindex-obsolete.html) since Qt 5.12.

  This PR removes it, does not change behavior and keeps compatibility with [Qt 5.5.1](bitcoin/bitcoin#15393).

  Here is an excerpt from the master build log:
  ```
  qt/receivecoinsdialog.cpp: In member function ‘void ReceiveCoinsDialog::copyColumnToClipboard(int)’:
  qt/receivecoinsdialog.cpp:264:111: warning: ‘QModelIndex QModelIndex::child(int, int) const’ is deprecated: Use QAbstractItemModel::index [-Wdeprecated-declarations]
       GUIUtil::setClipboard(model->getRecentRequestsTableModel()->data(firstIndex.child(firstIndex.row(), column), Qt::EditRole).toString());
                                                                                                                 ^
  In file included from /home/hebasto/Qt/5.13.0/gcc_64/include/QtWidgets/qabstractitemview.h:45:0,
                   from /home/hebasto/Qt/5.13.0/gcc_64/include/QtWidgets/qheaderview.h:44,
                   from /home/hebasto/Qt/5.13.0/gcc_64/include/QtWidgets/QHeaderView:1,
                   from ./qt/guiutil.h:12,
                   from ./qt/receivecoinsdialog.h:8,
                   from qt/receivecoinsdialog.cpp:7:
  /home/hebasto/Qt/5.13.0/gcc_64/include/QtCore/qabstractitemmodel.h:457:20: note: declared here
   inline QModelIndex QModelIndex::child(int arow, int acolumn) const
                      ^~~~~~~~~~~
  ```

ACKs for top commit:
  laanwj:
    Code review ACK 41f91ae
  promag:
    ACK 41f91ae, just read the change.
  jonasschnelli:
    utACK 41f91ae

Tree-SHA512: 99fcb6ff60a6d47b925bda9f14006269eaad09ba4f7a41ac4975c6cf04bd906b58aed721cbfa0be7da8e6613d92e30d4be18b7e4d3960f026c7226558a4c3196
@hebasto hebasto mentioned this pull request Sep 13, 2020
Open
@hebasto hebasto mentioned this pull request Oct 8, 2020
Closed
xdustinface pushed a commit to xdustinface/dash that referenced this pull request Feb 17, 2021
@fanquake @xdustinface
Merge bitcoin#19689: build: Add Qt version checking
3e86876 
4af4672 build, qt: Add Qt version checking (Hennadii Stepanov)
30e336f build: Drop unused bitcoin_cv_qt58 (Hennadii Stepanov)

Pull request description:

  Now `configure` script checks that Qt version is not less then minimum required (currently [5.5.1](bitcoin#15393)).

  This PR is an alternative to bitcoin#15706 (see bitcoin#15706 (comment)).

  Closes bitcoin#15688.

  The first commit removes dead code (see bitcoin#18297 (comment)).

ACKs for top commit:
  fanquake:
    ACK 4af4672 - this looks ok. I've tested this with Qt 5.15.0 and Qt 5.7.1 system libs, as well as 5.9.8 from depends.

Tree-SHA512: 8e3b82fa3a98926814923331038185633fabad962c271f31bd158e1ab293dcde52ab1dbf997745540a9ed27e16835cf5b5f3701d405876d877fa561eb03cc619
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Jun 27, 2021
@jonasschnelli @gades
Merge bitcoin#15393: build: Bump minimum Qt version to 5.5.1
0959261 
fd46c4c Bump minimum Qt version to 5.5.1 (Sjors Provoost)

Pull request description:

  Fixes bitcoin#13478

  Compiled and lightly tested on 10.14.3 against QT 5.12.0.

Tree-SHA512: 6890331969bbf4c66dc0993b8817b1f0831d008f5863554e9c09a38f4700260b84044ff961664c377decc9fb8300e3543c267f935ec64fbc97b20f8fb396247a
(cherry picked from commit 3b33cbc)
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Jun 27, 2021
@fanquake @gades
Merge bitcoin#19689: build: Add Qt version checking
0e12d03 
4af4672 build, qt: Add Qt version checking (Hennadii Stepanov)
30e336f build: Drop unused bitcoin_cv_qt58 (Hennadii Stepanov)

Pull request description:

  Now `configure` script checks that Qt version is not less then minimum required (currently [5.5.1](bitcoin#15393)).

  This PR is an alternative to bitcoin#15706 (see bitcoin#15706 (comment)).

  Closes bitcoin#15688.

  The first commit removes dead code (see bitcoin#18297 (comment)).

ACKs for top commit:
  fanquake:
    ACK 4af4672 - this looks ok. I've tested this with Qt 5.15.0 and Qt 5.7.1 system libs, as well as 5.9.8 from depends.

Tree-SHA512: 8e3b82fa3a98926814923331038185633fabad962c271f31bd158e1ab293dcde52ab1dbf997745540a9ed27e16835cf5b5f3701d405876d877fa561eb03cc619
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 11, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#16708: qt: Replace obsolete functions of QSslSocket
194bb53 
2e1455c Replace obsolete functions of QSslSocket (Hennadii Stepanov)

Pull request description:

  The [`QSslSocket::setDefaultCaCertificates()`](https://doc.qt.io/qt-5/qsslsocket-obsolete.html#setDefaultCaCertificates) and [`QSslSocket::systemCaCertificates()`](https://doc.qt.io/qt-5/qsslsocket-obsolete.html#systemCaCertificates) member functions are [obsolete](https://doc.qt.io/qt-5.12/qsslsocket-obsolete.html) since Qt 5.12.

  This PR replaces them, does not change behavior and keeps compatibility with [Qt 5.5.1](bitcoin#15393).

ACKs for top commit:
  laanwj:
    ACK 2e1455c
  promag:
    ACK 2e1455c.

Tree-SHA512: 4182cd22a3e7a998d62a0fe84e748803a6962a65920b74da9fcf5666a700507468bb6e428054ccb70c2fbb7969a56933f450bc405c7a32ecbc1f8af4c1f983a3
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 14, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#16708: qt: Replace obsolete functions of QSslSocket
54bfed1 
2e1455c Replace obsolete functions of QSslSocket (Hennadii Stepanov)

Pull request description:

  The [`QSslSocket::setDefaultCaCertificates()`](https://doc.qt.io/qt-5/qsslsocket-obsolete.html#setDefaultCaCertificates) and [`QSslSocket::systemCaCertificates()`](https://doc.qt.io/qt-5/qsslsocket-obsolete.html#systemCaCertificates) member functions are [obsolete](https://doc.qt.io/qt-5.12/qsslsocket-obsolete.html) since Qt 5.12.

  This PR replaces them, does not change behavior and keeps compatibility with [Qt 5.5.1](bitcoin#15393).

ACKs for top commit:
  laanwj:
    ACK 2e1455c
  promag:
    ACK 2e1455c.

Tree-SHA512: 4182cd22a3e7a998d62a0fe84e748803a6962a65920b74da9fcf5666a700507468bb6e428054ccb70c2fbb7969a56933f450bc405c7a32ecbc1f8af4c1f983a3
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fanquake fanquake fanquake left review comments

@sedited sedited sedited left review comments

+3 more reviewers

@flack flack flack left review comments

@maflcko maflcko maflcko left review comments

@practicalswift practicalswift practicalswift left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Build system

Projects

None yet

Milestone

0.18.0

Development

Successfully merging this pull request may close these issues.

[RFC] gui: Minimum required Qt5