[build] Makefile.am: add rule for src/bitcoin-wallet #15388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I just duplicated everything to make it consistent with @jnewbery: I think this was missing from #13926 @ken2812221 does the Windows installer bit look OK? @MarcoFalke this probably needs a Gitian build. |
Member
|
LGTM utACK c9741df |
Contributor
|
utACK c9741df229652ff1ea2a14d705a8fac727d6cd55. Thanks @Sjors! |
Contributor
|
Tested ACK c9741df on macOS. |
luke-jr
suggested changes
Feb 12, 2019
Sjors
force-pushed
the
2019/02/wallet_tool_make
branch
from
c9741df to
cb870bb
Compare
Member
Author
|
Also added to |
Sjors
force-pushed
the
2019/02/wallet_tool_make
branch
from
cb870bb to
1852eff
Compare
Member
Author
|
I added 7640765 to see if busting AppVeyor cache (again) can help with breaking builds in master. It's otherwise unrelated to this PR so I can drop the commit or move it to another PR later if needed. |
Sjors
force-pushed
the
2019/02/wallet_tool_make
branch
2 times, most recently
from
7640765 to
1852eff
Compare
Member
Author
Sjors
force-pushed
the
2019/02/wallet_tool_make
branch
from
1852eff to
4a43eb8
Compare
maflcko
pushed a commit
that referenced
this pull request
Feb 14, 2019
4a43eb8 [build] Makefile.am: add rule for src/bitcoin-wallet (Sjors Provoost) Pull request description: Otherwise `make src/bitcoin-wallet` will fail with `No rule to make target`. Also adds `bitcoin-wallet.exe` to the Windows installer. Tree-SHA512: 932c34b349ec3efa17d1f1251d386434d0db6a07939d500236364a851468981c69392e2a00e26c9753d9b2d8ef056b5de870c5bd5202aa0c73326f9ed1403681
Contributor
|
Gitian builds for commit 0d1160e (master):
Gitian builds for commit a88d457155881cda117dbf84bd73c05f6bbdf804 (master and this pull):
|
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
…llet 4a43eb8 [build] Makefile.am: add rule for src/bitcoin-wallet (Sjors Provoost) Pull request description: Otherwise `make src/bitcoin-wallet` will fail with `No rule to make target`. Also adds `bitcoin-wallet.exe` to the Windows installer. Tree-SHA512: 932c34b349ec3efa17d1f1251d386434d0db6a07939d500236364a851468981c69392e2a00e26c9753d9b2d8ef056b5de870c5bd5202aa0c73326f9ed1403681
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 11, 2021
…llet 4a43eb8 [build] Makefile.am: add rule for src/bitcoin-wallet (Sjors Provoost) Pull request description: Otherwise `make src/bitcoin-wallet` will fail with `No rule to make target`. Also adds `bitcoin-wallet.exe` to the Windows installer. Tree-SHA512: 932c34b349ec3efa17d1f1251d386434d0db6a07939d500236364a851468981c69392e2a00e26c9753d9b2d8ef056b5de870c5bd5202aa0c73326f9ed1403681
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise
make src/bitcoin-walletwill fail withNo rule to make target.Also adds
bitcoin-wallet.exeto the Windows installer.