tests: Reduce noise level in test_bitcoin output #15352

practicalswift · 2019-02-06T10:05:10Z

Reduce noise level in test_bitcoin output.

Context: When working on the non-determinism issues in the unit tests (see #15296) I got a bit tired of the amount of noise in the test_bitcoin output :-)

Before:

$ src/test/test_bitcoin --log_level=test_suite 2>&1 | grep -vE '(Entering|Leaving)' | uniq -c
      1 Running 341 test cases...
      1 Test case blockencodings_tests/TransactionsRequestDeserializationOverflowTest did not check any assertions
      1 CheckSplitTorReplyLine(PROTOCOLINFO PIVERSION)
      1 CheckSplitTorReplyLine(AUTH METHODS=COOKIE,SAFECOOKIE COOKIEFILE="/home/x/.tor/control_auth_cookie")
      1 CheckSplitTorReplyLine(AUTH METHODS=NULL)
      1 CheckSplitTorReplyLine(AUTH METHODS=HASHEDPASSWORD)
      1 CheckSplitTorReplyLine(VERSION Tor="0.2.9.8 (git-a0df013ea241b026)")
      1 CheckSplitTorReplyLine(AUTHCHALLENGE SERVERHASH=aaaa SERVERNONCE=bbbb)
      1 CheckSplitTorReplyLine(COMMAND)
      1 CheckSplitTorReplyLine(COMMAND SOME  ARGS)
      1 CheckSplitTorReplyLine(COMMAND  ARGS)
      1 CheckSplitTorReplyLine(COMMAND   EVEN+more  ARGS)
      1 CheckParseTorReplyMapping(METHODS=COOKIE,SAFECOOKIE COOKIEFILE="/home/x/.tor/control_auth_cookie")
      1 CheckParseTorReplyMapping(METHODS=NULL)
      1 CheckParseTorReplyMapping(METHODS=HASHEDPASSWORD)
      1 CheckParseTorReplyMapping(Tor="0.2.9.8 (git-a0df013ea241b026)")
      1 CheckParseTorReplyMapping(SERVERHASH=aaaa SERVERNONCE=bbbb)
      1 CheckParseTorReplyMapping(ServiceID=exampleonion1234)
      1 CheckParseTorReplyMapping(PrivateKey=RSA1024:BLOB)
      1 CheckParseTorReplyMapping(ClientAuth=bob:BLOB)
      1 CheckParseTorReplyMapping(Foo=Bar=Baz Spam=Eggs)
      1 CheckParseTorReplyMapping(Foo="Bar=Baz")
      1 CheckParseTorReplyMapping(Foo="Bar Baz")
      1 CheckParseTorReplyMapping(Foo="Bar\ Baz")
      1 CheckParseTorReplyMapping(Foo="Bar\Baz")
      1 CheckParseTorReplyMapping(Foo="Bar\@Baz")
      1 CheckParseTorReplyMapping(Foo="Bar\"Baz" Spam="\"Eggs\"")
      1 CheckParseTorReplyMapping(Foo="Bar\\Baz")
      1 CheckParseTorReplyMapping(Foo="Bar\nBaz\t" Spam="\rEggs" Octals="\1a\11\17\18\81\377\378\400\2222" Final=Check)
      1 CheckParseTorReplyMapping(Valid=Mapping Escaped="Escape\\")
      1 CheckParseTorReplyMapping(Valid=Mapping Bare="Escape\")
      1 CheckParseTorReplyMapping(OneOctal="OneEnd\1" TwoOctal="TwoEnd\11")
      1 CheckParseTorReplyMapping(Null="\0")
      1 CheckParseTorReplyMapping(SOME=args,here MORE optional=arguments  here)
      1 CheckParseTorReplyMapping(ARGS)
      1 CheckParseTorReplyMapping(MORE ARGS)
      1 CheckParseTorReplyMapping(MORE  ARGS)
      1 CheckParseTorReplyMapping(EVEN more=ARGS)
      1 CheckParseTorReplyMapping(EVEN+more ARGS)
      1 Test case util_tests/util_criticalsection did not check any assertions
      1 Testing known outcomes
    326 Error: Specified -walletdir "/tmp/test_bitcoin/1553850209_943311758/tempdir/path_does_not_exist" does not exist
    327 Error: Specified -walletdir "/tmp/test_bitcoin/1553850209_643733972/tempdir/not_a_directory.dat" is not a directory
    328 Error: Specified -walletdir "wallets" is a relative path
      1
      1 *** No errors detected

After:

$ src/test/test_bitcoin --log_level=test_suite 2>&1 | grep -vE '(Entering|Leaving)' | uniq -c
      1 Running 341 test cases...
      1 Error: Specified -walletdir "/tmp/test_bitcoin/1553850026_943311758/tempdir/path_does_not_exist" does not exist
      1 Error: Specified -walletdir "/tmp/test_bitcoin/1553850026_643733972/tempdir/not_a_directory.dat" is not a directory
      1 Error: Specified -walletdir "wallets" is a relative path
      1
      1 *** No errors detected

promag · 2019-02-06T13:30:31Z

Concept ACK.

src/noui.cpp

practicalswift · 2019-03-27T15:01:25Z

Updated in light of @laanwj and @MarcoFalke's feedback. Thanks!

Please re-review :-)

src/noui.h

src/test/test_bitcoin.cpp

maflcko

utACK

src/test/blockencodings_tests.cpp

src/test/util_tests.cpp

src/test/test_bitcoin.cpp

practicalswift · 2019-03-29T09:10:52Z

Please review updated version.

I found the root cause to the nine hundred (!) lines of debug outputted when running test_bitcoin compiled from current master.

Turns out we are running noui_connect() once per test (more specifically: we call noui_connect() in the ctor of BasicTestingSetup) which means that we end up with quite a few logging functions connected to the signals :-)

Now connecting only once.

Please re-review :-)

Before this PR (note how the wallet messages are repeated >300 times each! :-)):

$ src/test/test_bitcoin --log_level=test_suite 2>&1 | grep -vE '(Entering|Leaving)' | uniq -c
      1 Running 341 test cases...
      1 Test case blockencodings_tests/TransactionsRequestDeserializationOverflowTest did not check any assertions
      1 CheckSplitTorReplyLine(PROTOCOLINFO PIVERSION)
      1 CheckSplitTorReplyLine(AUTH METHODS=COOKIE,SAFECOOKIE COOKIEFILE="/home/x/.tor/control_auth_cookie")
      1 CheckSplitTorReplyLine(AUTH METHODS=NULL)
      1 CheckSplitTorReplyLine(AUTH METHODS=HASHEDPASSWORD)
      1 CheckSplitTorReplyLine(VERSION Tor="0.2.9.8 (git-a0df013ea241b026)")
      1 CheckSplitTorReplyLine(AUTHCHALLENGE SERVERHASH=aaaa SERVERNONCE=bbbb)
      1 CheckSplitTorReplyLine(COMMAND)
      1 CheckSplitTorReplyLine(COMMAND SOME  ARGS)
      1 CheckSplitTorReplyLine(COMMAND  ARGS)
      1 CheckSplitTorReplyLine(COMMAND   EVEN+more  ARGS)
      1 CheckParseTorReplyMapping(METHODS=COOKIE,SAFECOOKIE COOKIEFILE="/home/x/.tor/control_auth_cookie")
      1 CheckParseTorReplyMapping(METHODS=NULL)
      1 CheckParseTorReplyMapping(METHODS=HASHEDPASSWORD)
      1 CheckParseTorReplyMapping(Tor="0.2.9.8 (git-a0df013ea241b026)")
      1 CheckParseTorReplyMapping(SERVERHASH=aaaa SERVERNONCE=bbbb)
      1 CheckParseTorReplyMapping(ServiceID=exampleonion1234)
      1 CheckParseTorReplyMapping(PrivateKey=RSA1024:BLOB)
      1 CheckParseTorReplyMapping(ClientAuth=bob:BLOB)
      1 CheckParseTorReplyMapping(Foo=Bar=Baz Spam=Eggs)
      1 CheckParseTorReplyMapping(Foo="Bar=Baz")
      1 CheckParseTorReplyMapping(Foo="Bar Baz")
      1 CheckParseTorReplyMapping(Foo="Bar\ Baz")
      1 CheckParseTorReplyMapping(Foo="Bar\Baz")
      1 CheckParseTorReplyMapping(Foo="Bar\@Baz")
      1 CheckParseTorReplyMapping(Foo="Bar\"Baz" Spam="\"Eggs\"")
      1 CheckParseTorReplyMapping(Foo="Bar\\Baz")
      1 CheckParseTorReplyMapping(Foo="Bar\nBaz\t" Spam="\rEggs" Octals="\1a\11\17\18\81\377\378\400\2222" Final=Check)
      1 CheckParseTorReplyMapping(Valid=Mapping Escaped="Escape\\")
      1 CheckParseTorReplyMapping(Valid=Mapping Bare="Escape\")
      1 CheckParseTorReplyMapping(OneOctal="OneEnd\1" TwoOctal="TwoEnd\11")
      1 CheckParseTorReplyMapping(Null="\0")
      1 CheckParseTorReplyMapping(SOME=args,here MORE optional=arguments  here)
      1 CheckParseTorReplyMapping(ARGS)
      1 CheckParseTorReplyMapping(MORE ARGS)
      1 CheckParseTorReplyMapping(MORE  ARGS)
      1 CheckParseTorReplyMapping(EVEN more=ARGS)
      1 CheckParseTorReplyMapping(EVEN+more ARGS)
      1 Test case util_tests/util_criticalsection did not check any assertions
      1 Testing known outcomes
    326 Error: Specified -walletdir "/tmp/test_bitcoin/1553850209_943311758/tempdir/path_does_not_exist" does not exist
    327 Error: Specified -walletdir "/tmp/test_bitcoin/1553850209_643733972/tempdir/not_a_directory.dat" is not a directory
    328 Error: Specified -walletdir "wallets" is a relative path
      1
      1 *** No errors detected

After this PR:

$ src/test/test_bitcoin --log_level=test_suite 2>&1 | grep -vE '(Entering|Leaving)' | uniq -c
      1 Running 341 test cases...
      1 Error: Specified -walletdir "/tmp/test_bitcoin/1553850026_943311758/tempdir/path_does_not_exist" does not exist
      1 Error: Specified -walletdir "/tmp/test_bitcoin/1553850026_643733972/tempdir/not_a_directory.dat" is not a directory
      1 Error: Specified -walletdir "wallets" is a relative path
      1
      1 *** No errors detected

… (ThreadSafeMessageBox, etc.) only once

…running "test_bitcoin --log_level=test_suite"

maflcko · 2019-03-29T15:43:20Z

utACK 0aef39d

DrahtBot · 2019-04-16T17:14:50Z

Needs rebase

maflcko · 2019-04-16T18:19:48Z

Merged via git's auto-merge

@baz

0aef39d Silence "Test case [...] did not check any assertions" warnings when running "test_bitcoin --log_level=test_suite" (practicalswift) 5fd73c8 Avoid repeated log messages in tests by connecting to signal handlers (ThreadSafeMessageBox, etc.) only once (practicalswift) e502c3c tests: Reduce noise level in test_bitcoin output (practicalswift) Pull request description: Reduce noise level in `test_bitcoin` output. Context: When working on the non-determinism issues in the unit tests (see #15296) I got a bit tired of the amount of noise in the `test_bitcoin` output :-) Before: ``` $ src/test/test_bitcoin --log_level=test_suite 2>&1 | grep -vE '(Entering|Leaving)' | uniq -c 1 Running 341 test cases... 1 Test case blockencodings_tests/TransactionsRequestDeserializationOverflowTest did not check any assertions 1 CheckSplitTorReplyLine(PROTOCOLINFO PIVERSION) 1 CheckSplitTorReplyLine(AUTH METHODS=COOKIE,SAFECOOKIE COOKIEFILE="/home/x/.tor/control_auth_cookie") 1 CheckSplitTorReplyLine(AUTH METHODS=NULL) 1 CheckSplitTorReplyLine(AUTH METHODS=HASHEDPASSWORD) 1 CheckSplitTorReplyLine(VERSION Tor="0.2.9.8 (git-a0df013ea241b026)") 1 CheckSplitTorReplyLine(AUTHCHALLENGE SERVERHASH=aaaa SERVERNONCE=bbbb) 1 CheckSplitTorReplyLine(COMMAND) 1 CheckSplitTorReplyLine(COMMAND SOME ARGS) 1 CheckSplitTorReplyLine(COMMAND ARGS) 1 CheckSplitTorReplyLine(COMMAND EVEN+more ARGS) 1 CheckParseTorReplyMapping(METHODS=COOKIE,SAFECOOKIE COOKIEFILE="/home/x/.tor/control_auth_cookie") 1 CheckParseTorReplyMapping(METHODS=NULL) 1 CheckParseTorReplyMapping(METHODS=HASHEDPASSWORD) 1 CheckParseTorReplyMapping(Tor="0.2.9.8 (git-a0df013ea241b026)") 1 CheckParseTorReplyMapping(SERVERHASH=aaaa SERVERNONCE=bbbb) 1 CheckParseTorReplyMapping(ServiceID=exampleonion1234) 1 CheckParseTorReplyMapping(PrivateKey=RSA1024:BLOB) 1 CheckParseTorReplyMapping(ClientAuth=bob:BLOB) 1 CheckParseTorReplyMapping(Foo=Bar=Baz Spam=Eggs) 1 CheckParseTorReplyMapping(Foo="Bar=Baz") 1 CheckParseTorReplyMapping(Foo="Bar Baz") 1 CheckParseTorReplyMapping(Foo="Bar\ Baz") 1 CheckParseTorReplyMapping(Foo="Bar\Baz") 1 CheckParseTorReplyMapping(Foo="Bar\@baz") 1 CheckParseTorReplyMapping(Foo="Bar\"Baz" Spam="\"Eggs\"") 1 CheckParseTorReplyMapping(Foo="Bar\\Baz") 1 CheckParseTorReplyMapping(Foo="Bar\nBaz\t" Spam="\rEggs" Octals="\1a\11\17\18\81\377\378\400\2222" Final=Check) 1 CheckParseTorReplyMapping(Valid=Mapping Escaped="Escape\\") 1 CheckParseTorReplyMapping(Valid=Mapping Bare="Escape\") 1 CheckParseTorReplyMapping(OneOctal="OneEnd\1" TwoOctal="TwoEnd\11") 1 CheckParseTorReplyMapping(Null="\0") 1 CheckParseTorReplyMapping(SOME=args,here MORE optional=arguments here) 1 CheckParseTorReplyMapping(ARGS) 1 CheckParseTorReplyMapping(MORE ARGS) 1 CheckParseTorReplyMapping(MORE ARGS) 1 CheckParseTorReplyMapping(EVEN more=ARGS) 1 CheckParseTorReplyMapping(EVEN+more ARGS) 1 Test case util_tests/util_criticalsection did not check any assertions 1 Testing known outcomes 326 Error: Specified -walletdir "/tmp/test_bitcoin/1553850209_943311758/tempdir/path_does_not_exist" does not exist 327 Error: Specified -walletdir "/tmp/test_bitcoin/1553850209_643733972/tempdir/not_a_directory.dat" is not a directory 328 Error: Specified -walletdir "wallets" is a relative path 1 1 *** No errors detected ``` After: ``` $ src/test/test_bitcoin --log_level=test_suite 2>&1 | grep -vE '(Entering|Leaving)' | uniq -c 1 Running 341 test cases... 1 Error: Specified -walletdir "/tmp/test_bitcoin/1553850026_943311758/tempdir/path_does_not_exist" does not exist 1 Error: Specified -walletdir "/tmp/test_bitcoin/1553850026_643733972/tempdir/not_a_directory.dat" is not a directory 1 Error: Specified -walletdir "wallets" is a relative path 1 1 *** No errors detected ``` ACKs for commit 0aef39: MarcoFalke: utACK 0aef39d Tree-SHA512: 9cc22f64aa5c875861bae6533d18675ad978c623f053754deef6a8e271ea70bda3f72fb4ec5c8fd19b841757f21380639051d5f5b44301b9d2464b57655e9c05

@baz

0aef39d Silence "Test case [...] did not check any assertions" warnings when running "test_bitcoin --log_level=test_suite" (practicalswift) 5fd73c8 Avoid repeated log messages in tests by connecting to signal handlers (ThreadSafeMessageBox, etc.) only once (practicalswift) e502c3c tests: Reduce noise level in test_bitcoin output (practicalswift) Pull request description: Reduce noise level in `test_bitcoin` output. Context: When working on the non-determinism issues in the unit tests (see bitcoin#15296) I got a bit tired of the amount of noise in the `test_bitcoin` output :-) Before: ``` $ src/test/test_bitcoin --log_level=test_suite 2>&1 | grep -vE '(Entering|Leaving)' | uniq -c 1 Running 341 test cases... 1 Test case blockencodings_tests/TransactionsRequestDeserializationOverflowTest did not check any assertions 1 CheckSplitTorReplyLine(PROTOCOLINFO PIVERSION) 1 CheckSplitTorReplyLine(AUTH METHODS=COOKIE,SAFECOOKIE COOKIEFILE="/home/x/.tor/control_auth_cookie") 1 CheckSplitTorReplyLine(AUTH METHODS=NULL) 1 CheckSplitTorReplyLine(AUTH METHODS=HASHEDPASSWORD) 1 CheckSplitTorReplyLine(VERSION Tor="0.2.9.8 (git-a0df013ea241b026)") 1 CheckSplitTorReplyLine(AUTHCHALLENGE SERVERHASH=aaaa SERVERNONCE=bbbb) 1 CheckSplitTorReplyLine(COMMAND) 1 CheckSplitTorReplyLine(COMMAND SOME ARGS) 1 CheckSplitTorReplyLine(COMMAND ARGS) 1 CheckSplitTorReplyLine(COMMAND EVEN+more ARGS) 1 CheckParseTorReplyMapping(METHODS=COOKIE,SAFECOOKIE COOKIEFILE="/home/x/.tor/control_auth_cookie") 1 CheckParseTorReplyMapping(METHODS=NULL) 1 CheckParseTorReplyMapping(METHODS=HASHEDPASSWORD) 1 CheckParseTorReplyMapping(Tor="0.2.9.8 (git-a0df013ea241b026)") 1 CheckParseTorReplyMapping(SERVERHASH=aaaa SERVERNONCE=bbbb) 1 CheckParseTorReplyMapping(ServiceID=exampleonion1234) 1 CheckParseTorReplyMapping(PrivateKey=RSA1024:BLOB) 1 CheckParseTorReplyMapping(ClientAuth=bob:BLOB) 1 CheckParseTorReplyMapping(Foo=Bar=Baz Spam=Eggs) 1 CheckParseTorReplyMapping(Foo="Bar=Baz") 1 CheckParseTorReplyMapping(Foo="Bar Baz") 1 CheckParseTorReplyMapping(Foo="Bar\ Baz") 1 CheckParseTorReplyMapping(Foo="Bar\Baz") 1 CheckParseTorReplyMapping(Foo="Bar\@baz") 1 CheckParseTorReplyMapping(Foo="Bar\"Baz" Spam="\"Eggs\"") 1 CheckParseTorReplyMapping(Foo="Bar\\Baz") 1 CheckParseTorReplyMapping(Foo="Bar\nBaz\t" Spam="\rEggs" Octals="\1a\11\17\18\81\377\378\400\2222" Final=Check) 1 CheckParseTorReplyMapping(Valid=Mapping Escaped="Escape\\") 1 CheckParseTorReplyMapping(Valid=Mapping Bare="Escape\") 1 CheckParseTorReplyMapping(OneOctal="OneEnd\1" TwoOctal="TwoEnd\11") 1 CheckParseTorReplyMapping(Null="\0") 1 CheckParseTorReplyMapping(SOME=args,here MORE optional=arguments here) 1 CheckParseTorReplyMapping(ARGS) 1 CheckParseTorReplyMapping(MORE ARGS) 1 CheckParseTorReplyMapping(MORE ARGS) 1 CheckParseTorReplyMapping(EVEN more=ARGS) 1 CheckParseTorReplyMapping(EVEN+more ARGS) 1 Test case util_tests/util_criticalsection did not check any assertions 1 Testing known outcomes 326 Error: Specified -walletdir "/tmp/test_bitcoin/1553850209_943311758/tempdir/path_does_not_exist" does not exist 327 Error: Specified -walletdir "/tmp/test_bitcoin/1553850209_643733972/tempdir/not_a_directory.dat" is not a directory 328 Error: Specified -walletdir "wallets" is a relative path 1 1 *** No errors detected ``` After: ``` $ src/test/test_bitcoin --log_level=test_suite 2>&1 | grep -vE '(Entering|Leaving)' | uniq -c 1 Running 341 test cases... 1 Error: Specified -walletdir "/tmp/test_bitcoin/1553850026_943311758/tempdir/path_does_not_exist" does not exist 1 Error: Specified -walletdir "/tmp/test_bitcoin/1553850026_643733972/tempdir/not_a_directory.dat" is not a directory 1 Error: Specified -walletdir "wallets" is a relative path 1 1 *** No errors detected ``` ACKs for commit 0aef39: MarcoFalke: utACK 0aef39d Tree-SHA512: 9cc22f64aa5c875861bae6533d18675ad978c623f053754deef6a8e271ea70bda3f72fb4ec5c8fd19b841757f21380639051d5f5b44301b9d2464b57655e9c05

@baz

0aef39d Silence "Test case [...] did not check any assertions" warnings when running "test_bitcoin --log_level=test_suite" (practicalswift) 5fd73c8 Avoid repeated log messages in tests by connecting to signal handlers (ThreadSafeMessageBox, etc.) only once (practicalswift) e502c3c tests: Reduce noise level in test_bitcoin output (practicalswift) Pull request description: Reduce noise level in `test_bitcoin` output. Context: When working on the non-determinism issues in the unit tests (see bitcoin#15296) I got a bit tired of the amount of noise in the `test_bitcoin` output :-) Before: ``` $ src/test/test_bitcoin --log_level=test_suite 2>&1 | grep -vE '(Entering|Leaving)' | uniq -c 1 Running 341 test cases... 1 Test case blockencodings_tests/TransactionsRequestDeserializationOverflowTest did not check any assertions 1 CheckSplitTorReplyLine(PROTOCOLINFO PIVERSION) 1 CheckSplitTorReplyLine(AUTH METHODS=COOKIE,SAFECOOKIE COOKIEFILE="/home/x/.tor/control_auth_cookie") 1 CheckSplitTorReplyLine(AUTH METHODS=NULL) 1 CheckSplitTorReplyLine(AUTH METHODS=HASHEDPASSWORD) 1 CheckSplitTorReplyLine(VERSION Tor="0.2.9.8 (git-a0df013ea241b026)") 1 CheckSplitTorReplyLine(AUTHCHALLENGE SERVERHASH=aaaa SERVERNONCE=bbbb) 1 CheckSplitTorReplyLine(COMMAND) 1 CheckSplitTorReplyLine(COMMAND SOME ARGS) 1 CheckSplitTorReplyLine(COMMAND ARGS) 1 CheckSplitTorReplyLine(COMMAND EVEN+more ARGS) 1 CheckParseTorReplyMapping(METHODS=COOKIE,SAFECOOKIE COOKIEFILE="/home/x/.tor/control_auth_cookie") 1 CheckParseTorReplyMapping(METHODS=NULL) 1 CheckParseTorReplyMapping(METHODS=HASHEDPASSWORD) 1 CheckParseTorReplyMapping(Tor="0.2.9.8 (git-a0df013ea241b026)") 1 CheckParseTorReplyMapping(SERVERHASH=aaaa SERVERNONCE=bbbb) 1 CheckParseTorReplyMapping(ServiceID=exampleonion1234) 1 CheckParseTorReplyMapping(PrivateKey=RSA1024:BLOB) 1 CheckParseTorReplyMapping(ClientAuth=bob:BLOB) 1 CheckParseTorReplyMapping(Foo=Bar=Baz Spam=Eggs) 1 CheckParseTorReplyMapping(Foo="Bar=Baz") 1 CheckParseTorReplyMapping(Foo="Bar Baz") 1 CheckParseTorReplyMapping(Foo="Bar\ Baz") 1 CheckParseTorReplyMapping(Foo="Bar\Baz") 1 CheckParseTorReplyMapping(Foo="Bar\@baz") 1 CheckParseTorReplyMapping(Foo="Bar\"Baz" Spam="\"Eggs\"") 1 CheckParseTorReplyMapping(Foo="Bar\\Baz") 1 CheckParseTorReplyMapping(Foo="Bar\nBaz\t" Spam="\rEggs" Octals="\1a\11\17\18\81\377\378\400\2222" Final=Check) 1 CheckParseTorReplyMapping(Valid=Mapping Escaped="Escape\\") 1 CheckParseTorReplyMapping(Valid=Mapping Bare="Escape\") 1 CheckParseTorReplyMapping(OneOctal="OneEnd\1" TwoOctal="TwoEnd\11") 1 CheckParseTorReplyMapping(Null="\0") 1 CheckParseTorReplyMapping(SOME=args,here MORE optional=arguments here) 1 CheckParseTorReplyMapping(ARGS) 1 CheckParseTorReplyMapping(MORE ARGS) 1 CheckParseTorReplyMapping(MORE ARGS) 1 CheckParseTorReplyMapping(EVEN more=ARGS) 1 CheckParseTorReplyMapping(EVEN+more ARGS) 1 Test case util_tests/util_criticalsection did not check any assertions 1 Testing known outcomes 326 Error: Specified -walletdir "/tmp/test_bitcoin/1553850209_943311758/tempdir/path_does_not_exist" does not exist 327 Error: Specified -walletdir "/tmp/test_bitcoin/1553850209_643733972/tempdir/not_a_directory.dat" is not a directory 328 Error: Specified -walletdir "wallets" is a relative path 1 1 *** No errors detected ``` After: ``` $ src/test/test_bitcoin --log_level=test_suite 2>&1 | grep -vE '(Entering|Leaving)' | uniq -c 1 Running 341 test cases... 1 Error: Specified -walletdir "/tmp/test_bitcoin/1553850026_943311758/tempdir/path_does_not_exist" does not exist 1 Error: Specified -walletdir "/tmp/test_bitcoin/1553850026_643733972/tempdir/not_a_directory.dat" is not a directory 1 Error: Specified -walletdir "wallets" is a relative path 1 1 *** No errors detected ``` ACKs for commit 0aef39: MarcoFalke: utACK 0aef39d Tree-SHA512: 9cc22f64aa5c875861bae6533d18675ad978c623f053754deef6a8e271ea70bda3f72fb4ec5c8fd19b841757f21380639051d5f5b44301b9d2464b57655e9c05

fanquake added the Tests label Feb 6, 2019

practicalswift force-pushed the test_bitcoin-output-spam branch from 0bf958a to b84d2be Compare February 6, 2019 10:08

laanwj reviewed Feb 12, 2019

View reviewed changes

src/noui.cpp Outdated Show resolved Hide resolved

practicalswift force-pushed the test_bitcoin-output-spam branch from b84d2be to 2cc0e9f Compare March 27, 2019 14:57

maflcko reviewed Mar 27, 2019

View reviewed changes

src/noui.h Outdated Show resolved Hide resolved

practicalswift force-pushed the test_bitcoin-output-spam branch from 2cc0e9f to 3a22955 Compare March 27, 2019 16:38

maflcko reviewed Mar 27, 2019

View reviewed changes

src/test/test_bitcoin.cpp Outdated Show resolved Hide resolved

practicalswift force-pushed the test_bitcoin-output-spam branch 2 times, most recently from 309c45e to e558977 Compare March 27, 2019 19:55

maflcko reviewed Mar 27, 2019

View reviewed changes

src/test/blockencodings_tests.cpp Outdated Show resolved Hide resolved

src/test/util_tests.cpp Outdated Show resolved Hide resolved

practicalswift force-pushed the test_bitcoin-output-spam branch from e558977 to 9ca97d8 Compare March 27, 2019 22:35

maflcko reviewed Mar 28, 2019

View reviewed changes

src/test/test_bitcoin.cpp Outdated Show resolved Hide resolved

practicalswift force-pushed the test_bitcoin-output-spam branch from 9ca97d8 to f6701be Compare March 29, 2019 09:06

practicalswift added 2 commits March 29, 2019 15:14

tests: Reduce noise level in test_bitcoin output

e502c3c

Avoid repeated log messages in tests by connecting to signal handlers…

5fd73c8

… (ThreadSafeMessageBox, etc.) only once

practicalswift force-pushed the test_bitcoin-output-spam branch 2 times, most recently from 0274d8f to 3e6ac5c Compare March 29, 2019 14:30

Silence "Test case [...] did not check any assertions" warnings when …

0aef39d

…running "test_bitcoin --log_level=test_suite"

practicalswift force-pushed the test_bitcoin-output-spam branch from 3e6ac5c to 0aef39d Compare March 29, 2019 14:31

DrahtBot added the Needs rebase label Apr 16, 2019

maflcko merged commit 0aef39d into bitcoin:master Apr 16, 2019

practicalswift mentioned this pull request Apr 17, 2019

Add more property based tests for basic bitcoin data structures #14430

Closed

practicalswift mentioned this pull request May 3, 2019

Path error messages while executing test_bitcoin #15944

Closed

laanwj removed the Needs rebase label Oct 24, 2019

practicalswift mentioned this pull request Nov 4, 2019

test: Reset global args between test suites #17366

Merged

practicalswift deleted the test_bitcoin-output-spam branch April 10, 2021 19:38

PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Oct 12, 2021

partial bitcoin#15352: Reduce noise level in test_bitcoin output

a68f062

pravblockc pushed a commit to pravblockc/dash that referenced this pull request Nov 18, 2021

partial bitcoin#15352: Reduce noise level in test_bitcoin output

2fb06fd

bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

tests: Reduce noise level in test_bitcoin output #15352

tests: Reduce noise level in test_bitcoin output #15352

Uh oh!

practicalswift commented Feb 6, 2019 •

edited

Loading

Uh oh!

promag commented Feb 6, 2019 •

edited

Loading

Uh oh!

Uh oh!

practicalswift commented Mar 27, 2019

Uh oh!

Uh oh!

Uh oh!

maflcko left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

practicalswift commented Mar 29, 2019 •

edited

Loading

Uh oh!

maflcko commented Mar 29, 2019

Uh oh!

DrahtBot commented Apr 16, 2019

Uh oh!

maflcko commented Apr 16, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tests: Reduce noise level in test_bitcoin output #15352

tests: Reduce noise level in test_bitcoin output #15352

Uh oh!

Conversation

practicalswift commented Feb 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

promag commented Feb 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

practicalswift commented Mar 27, 2019

Uh oh!

Uh oh!

Uh oh!

maflcko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

practicalswift commented Mar 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maflcko commented Mar 29, 2019

Uh oh!

DrahtBot commented Apr 16, 2019

Uh oh!

maflcko commented Apr 16, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

practicalswift commented Feb 6, 2019 •

edited

Loading

promag commented Feb 6, 2019 •

edited

Loading

practicalswift commented Mar 29, 2019 •

edited

Loading