Fix InitError() and InitWarning() content #15329

hebasto · 2019-02-02T21:14:17Z

Currently, related to wallets and wrong command-line/config option values InitError() and InitWarning() contents are translated partially: some are translated, others are not.

This PR make translations of all such messages which are meaningful for a user/translator.

Also this PR prevents command-line/config option names from translation in InitError() and InitWarning() calls (that is not the case in master).

maflcko · 2019-02-02T21:17:56Z

I'd say some of the errors are exceptions that rarely happen and shouldn't be translated

hebasto · 2019-02-02T21:45:46Z

@MarcoFalke added rationale, removed [WIP]

laanwj · 2019-02-02T21:51:25Z

I'd say some of the errors are exceptions that rarely happen and shouldn't be translated

I agree. There's also the problem, especially with extremely rare error messages (such as the secp256k1 failure) that translating them makes them impossible to google. This doesn't really weigh up to the advantage of translating the message if it's very technical in the first place, so translating won't help the user understand it. It also requires the translator to understand which may not be reasonable.

So I'm not convinced this is a good thing.

hebasto · 2019-02-02T21:54:22Z

@laanwj

There's also the problem, especially with extremely rare error messages (such as the secp256k1 failure) that translating them makes them impossible to google.

Agree. Should 128148775ee465047c2a9c0e2a92277981b1a4b7 commit be removed completely or InitSanityCheck()-related part only?

laanwj · 2019-02-02T21:58:09Z

I'd say yes.
(coincidentally, too late for this for 0.18, translation string freeze was February 1)

hebasto · 2019-02-02T22:05:14Z

@laanwj

(coincidentally, too late for this for 0.18, translation string freeze was February 1)

I know it from the last IRC meeting. 0.18 is not the target for this PR :)

DrahtBot · 2019-02-02T22:33:50Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#16127 (Add support for thread safety annotations when using std::mutex by ajtowns)
#16112 (util: Log early messages by MarcoFalke)
#15946 (Allow maintaining the blockfilterindex when using prune by jonasschnelli)
#15891 (test: Require standard txs in regtest by default by MarcoFalke)
#15606 ([experimental] UTXO snapshots by jamesob)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

hebasto · 2019-02-02T23:06:13Z

Ref: IRC discussion

hebasto · 2019-02-02T23:59:54Z

I'd say some of the errors are exceptions that rarely happen and shouldn't be translated

Removed translations of error messages inside InitSanityCheck().
PR description updated.

hebasto · 2019-02-03T12:33:02Z

Translation Strings Policy:

Anything that appears to the user in the GUI is to be translated. This includes labels, menu items, button texts, tooltips and window titles. This includes messages passed to the GUI through the UI interface through InitMessage, ThreadSafeMessageBox or ShowProgress.

hebasto · 2019-02-03T12:39:57Z

Ref: comment by @laanwj:

I think errors relating directly to user options should be kept translated.

hebasto · 2019-03-09T17:24:58Z

Rebased.

hebasto · 2019-04-23T19:39:49Z

Rebased.

PastaPastaPasta · 2019-06-06T02:46:08Z

src/init.cpp

            enum Network net = ParseNetwork(snet);
            if (net == NET_UNROUTABLE)
-                return InitError(strprintf(_("Unknown network specified in -onlynet: '%s'"), snet));
+                return InitError(strprintf(_("Unknown network specified in %s: '%s'"), "-onlynet", snet));


bodies of an if statement should be on the same line or in brackets, imo this could be fixed in this PR

PastaPastaPasta · 2019-06-06T02:46:29Z

src/init.cpp

            proxyType addrOnion = proxyType(onionProxy, proxyRandomize);
            if (!addrOnion.IsValid())
-                return InitError(strprintf(_("Invalid -onion address or hostname: '%s'"), onionArg));
+                return InitError(strprintf(_("Invalid %s address or hostname: '%s'"), "-onion", onionArg));


same as above, same line or brackets

PastaPastaPasta · 2019-06-06T02:46:44Z

src/init.cpp

        LookupSubNet(net.c_str(), subnet);
        if (!subnet.IsValid())
-            return InitError(strprintf(_("Invalid netmask specified in -whitelist: '%s'"), net));
+            return InitError(strprintf(_("Invalid netmask specified in %s: '%s'"), "-whitelist", net));


same as above, same line or brackets

PastaPastaPasta · 2019-06-06T02:47:05Z

src/wallet/init.cpp


    if (gArgs.GetBoolArg("-sysperms", false))
-        return InitError("-sysperms is not allowed in combination with enabled wallet functionality");
+        return InitError(strprintf(_("%s is not allowed in combination with enabled wallet functionality"), "-sysperms"));


same line or brackets

PastaPastaPasta · 2019-06-06T02:47:08Z

src/wallet/init.cpp

+        return InitError(strprintf(_("%s is not allowed in combination with enabled wallet functionality"), "-sysperms"));
    if (gArgs.GetArg("-prune", 0) && gArgs.GetBoolArg("-rescan", false))
-        return InitError(_("Rescans are not possible in pruned mode. You will need to use -reindex which will download the whole blockchain again."));
+        return InitError(strprintf(_("Rescans are not possible in pruned mode. You will need to use %s which will download the whole blockchain again."), "-reindex"));


same line or brackets

maflcko · 2019-06-14T19:38:47Z

src/init.cpp


    if (!SetupNetworking())
-        return InitError("Initializing networking failed");
+        return InitError(_("Initializing networking failed"));


Tend to NACK. This will put the translated message into the debug log

I guess the translation should be registered here only and then later translated in InitError with _()

hebasto · 2019-06-15T06:04:48Z

@MarcoFalke

Tend to NACK. This will put the translated message into the debug log

I guess the translation should be registered here only and then later translated in InitError with _()

Agree. There was a dedicated PR #15340.

So, closing this PR now.

init: nMaxConnections and (nFD-nFDMin) cannot be negative, don't check against 0 init: try to fix Travis note about deducing types init: try to fix travis again "deduced conflicting types" init: try a better way through the Travis problem init: revert old init warning for drahtbot net: name nit "NUM"->"MAX"_FEELER_CONNCTIONS init: name nit "NUM"->"MAX"_FEELER_CONNCTIONS init: fixup typo

hebasto changed the title ~~[WIP] Fix InitError() and InitWarning() content~~ Fix InitError() and InitWarning() content Feb 2, 2019

maflcko added this to the 0.19.0 milestone Feb 2, 2019

hebasto changed the title ~~Fix InitError() and InitWarning() content~~ [WIP] Fix InitError() and InitWarning() content Feb 2, 2019

hebasto force-pushed the 20190202-initerror branch from fbf9caa to 7eb863e Compare February 2, 2019 23:00

hebasto force-pushed the 20190202-initerror branch from 7eb863e to a224845 Compare February 2, 2019 23:55

hebasto changed the title ~~[WIP] Fix InitError() and InitWarning() content~~ Fix InitError() and InitWarning() content Feb 2, 2019

DrahtBot added the Needs rebase label Feb 4, 2019

hebasto force-pushed the 20190202-initerror branch from a224845 to 5724c08 Compare February 17, 2019 17:50

DrahtBot removed the Needs rebase label Feb 17, 2019

DrahtBot added the Needs rebase label Mar 4, 2019

hebasto force-pushed the 20190202-initerror branch from 5724c08 to 2c7c01a Compare March 9, 2019 17:22

DrahtBot removed the Needs rebase label Mar 9, 2019

DrahtBot added Wallet Needs rebase labels Mar 19, 2019

hebasto added 2 commits April 23, 2019 21:51

Translate appropriate InitError() content

fa24aff

Never translate option names

71fcc30

hebasto force-pushed the 20190202-initerror branch from 2c7c01a to 71fcc30 Compare April 23, 2019 19:00

DrahtBot removed the Needs rebase label Apr 23, 2019

PastaPastaPasta suggested changes Jun 6, 2019

View reviewed changes

maflcko reviewed Jun 14, 2019

View reviewed changes

hebasto closed this Jun 15, 2019

hebasto deleted the 20190202-initerror branch June 13, 2020 12:57

bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022

Fix InitError() and InitWarning() content #15329

Fix InitError() and InitWarning() content #15329

Uh oh!

Conversation

hebasto commented Feb 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maflcko commented Feb 2, 2019

Uh oh!

hebasto commented Feb 2, 2019

Uh oh!

laanwj commented Feb 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hebasto commented Feb 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laanwj commented Feb 2, 2019

Uh oh!

hebasto commented Feb 2, 2019

Uh oh!

DrahtBot commented Feb 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

hebasto commented Feb 2, 2019

Uh oh!

hebasto commented Feb 2, 2019

Uh oh!

hebasto commented Feb 3, 2019

Uh oh!

hebasto commented Feb 3, 2019

Uh oh!

hebasto commented Mar 9, 2019

Uh oh!

hebasto commented Apr 23, 2019

Uh oh!

PastaPastaPasta Jun 6, 2019

Choose a reason for hiding this comment

Uh oh!

PastaPastaPasta Jun 6, 2019

Choose a reason for hiding this comment

Uh oh!

PastaPastaPasta Jun 6, 2019

Choose a reason for hiding this comment

Uh oh!

PastaPastaPasta Jun 6, 2019

Choose a reason for hiding this comment

Uh oh!

PastaPastaPasta Jun 6, 2019

Choose a reason for hiding this comment

Uh oh!

maflcko Jun 14, 2019

Choose a reason for hiding this comment

Uh oh!

maflcko Jun 14, 2019

Choose a reason for hiding this comment

Uh oh!

hebasto commented Jun 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hebasto commented Feb 2, 2019 •

edited

Loading

laanwj commented Feb 2, 2019 •

edited

Loading

hebasto commented Feb 2, 2019 •

edited

Loading

DrahtBot commented Feb 2, 2019 •

edited

Loading