doc: Add cs_main lock annotations for mapBlockIndex #15321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Concept ACK Thanks for adding this missing annotation. |
maflcko
force-pushed
the
Mf1902-docLoc
branch
2 times, most recently
from
fa5349e to
fa36350
Compare
maflcko
force-pushed
the
Mf1902-docLoc
branch
from
fa36350 to
fa2a69f
Compare
promag
reviewed
Feb 2, 2019
| * Mark one block file as pruned. | ||
| */ | ||
| void PruneOneBlockFile(const int fileNumber); | ||
| void PruneOneBlockFile(const int fileNumber) EXCLUSIVE_LOCKS_REQUIRED(cs_main); |
Contributor
There was a problem hiding this comment.
Without it I get:
CXX wallet/libbitcoin_wallet_a-wallet.o
validation.cpp:3623:28: warning: reading variable 'mapBlockIndex' requires holding mutex 'cs_main' [-Wthread-safety-analysis]
for (const auto& entry : mapBlockIndex) {
^
validation.cpp:3623:28: warning: reading variable 'mapBlockIndex' requires holding mutex 'cs_main' [-Wthread-safety-analysis]
CXX wallet/libbitcoin_wallet_a-walletdb.o
Contributor
|
utACK fa2a69f |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Feb 6, 2019
fa2a69f doc: Add cs_main lock annotations for mapBlockIndex (practicalswift) Pull request description: Marked as "doc" because it didn't change the bitcoind on my system with default configure settings for both gcc and clang. Tree-SHA512: ba203f16c1cdc834a61c65bb5fb20bbaf7d8bff0c3a1b8ef46bc1d3669092191221e26abd7e580efab2f9bd5a992dc363251f1b68c6cd68f8204d62675868cf1
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Mar 26, 2020
Summary: ``` Previously the argument would be untouched if the first block scan failed. This makes the behavior predictable, and consistent with the documentation. ``` Backport of core [[bitcoin/bitcoin#14957 | PR14957]] and the remaining of [[bitcoin/bitcoin#15321 | PR15321]] (see D5238). Depends on D5563. Test Plan: With Clang: cmake -GNinja .. -DCMAKE_BUILD_TYPE=Debug -DENABLE_WERROR=ON ninja all check check-functional Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5564
LarryRuane
pushed a commit
to LarryRuane/zcash
that referenced
this pull request
Apr 29, 2021
zcash: cherry picked from commit fa2a69f zcash: bitcoin/bitcoin#15321
LarryRuane
pushed a commit
to LarryRuane/zcash
that referenced
this pull request
Jun 1, 2021
zcash: cherry picked from commit fa2a69f zcash: bitcoin/bitcoin#15321
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked as "doc" because it didn't change the bitcoind on my system with default configure settings for both gcc and clang.