tests: When testing with --usecli, unify RPC arg to cli arg conversion and handle dicts and lists #15301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 31, 2019
Member
|
tACK 2c847e8, Travis permitting |
Member
|
Nice ! Thank you for doing this. utACK 2c847e8c10ccf06d6deb8650ee2f31204599fc0e |
Member
|
The problem goes away when I rebase on master, which includes #15246. I assume merging will have the same effect. |
Member
|
@Sjors I am pretty sure this is an intermittent problem specific to macos and unrelated to any pull request. |
achow101
force-pushed
the
fix-tests-cli-args
branch
from
2c847e8 to
2e02341
Compare
… and lists When running tests with --usecli, unify the conversion from argument objects to strings using a new function arg_to_cli(). This fixes boolean arguments when using named arguments. Also use json.dumps() to get the string values for arguments that are dicts and lists so that bitcoind's JSON parser does not become confused.
Member
Author
|
@Sjors I've rebased it but I'm not sure that will matter. This was built on top of the latest master from a couple of hours ago. |
Member
|
tACK 2e02341 Weirdly enough it's spitting out that |
Contributor
|
utACK 2e02341 |
maflcko
pushed a commit
that referenced
this pull request
Jan 31, 2019
… arg conversion and handle dicts and lists 2e02341 tests: unify RPC argument to cli argument conversion and handle dicts and lists (Andrew Chow) Pull request description: When running tests with --usecli, unify the conversion from argument objects to strings using a new function arg_to_cli(). This fixes boolean arguments when using named arguments. Also use json.dumps() to get the string values for arguments that are dicts and lists so that bitcoind's JSON parser does not become confused. Tree-SHA512: 472bef3cd78410a8552fd342b1852bcd7c57721cfa9176b26bacda6b0791cc0b3758561a529c4117a7428242f98bb7d5482b2a2dcd06bea0ef2b15ae26183405
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running tests with --usecli, unify the conversion from argument objects to strings using a new function arg_to_cli(). This fixes boolean arguments when using named arguments.
Also use json.dumps() to get the string values for arguments that are dicts and lists so that bitcoind's JSON parser does not become confused.