travis: Compile once on trusty #15276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
force-pushed
the
Mf1901-travisTrusty
branch
2 times, most recently
from
fafbf51 to
faabd19
Compare
Contributor
|
See also #14998, which I haven't gotten green |
maflcko
force-pushed
the
Mf1901-travisTrusty
branch
from
faabd19 to
fa0b86e
Compare
Member
Author
|
Jup, thanks for working on this. Though, it seems your code-changes haven't seen much review, so I try to make a minimal test-only addition to get this in asap. |
maflcko
force-pushed
the
Mf1901-travisTrusty
branch
from
fa0b86e to
fa5ce3f
Compare
Contributor
|
utACK fa5ce3f could squash |
Member
Author
|
I'd prefer if the top commit was reverted in the future, so having it separate helps in that regard. |
Contributor
|
utACK fa5ce3f |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Jan 30, 2019
fa5ce3f travis: Compile trusty with depends for now (MarcoFalke) fa83999 travis: Compile once on trusty (MarcoFalke) Pull request description: To avoid accidentally regressing again on bitcoin#15172, we should compile at least once with gcc4.8 (the minimum required version) Note that this uses the trusty image, which will be removed in a few months from the docker hub, so in the future it had to be switched to the centos7 (or similar) image, which should come with gcc4.8 as well. Tree-SHA512: 9d1704464bde8dbaf3319ac35f72d32dce549818730d3b2fb63df817f84a88dd64aa3419b97a57c1120ffb254784503b7d2675b1291d4ed073cd2a2488aa717d
maflcko
pushed a commit
that referenced
this pull request
Feb 1, 2019
119d360 travis: Document whether functional tests are run in the job name (Ben Woosley) 64f2854 Revert "travis: Compile trusty with depends for now" (Ben Woosley) 267eac0 Prefer boost::optional#get_value_or over #value_or (Ben Woosley) 1971f5b Piecewise construct to avoid invalid construction (Ben Woosley) Pull request description: In light of #14979, I realized that only qt 5.5+ was being tested under CI, while compatibility lists 5.2+. In #15276, Marco added Trusty to CI, building with depends. This changes that build to system libraries, in order to ensure ongoing compatibility with our claimed minimum required versions. Fixes #14983, previously open as #14998 Tree-SHA512: 6cff5e28c756ecb8bf797c8f6eb77c1944ba61a8dd6d7d4984e63eef384f6429dc79c505da3241c05b9c4db31c72b2a9846c7365aba9280f2e0620e5f3998d07
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Aug 24, 2021
fa5ce3f travis: Compile trusty with depends for now (MarcoFalke) fa83999 travis: Compile once on trusty (MarcoFalke) Pull request description: To avoid accidentally regressing again on bitcoin#15172, we should compile at least once with gcc4.8 (the minimum required version) Note that this uses the trusty image, which will be removed in a few months from the docker hub, so in the future it had to be switched to the centos7 (or similar) image, which should come with gcc4.8 as well. Tree-SHA512: 9d1704464bde8dbaf3319ac35f72d32dce549818730d3b2fb63df817f84a88dd64aa3419b97a57c1120ffb254784503b7d2675b1291d4ed073cd2a2488aa717d
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Aug 24, 2021
fa5ce3f travis: Compile trusty with depends for now (MarcoFalke) fa83999 travis: Compile once on trusty (MarcoFalke) Pull request description: To avoid accidentally regressing again on bitcoin#15172, we should compile at least once with gcc4.8 (the minimum required version) Note that this uses the trusty image, which will be removed in a few months from the docker hub, so in the future it had to be switched to the centos7 (or similar) image, which should come with gcc4.8 as well. Tree-SHA512: 9d1704464bde8dbaf3319ac35f72d32dce549818730d3b2fb63df817f84a88dd64aa3419b97a57c1120ffb254784503b7d2675b1291d4ed073cd2a2488aa717d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid accidentally regressing again on #15172, we should compile at least once with gcc4.8 (the minimum required version)
Note that this uses the trusty image, which will be removed in a few months from the docker hub, so in the future it had to be switched to the centos7 (or similar) image, which should come with gcc4.8 as well.