[tests] Remove travis_wait from lint script #15255
Conversation
|
Concept ACK I've seen this as well |
gkrizek
force-pushed
the
remove-travis_wait
branch
from
6d248b0 to
e8d2b2d
Compare
|
|
|
@Empact Looking at that PR, it seems like that logic was only added to Also, looking at the |
|
Concept ACK |
Also adding progress logging to verify-commits.py script to prevent Travis from timing out
gkrizek
force-pushed
the
remove-travis_wait
branch
from
e8d2b2d to
8b8d8ee
Compare
|
This is updated with @MarcoFalke 's suggestion. This will now detect if the script is running in CI and if it is log level is set to debug. Then it will log every commit that's inspected to prevent Travis from timing out. |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
utACK 8b8d8ee |
8b8d8ee Remove travis_wait from lint script (Graham Krizek) Pull request description: Using the `travis_wait` command in conjunction with `set -o errexit` causes problems. The `travis_wait` command will correctly log the command's output if successful, but if the command fails the process exits before the `travis_wait` command can dump the logs. This will hide important debugging information like error messages and stack traces. We ran into this in bitcoin#15196 and it was very hard to debug because output was being suppressed. `travis_wait` was being used because the `contrib/verify-commits/verify-commits.py` script can sometimes run for a long time without producing any output. If a script runs for 10 minutes without logging anything, the CI run times out. The `travis_wait` command will extend this timeout by logging a message for you, while sending stderr and stdout to a file. This PR removes the `travis_wait` command from our CI system and adds additional logging to the `verify-commits.py` script so it doesn't make Travis timeout. ACKs for commit 8b8d8e: MarcoFalke: utACK 8b8d8ee Tree-SHA512: 175a8dd3f4d4e03ab272ddba94fa8bb06875c9027c3f3f81577feda4bc8918b5f0e003a19027f04f8cf2d0b56c68633716a6ab23f95b910121a8d1132428767d
8b8d8ee Remove travis_wait from lint script (Graham Krizek) Pull request description: Using the `travis_wait` command in conjunction with `set -o errexit` causes problems. The `travis_wait` command will correctly log the command's output if successful, but if the command fails the process exits before the `travis_wait` command can dump the logs. This will hide important debugging information like error messages and stack traces. We ran into this in bitcoin#15196 and it was very hard to debug because output was being suppressed. `travis_wait` was being used because the `contrib/verify-commits/verify-commits.py` script can sometimes run for a long time without producing any output. If a script runs for 10 minutes without logging anything, the CI run times out. The `travis_wait` command will extend this timeout by logging a message for you, while sending stderr and stdout to a file. This PR removes the `travis_wait` command from our CI system and adds additional logging to the `verify-commits.py` script so it doesn't make Travis timeout. ACKs for commit 8b8d8e: MarcoFalke: utACK 8b8d8ee Tree-SHA512: 175a8dd3f4d4e03ab272ddba94fa8bb06875c9027c3f3f81577feda4bc8918b5f0e003a19027f04f8cf2d0b56c68633716a6ab23f95b910121a8d1132428767d
5 participants
Using the
travis_waitcommand in conjunction withset -o errexitcauses problems. Thetravis_waitcommand will correctly log the command's output if successful, but if the command fails the process exits before thetravis_waitcommand can dump the logs. This will hide important debugging information like error messages and stack traces. We ran into this in #15196 and it was very hard to debug because output was being suppressed.travis_waitwas being used because thecontrib/verify-commits/verify-commits.pyscript can sometimes run for a long time without producing any output. If a script runs for 10 minutes without logging anything, the CI run times out. Thetravis_waitcommand will extend this timeout by logging a message for you, while sending stderr and stdout to a file.This PR removes the
travis_waitcommand from our CI system and adds additional logging to theverify-commits.pyscript so it doesn't make Travis timeout.