qa: Use wallet to retrieve raw transactions #15247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
force-pushed
the
Mf1901-qaWalletRaw
branch
from
fa258ea to
fac7311
Compare
Contributor
|
I think it's good to improve code style in files that you touch, but could you split this into commits:
doing both in a single commit makes is discouraged: do not mix any formatting fixes or code moves with actual code changes. |
maflcko
force-pushed
the
Mf1901-qaWalletRaw
branch
from
fac7311 to
fa2320a
Compare
jnewbery
reviewed
Jan 25, 2019
Contributor
jnewbery
left a comment
jnewbery
left a comment
There was a problem hiding this comment.
Tested ACK fa2320a3f0374045414ec5dc2fecae76224a1afe. One nit.
maflcko
force-pushed
the
Mf1901-qaWalletRaw
branch
from
fa2320a to
fa5278a
Compare
Contributor
|
tACK fa5278a. Thanks! |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Feb 1, 2019
fa5278a qa: Use wallet to retrieve raw transactions (MarcoFalke) fa21983 qa: Style-only fixes in touched files (MarcoFalke) Pull request description: Instead of asking the coin database and block storage about a transaction, pull it directly from the wallet in wallet related tests. This refactoring only makes sense in light of bitcoin#15159. <sub>This product may contain minor stylistic cleanups Tree-SHA512: ec34c7150d873da9f19fead3f7e3f758baba5ef10061942384c470a47a6f320690109be9c5160f0c8bc228272a729653d44c78471455337318f657d6c164ba23
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
May 16, 2020
Summary: Merge #15247: qa: Use wallet to retrieve raw transactions fa5278a419 qa: Use wallet to retrieve raw transactions (MarcoFalke) fa2198328e qa: Style-only fixes in touched files (MarcoFalke) Pull request description: Instead of asking the coin database and block storage about a transaction, pull it directly from th$ This refactoring only makes sense in light of #15159. <sub>This product may contain minor stylistic cleanups --- Depends on D6062 This is a backport of Core [[bitcoin/bitcoin#15247 | PR15247]] Test Plan: ./test_runner.py wallet_abandonconflict.py wallet_basic.py Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D6069
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Aug 17, 2021
fa5278a qa: Use wallet to retrieve raw transactions (MarcoFalke) fa21983 qa: Style-only fixes in touched files (MarcoFalke) Pull request description: Instead of asking the coin database and block storage about a transaction, pull it directly from the wallet in wallet related tests. This refactoring only makes sense in light of bitcoin#15159. <sub>This product may contain minor stylistic cleanups Tree-SHA512: ec34c7150d873da9f19fead3f7e3f758baba5ef10061942384c470a47a6f320690109be9c5160f0c8bc228272a729653d44c78471455337318f657d6c164ba23
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of asking the coin database and block storage about a transaction, pull it directly from the wallet in wallet related tests.
This refactoring only makes sense in light of #15159.
This product may contain minor stylistic cleanups