Skip to content

zmq: log outbound message high water mark when reusing socket #15209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
Jan 21, 2019
Merged

zmq: log outbound message high water mark when reusing socket #15209

laanwj merged 1 commit into from
Jan 21, 2019

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Jan 19, 2019 •
edited
Loading

Running master with src/bitcoind -zmqpubhashblockhwm=12345 -zmqpubrawtx=tcp://127.0.0.1:28332 -zmqpubhashtxhwm=5000 -zmqpubrawblock=tcp://127.0.0.1:28332 -zmqpubhashtx=tcp://127.0.0.1:28332 -zmqpubhashblock=tcp://127.0.0.1:28332 -debug=zmq:

2019-01-19T14:11:01Z zmq: version 4.3.1
2019-01-19T14:11:01Z zmq: Initialize notification interface
2019-01-19T14:11:01Z zmq: Outbound message high water mark for pubhashblock at tcp://127.0.0.1:28332 is 12345
2019-01-19T14:11:01Z zmq: Notifier pubhashblock ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:11:01Z zmq: Notifier pubhashtx ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:11:01Z zmq: Notifier pubrawblock ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:11:01Z zmq: Notifier pubrawtx ready (address = tcp://127.0.0.1:28332)

This PR:

2019-01-19T14:06:57Z zmq: version 4.3.1
2019-01-19T14:06:57Z zmq: Initialize notification interface
2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubhashblock at tcp://127.0.0.1:28332 is 12345
2019-01-19T14:06:57Z zmq: Notifier pubhashblock ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubhashtx at tcp://127.0.0.1:28332 is 5000
2019-01-19T14:06:57Z zmq: Notifier pubhashtx ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubrawblock at tcp://127.0.0.1:28332 is 1000
2019-01-19T14:06:57Z zmq: Notifier pubrawblock ready (address = tcp://127.0.0.1:28332)
2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubrawtx at tcp://127.0.0.1:28332 is 1000
2019-01-19T14:06:57Z zmq: Notifier pubrawtx ready (address = tcp://127.0.0.1:28332)

@molxyz
Copy link

molxyz commented Jan 19, 2019

@fanquake How do you get the zmq log? I'm trying to run this PR but I don't see the log for zmq in my debug.log.

@fanquake
Copy link
Member Author

fanquake commented Jan 20, 2019

@molxyz Run with -debug=zmq and you should see zmq related logs. I should have added that to the PR text.

@molxyz
Copy link

molxyz commented Jan 20, 2019 •
edited
Loading

@fanquake Thank you! I should have figured that. This is great.

2019-01-20T01:35:49Z zmq: version 4.2.5
2019-01-20T01:35:49Z zmq: Initialize notification interface
2019-01-20T01:35:49Z zmq: Outbound message high water mark for pubhashblock at tcp://127.0.0.1:28334 is 12345
2019-01-20T01:35:49Z zmq: Notifier pubhashblock ready (address = tcp://127.0.0.1:28334)
2019-01-20T01:35:49Z zmq: Outbound message high water mark for pubhashtx at tcp://127.0.0.1:28335 is 5000
2019-01-20T01:35:49Z zmq: Notifier pubhashtx ready (address = tcp://127.0.0.1:28335)
2019-01-20T01:35:49Z zmq: Outbound message high water mark for pubrawblock at tcp://127.0.0.1:28332 is 1000
2019-01-20T01:35:49Z zmq: Notifier pubrawblock ready (address = tcp://127.0.0.1:28332)
2019-01-20T01:35:49Z zmq: Outbound message high water mark for pubrawtx at tcp://127.0.0.1:28333 is 1000
2019-01-20T01:35:49Z zmq: Notifier pubrawtx ready (address = tcp://127.0.0.1:28333)

Edit: Changed one of the ports to be the same like the other:

2019-01-20T01:56:54Z zmq: version 4.2.5
2019-01-20T01:56:54Z zmq: Initialize notification interface
2019-01-20T01:56:54Z zmq: Outbound message high water mark for pubhashblock at tcp://127.0.0.1:28334 is 12345
2019-01-20T01:56:54Z zmq: Notifier pubhashblock ready (address = tcp://127.0.0.1:28334)
2019-01-20T01:56:54Z zmq: Reusing socket for address tcp://127.0.0.1:28334
2019-01-20T01:56:54Z zmq: Outbound message high water mark for pubhashtx at tcp://127.0.0.1:28334 is 5000
2019-01-20T01:56:54Z zmq: Notifier pubhashtx ready (address = tcp://127.0.0.1:28334)
2019-01-20T01:56:54Z zmq: Outbound message high water mark for pubrawblock at tcp://127.0.0.1:28332 is 1000
2019-01-20T01:56:54Z zmq: Notifier pubrawblock ready (address = tcp://127.0.0.1:28332)
2019-01-20T01:56:54Z zmq: Outbound message high water mark for pubrawtx at tcp://127.0.0.1:28333 is 1000
2019-01-20T01:56:54Z zmq: Notifier pubrawtx ready (address = tcp://127.0.0.1:28333)

@IlyasRidhuan
Copy link

IlyasRidhuan commented Jan 20, 2019 •
edited
Loading

tAck f1dc693

2019-01-20T13:22:25Z zmq: version 4.2.3
2019-01-20T13:22:25Z zmq: Initialize notification interface
2019-01-20T13:22:25Z zmq: Outbound message high water mark for pubhashblock at tcp://127.0.0.1:28332 is 12345
2019-01-20T13:22:25Z zmq: Notifier pubhashblock ready (address = tcp://127.0.0.1:28332)
2019-01-20T13:22:25Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-20T13:22:25Z zmq: Outbound message high water mark for pubhashtx at tcp://127.0.0.1:28332 is 5000
2019-01-20T13:22:25Z zmq: Notifier pubhashtx ready (address = tcp://127.0.0.1:28332)
2019-01-20T13:22:25Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-20T13:22:25Z zmq: Outbound message high water mark for pubrawblock at tcp://127.0.0.1:28332 is 1000
2019-01-20T13:22:25Z zmq: Notifier pubrawblock ready (address = tcp://127.0.0.1:28332)
2019-01-20T13:22:25Z zmq: Reusing socket for address tcp://127.0.0.1:28332
2019-01-20T13:22:25Z zmq: Outbound message high water mark for pubrawtx at tcp://127.0.0.1:28332 is 1000
2019-01-20T13:22:25Z zmq: Notifier pubrawtx ready (address = tcp://127.0.0.1:28332)

@laanwj
Copy link
Member

laanwj commented Jan 21, 2019

utACK f1dc693

@laanwj laanwj merged commit f1dc693 into bitcoin:master Jan 21, 2019
laanwj added a commit that referenced this pull request Jan 21, 2019
@laanwj
Merge #15209: zmq: log outbound message high water mark when reusing …
1522079 
…socket

f1dc693 zmq: log outbound message high water mark when reusing socket (fanquake)

Pull request description:

  Running master with `src/bitcoind -zmqpubhashblockhwm=12345 -zmqpubrawtx=tcp://127.0.0.1:28332 -zmqpubhashtxhwm=5000 -zmqpubrawblock=tcp://127.0.0.1:28332 -zmqpubhashtx=tcp://127.0.0.1:28332 -zmqpubhashblock=tcp://127.0.0.1:28332 -debug=zmq`:
  ```
  2019-01-19T14:11:01Z zmq: version 4.3.1
  2019-01-19T14:11:01Z zmq: Initialize notification interface
  2019-01-19T14:11:01Z zmq: Outbound message high water mark for pubhashblock at tcp://127.0.0.1:28332 is 12345
  2019-01-19T14:11:01Z zmq: Notifier pubhashblock ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:11:01Z zmq: Notifier pubhashtx ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:11:01Z zmq: Notifier pubrawblock ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:11:01Z zmq: Notifier pubrawtx ready (address = tcp://127.0.0.1:28332)
  ```

  This PR:
  ```
  2019-01-19T14:06:57Z zmq: version 4.3.1
  2019-01-19T14:06:57Z zmq: Initialize notification interface
  2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubhashblock at tcp://127.0.0.1:28332 is 12345
  2019-01-19T14:06:57Z zmq: Notifier pubhashblock ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubhashtx at tcp://127.0.0.1:28332 is 5000
  2019-01-19T14:06:57Z zmq: Notifier pubhashtx ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubrawblock at tcp://127.0.0.1:28332 is 1000
  2019-01-19T14:06:57Z zmq: Notifier pubrawblock ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubrawtx at tcp://127.0.0.1:28332 is 1000
  2019-01-19T14:06:57Z zmq: Notifier pubrawtx ready (address = tcp://127.0.0.1:28332)
  ```

Tree-SHA512: 6915184d8a0f4764f1cc76dce0099eed411a123d7a4bc8cee1664bb5a233a8119ddd2c78ad980c6e1d9f6dadaba48800ee6bc57de906d4e1b4108df745f1458e
@fanquake fanquake deleted the zmq-always-log-high-water-mark branch February 22, 2019 06:58
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Sep 3, 2020
@laanwj @majcosta
[backport#15209] zmq: log outbound message high water mark when reusi…
6ad4149 
…ng socket

Summary:
zmq: log outbound message high water mark when reusing socket (fanquake)

Pull request description:

  Running master with `src/bitcoind -zmqpubhashblockhwm=12345 -zmqpubrawtx=tcp://127.0.0.1:28332 -zmqpubhashtxhwm=5000 -zmqpubrawblock=tcp://127.0.0.1:28332 -zmqpubhashtx=tcp://127.0.0.1:28332 -zmqpubhashblock=tcp://127.0.0.1:28332 -debug=zmq`:
  ```
  2019-01-19T14:11:01Z zmq: version 4.3.1
  2019-01-19T14:11:01Z zmq: Initialize notification interface
  2019-01-19T14:11:01Z zmq: Outbound message high water mark for pubhashblock at tcp://127.0.0.1:28332 is 12345
  2019-01-19T14:11:01Z zmq: Notifier pubhashblock ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:11:01Z zmq: Notifier pubhashtx ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:11:01Z zmq: Notifier pubrawblock ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:11:01Z zmq: Notifier pubrawtx ready (address = tcp://127.0.0.1:28332)
  ```

  This PR:
  ```
  2019-01-19T14:06:57Z zmq: version 4.3.1
  2019-01-19T14:06:57Z zmq: Initialize notification interface
  2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubhashblock at tcp://127.0.0.1:28332 is 12345
  2019-01-19T14:06:57Z zmq: Notifier pubhashblock ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubhashtx at tcp://127.0.0.1:28332 is 5000
  2019-01-19T14:06:57Z zmq: Notifier pubhashtx ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubrawblock at tcp://127.0.0.1:28332 is 1000
  2019-01-19T14:06:57Z zmq: Notifier pubrawblock ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubrawtx at tcp://127.0.0.1:28332 is 1000
  2019-01-19T14:06:57Z zmq: Notifier pubrawtx ready (address = tcp://127.0.0.1:28332)
  ```

Backport of Core [[bitcoin/bitcoin#15209 | PR15209]]

Test Plan:
  ninja check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7338
dzutto pushed a commit to dzutto/dash that referenced this pull request Sep 9, 2021
@laanwj @dzutto
Merge bitcoin#15209: zmq: log outbound message high water mark when r…
d651489 
…eusing socket

f1dc693 zmq: log outbound message high water mark when reusing socket (fanquake)

Pull request description:

  Running master with `src/bitcoind -zmqpubhashblockhwm=12345 -zmqpubrawtx=tcp://127.0.0.1:28332 -zmqpubhashtxhwm=5000 -zmqpubrawblock=tcp://127.0.0.1:28332 -zmqpubhashtx=tcp://127.0.0.1:28332 -zmqpubhashblock=tcp://127.0.0.1:28332 -debug=zmq`:
  ```
  2019-01-19T14:11:01Z zmq: version 4.3.1
  2019-01-19T14:11:01Z zmq: Initialize notification interface
  2019-01-19T14:11:01Z zmq: Outbound message high water mark for pubhashblock at tcp://127.0.0.1:28332 is 12345
  2019-01-19T14:11:01Z zmq: Notifier pubhashblock ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:11:01Z zmq: Notifier pubhashtx ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:11:01Z zmq: Notifier pubrawblock ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:11:01Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:11:01Z zmq: Notifier pubrawtx ready (address = tcp://127.0.0.1:28332)
  ```

  This PR:
  ```
  2019-01-19T14:06:57Z zmq: version 4.3.1
  2019-01-19T14:06:57Z zmq: Initialize notification interface
  2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubhashblock at tcp://127.0.0.1:28332 is 12345
  2019-01-19T14:06:57Z zmq: Notifier pubhashblock ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubhashtx at tcp://127.0.0.1:28332 is 5000
  2019-01-19T14:06:57Z zmq: Notifier pubhashtx ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubrawblock at tcp://127.0.0.1:28332 is 1000
  2019-01-19T14:06:57Z zmq: Notifier pubrawblock ready (address = tcp://127.0.0.1:28332)
  2019-01-19T14:06:57Z zmq: Reusing socket for address tcp://127.0.0.1:28332
  2019-01-19T14:06:57Z zmq: Outbound message high water mark for pubrawtx at tcp://127.0.0.1:28332 is 1000
  2019-01-19T14:06:57Z zmq: Notifier pubrawtx ready (address = tcp://127.0.0.1:28332)
  ```

Tree-SHA512: 6915184d8a0f4764f1cc76dce0099eed411a123d7a4bc8cee1664bb5a233a8119ddd2c78ad980c6e1d9f6dadaba48800ee6bc57de906d4e1b4108df745f1458e
UdjinM6 added a commit to dashpay/dash that referenced this pull request Sep 9, 2021
@UdjinM6
Merge pull request #4404 from dzutte-cpp/backport_15188_15209
1dbf7b9 
Merge bitcoin bitcoin#15188, bitcoin#15209
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

RPC/REST/ZMQ Utils/log/libs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fanquake @molxyz @IlyasRidhuan @laanwj