Default -whitelistforcerelay to off #15193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
ping @gmaxwell |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
fanquake
changed the title
fanquake
changed the title
Member
|
Needs release note.
From what I vaguely remember bitonic.nl (Dutch exchange) uses, or at least used this. |
Contributor
|
Concept ACK. If we think there is still use we could add a FORCETX network message that is functionally identical to a TX message, but triggers the forced behaviour (and the user gets to live with the consequences) and is only permitted for WLed peers. I'm not aware of any continued dependency on this behaviour but we can check more. |
Member
|
utACK
Well this PR doesn't remove the functionality it only disables it by default, so IMO there is no requirement to provide an alternative here even if it is still used. Just need to be clear about it in the release notes (could even add a line to contact someone of us if they're still using this functionality) |
sdaftuar
force-pushed
the
2019-01-forcerelayoff
branch
from
d1de11a to
a36d97d
Compare
Member
Author
|
Updated with a release note. |
We use bitcoin nodes as relay, but since we don't want them to relay transactions that violate the standard rules, we don't use this feature as default. Edit: oh, just heard that we did for a while to mitigate an other problem that has since been resolved. |
Member
|
utACK a36d97d |
Contributor
|
utACK a36d97d, previous behavior is still possible. |
laanwj
added a commit
that referenced
this pull request
Jan 24, 2019
a36d97d Default -whitelistforcerelay to off (Suhas Daftuar) Pull request description: No one seems to use this "feature", and at any rate the behavior of relaying transactions when they violate local policy is error-prone, if we ever consider changing the ban behavior of our software from one version to the next. Defaulting this to off means that users who use -whitelist won't be unexpectedly surprised by this interaction. If anyone is still relying on this feature, it can still be explicitly turned on. Tree-SHA512: 52650ad464a728d1648f496751e3f713077ea3a1de7278ed03531b2e8723e63cf2f6f41b56c98c0f73ffa22c36e01d9170b409ab452c737aca35b7ecd7a6b448
harding
added a commit
to harding/bitcoin
that referenced
this pull request
Apr 25, 2019
Updates text since -whitelistforcerelay was set to false by default in PR bitcoin#15193.
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
May 8, 2019
…-whitelist e0bb279 Doc: remove text about txes always relayed from -whitelist (David A. Harding) Pull request description: Updates text since -whitelistforcerelay was set to false by default in PR bitcoin#15193. ACKs for commit e0bb27: fanquake: utACK e0bb279 MarcoFalke: utACK e0bb279 Tree-SHA512: cf0c9321d72692d573039a04f8f1d048cbdf67ed86cc781523dabd3c45d2731b788f53749e6bb29d7da1ab44eb04030f352469b20489bb2a26c2c38fb61f6489
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 10, 2019
…-whitelist e0bb279 Doc: remove text about txes always relayed from -whitelist (David A. Harding) Pull request description: Updates text since -whitelistforcerelay was set to false by default in PR bitcoin#15193. ACKs for commit e0bb27: fanquake: utACK e0bb279 MarcoFalke: utACK e0bb279 Tree-SHA512: cf0c9321d72692d573039a04f8f1d048cbdf67ed86cc781523dabd3c45d2731b788f53749e6bb29d7da1ab44eb04030f352469b20489bb2a26c2c38fb61f6489
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
May 17, 2019
Updates text since -whitelistforcerelay was set to false by default in PR bitcoin#15193. Github-Pull: bitcoin#15890 Rebased-From: e0bb279
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Aug 23, 2019
Updates text since -whitelistforcerelay was set to false by default in PR bitcoin#15193. Github-Pull: bitcoin#15890 Rebased-From: e0bb279
Bushstar
pushed a commit
to Bushstar/omnicore
that referenced
this pull request
Aug 24, 2019
Updates text since -whitelistforcerelay was set to false by default in PR bitcoin#15193. Github-Pull: bitcoin#15890 Rebased-From: e0bb279
mdfkbtc
pushed a commit
to mdfkbtc/veles-mdfkbtc
that referenced
this pull request
Jan 23, 2020
Updates text since -whitelistforcerelay was set to false by default in PR bitcoin#15193. (cherry picked from commit e0bb279)
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 19, 2020
Summary: Updates text since -whitelistforcerelay was set to false by default in [[bitcoin/bitcoin#15193 | PR15193]]. Backport of Core [[bitcoin/bitcoin#15890 | PR15890]] Test Plan: `ninja && src/bitcoind -help` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D7975
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
…-whitelist e0bb279 Doc: remove text about txes always relayed from -whitelist (David A. Harding) Pull request description: Updates text since -whitelistforcerelay was set to false by default in PR bitcoin#15193. ACKs for commit e0bb27: fanquake: utACK e0bb279 MarcoFalke: utACK e0bb279 Tree-SHA512: cf0c9321d72692d573039a04f8f1d048cbdf67ed86cc781523dabd3c45d2731b788f53749e6bb29d7da1ab44eb04030f352469b20489bb2a26c2c38fb61f6489
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 20, 2021
a36d97d Default -whitelistforcerelay to off (Suhas Daftuar) Pull request description: No one seems to use this "feature", and at any rate the behavior of relaying transactions when they violate local policy is error-prone, if we ever consider changing the ban behavior of our software from one version to the next. Defaulting this to off means that users who use -whitelist won't be unexpectedly surprised by this interaction. If anyone is still relying on this feature, it can still be explicitly turned on. Tree-SHA512: 52650ad464a728d1648f496751e3f713077ea3a1de7278ed03531b2e8723e63cf2f6f41b56c98c0f73ffa22c36e01d9170b409ab452c737aca35b7ecd7a6b448 # Conflicts: # doc/release-notes.md # src/validation.h # test/functional/p2p_segwit.py
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 11, 2021
…-whitelist e0bb279 Doc: remove text about txes always relayed from -whitelist (David A. Harding) Pull request description: Updates text since -whitelistforcerelay was set to false by default in PR bitcoin#15193. ACKs for commit e0bb27: fanquake: utACK e0bb279 MarcoFalke: utACK e0bb279 Tree-SHA512: cf0c9321d72692d573039a04f8f1d048cbdf67ed86cc781523dabd3c45d2731b788f53749e6bb29d7da1ab44eb04030f352469b20489bb2a26c2c38fb61f6489
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 12, 2021
…-whitelist e0bb279 Doc: remove text about txes always relayed from -whitelist (David A. Harding) Pull request description: Updates text since -whitelistforcerelay was set to false by default in PR bitcoin#15193. ACKs for commit e0bb27: fanquake: utACK e0bb279 MarcoFalke: utACK e0bb279 Tree-SHA512: cf0c9321d72692d573039a04f8f1d048cbdf67ed86cc781523dabd3c45d2731b788f53749e6bb29d7da1ab44eb04030f352469b20489bb2a26c2c38fb61f6489
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No one seems to use this "feature", and at any rate the behavior of relaying transactions when they violate local policy is error-prone, if we ever consider changing the ban behavior of our software from one version to the next.
Defaulting this to off means that users who use -whitelist won't be unexpectedly surprised by this interaction. If anyone is still relying on this feature, it can still be explicitly turned on.