qt: Fix wallet selector size adjustment #15167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
utACK ca91661, this was on my to do list. |
|
Is the color of this GUI also going to be changed to this dark color? |
Member
Author
No. There are different Qt versions. System-wide Qt handles dark theme of my DE. |
|
@hebasto Ah cool, thank you, good to hear. |
Member
|
tACK ca91661 on macOS 10.14.2 (qt 5.12.0) Note that on macOS if the window is too small to fit the longest wallet name between "Transactions" and the edge of the screen, the wallet selector turns into ">>" and appears below the other tabs. i.e: However that section folds up when you mouse away 👍 Other screenshots of ca91661 usage: |
laanwj
added a commit
that referenced
this pull request
Jan 21, 2019
ca91661 Fix wallet selector size adjustment (Hennadii Stepanov) Pull request description: This PR sets `QComboBox::AdjustToContents` instead of default `QComboBox::AdjustToContentsOnFirstShow` for wallet selectors. Before (in master):  After (with this PR):  Tree-SHA512: c23ac91905bb31aaa32f2fccc02b01f5707d8b094020fe6a75a9e099e78f9191670474920234a01c46480f67d3d311f44ff46f1f4202cd50a4a6d4d09a8342ce
Contributor
|
Not sure if related but I'm having this:
It only shows full wallet name (path) if it's the current. |
Member
Author
Which OS? Which Qt version? |
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 10, 2020
Summary: > This PR sets QComboBox::AdjustToContents instead of default QComboBox::AdjustToContentsOnFirstShow for wallet selectors. This is a backport of Core [[bitcoin/bitcoin#15167 | PR15167]] Test Plan: `ninja && src/qt/bitcoin-qt` Create a new wallet with a very long name, and check that the name is not truncated in the dropdown selectors (in main window and in the console tab of the debug dialog) Reviewers: #bitcoin_abc, Fabien, majcosta Reviewed By: #bitcoin_abc, Fabien, majcosta Differential Revision: https://reviews.bitcoinabc.org/D8356
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Aug 24, 2021
ca91661 Fix wallet selector size adjustment (Hennadii Stepanov) Pull request description: This PR sets `QComboBox::AdjustToContents` instead of default `QComboBox::AdjustToContentsOnFirstShow` for wallet selectors. Before (in master):  After (with this PR):  Tree-SHA512: c23ac91905bb31aaa32f2fccc02b01f5707d8b094020fe6a75a9e099e78f9191670474920234a01c46480f67d3d311f44ff46f1f4202cd50a4a6d4d09a8342ce
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Aug 24, 2021
ca91661 Fix wallet selector size adjustment (Hennadii Stepanov) Pull request description: This PR sets `QComboBox::AdjustToContents` instead of default `QComboBox::AdjustToContentsOnFirstShow` for wallet selectors. Before (in master):  After (with this PR):  Tree-SHA512: c23ac91905bb31aaa32f2fccc02b01f5707d8b094020fe6a75a9e099e78f9191670474920234a01c46480f67d3d311f44ff46f1f4202cd50a4a6d4d09a8342ce
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets
QComboBox::AdjustToContentsinstead of defaultQComboBox::AdjustToContentsOnFirstShowfor wallet selectors.Before (in master):
After (with this PR):
