gui: Add Open Wallet menu #15153
Merged
gui: Add Open Wallet menu #15153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
promag
force-pushed
the
2019-01-openwallet
branch
3 times, most recently
from
57850e6 to
fa82113
Compare
Member
|
Concept ACK. |
promag
force-pushed
the
2019-01-openwallet
branch
2 times, most recently
from
4a39506 to
cc906b3
Compare
promag
force-pushed
the
2019-01-openwallet
branch
from
cc906b3 to
f9bea23
Compare
promag
force-pushed
the
2019-01-openwallet
branch
from
4daa5c5 to
668499d
Compare
promag
force-pushed
the
2019-01-openwallet
branch
2 times, most recently
from
b774219 to
4dac472
Compare
promag
force-pushed
the
2019-01-openwallet
branch
from
4dac472 to
09780df
Compare
Member
|
Concept ACK. Code looks good at first glance; will review once upstream is merged. |
promag
force-pushed
the
2019-01-openwallet
branch
from
09780df to
014f92a
Compare
promag
force-pushed
the
2019-01-openwallet
branch
3 times, most recently
from
3617f9d to
e61178a
Compare
promag
force-pushed
the
2019-01-openwallet
branch
from
e61178a to
354bebc
Compare
10 tasks
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
May 18, 2020
Summary: bitcoin/bitcoin@ab288b4 --- This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: ninja check Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6110
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
May 18, 2020
… WalletController Summary: bitcoin/bitcoin@32a8c6a --- This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: ninja check Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6112
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
May 19, 2020
Summary: bitcoin/bitcoin@6c49a55 --- This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: ninja check ./src/qt/bitcoin-qt -regtest -server ./src/bitcoin-cli -regtest createwallet test ./src/bitcoin-cli -regtest unloadwallet test Changing focus to Open Wallet should reveal 'test', clicking it reveals combobox at right of interface allowing to switch between '[Default wallet]' and 'test' Reviewers: #bitcoin_abc, jasonbcox, deadalnix Reviewed By: #bitcoin_abc, jasonbcox, deadalnix Subscribers: deadalnix, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D6115
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
May 19, 2020
…Controller Summary: bitcoin/bitcoin@be82dea --- Depends on D6115 This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: ninja check Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6119
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
May 19, 2020
Summary: bitcoin/bitcoin@4c8982a --- Depends on D6119 This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: ninja check Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6121
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
May 19, 2020
Summary: bitcoin/bitcoin@8847cda --- Depends on D6121 This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: as D6115 Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6128
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
May 19, 2020
…g wallet Summary: bitcoin/bitcoin@1951ea4 --- Depends on D6128 This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: ninja check Run: ./src/qt/bitcoin-qt -regtest -server ./src/bitcoin-cli -regtest createwallet test ./src/bitcoin-cli -regtest unloadwallet test Choose: File -> Open Wallet -> test See a modal with "Opening wallet test" pops up then disappears Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6129
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Aug 14, 2020
Summary: bitcoin/bitcoin@17abc0f --- Depends on D6084 This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF] ninja check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Aug 27, 2020
Summary: bitcoin/bitcoin@17abc0f --- Depends on D6084 This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF] ninja check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Aug 28, 2020
Summary: bitcoin/bitcoin@17abc0f --- Depends on D6084 This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF] ninja check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Sep 4, 2020
Summary: bitcoin/bitcoin@17abc0f --- Depends on D6084 This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF] ninja check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Sep 5, 2020
Summary: bitcoin/bitcoin@17abc0f --- Depends on D6084 This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF] ninja check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Sep 6, 2020
Summary: bitcoin/bitcoin@17abc0f --- Depends on D6084 This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF] ninja check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Sep 13, 2020
Summary: bitcoin/bitcoin@17abc0f --- Depends on D6084 This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF] ninja check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Sep 13, 2020
Summary: bitcoin/bitcoin@17abc0f --- Depends on D6084 This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF] ninja check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Sep 15, 2020
Summary: bitcoin/bitcoin@17abc0f --- Depends on D6084 This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF] ninja check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Sep 16, 2020
Summary: bitcoin/bitcoin@17abc0f --- Depends on D6084 This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF] ninja check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Sep 16, 2020
Summary: bitcoin/bitcoin@17abc0f --- Depends on D6084 This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF] ninja check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Sep 17, 2020
Summary: bitcoin/bitcoin@17abc0f --- Depends on D6084 This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF] ninja check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Sep 18, 2020
Summary: bitcoin/bitcoin@17abc0f --- Depends on D6084 This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF] ninja check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Sep 21, 2020
Summary: bitcoin/bitcoin@17abc0f --- Depends on D6084 This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF] ninja check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Sep 21, 2020
Summary: bitcoin/bitcoin@17abc0f --- Depends on D6084 This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF] ninja check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Sep 23, 2020
Summary: bitcoin/bitcoin@17abc0f --- Depends on D6084 This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF] ninja check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6096
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Sep 24, 2020
Summary: bitcoin/bitcoin@17abc0f --- Depends on D6084 This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF] ninja check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6096
proteanx
pushed a commit
to devaultcrypto/devault
that referenced
this pull request
Sep 25, 2020
Summary: bitcoin/bitcoin@17abc0f --- Depends on D6084 This is a partial backport of Core [[bitcoin/bitcoin#15153 | PR15153]] Test Plan: cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF] ninja check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6096
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Oct 23, 2021
1951ea4 gui: Show indeterminate progress dialog while opening walllet (João Barbosa) 8847cda gui: Add OpenWalletActivity (João Barbosa) 4c8982a interfaces: Avoid interface instance if wallet is null (João Barbosa) be82dea gui: Add thread to run background activity in WalletController (João Barbosa) 6c49a55 gui: Add Open Wallet menu (João Barbosa) 32a8c6a gui: Add openWallet and getWalletsAvailableToOpen to WalletController (João Barbosa) ab288b4 interfaces: Add loadWallet to Node (João Barbosa) 17abc0f wallet: Factor out LoadWallet (João Barbosa) Pull request description: The *Open Wallet* menu has all the available wallets currently not loaded. The list of the available wallets comes from `listWalletDir`. In the future the menu can be replaced by a custom dialog. <img width="674" alt="screenshot 2019-01-12 at 12 17 02" src="https://user-images.githubusercontent.com/3534524/51073166-ac041480-1664-11e9-8302-be81702bc146.png"> Tree-SHA512: ebfd75eee0c8264863748899843afab67dadb7dff21313c11e3cb5b6108d954978dd1f1ae786bc07580c5a771ea4ab38d18c1643c9b9b3683ed53f0f6c582e38
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
1951ea4 gui: Show indeterminate progress dialog while opening walllet (João Barbosa) 8847cda gui: Add OpenWalletActivity (João Barbosa) 4c8982a interfaces: Avoid interface instance if wallet is null (João Barbosa) be82dea gui: Add thread to run background activity in WalletController (João Barbosa) 6c49a55 gui: Add Open Wallet menu (João Barbosa) 32a8c6a gui: Add openWallet and getWalletsAvailableToOpen to WalletController (João Barbosa) ab288b4 interfaces: Add loadWallet to Node (João Barbosa) 17abc0f wallet: Factor out LoadWallet (João Barbosa) Pull request description: The *Open Wallet* menu has all the available wallets currently not loaded. The list of the available wallets comes from `listWalletDir`. In the future the menu can be replaced by a custom dialog. <img width="674" alt="screenshot 2019-01-12 at 12 17 02" src="https://user-images.githubusercontent.com/3534524/51073166-ac041480-1664-11e9-8302-be81702bc146.png"> Tree-SHA512: ebfd75eee0c8264863748899843afab67dadb7dff21313c11e3cb5b6108d954978dd1f1ae786bc07580c5a771ea4ab38d18c1643c9b9b3683ed53f0f6c582e38
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Open Wallet menu has all the available wallets currently not loaded. The list of the available wallets comes from
listWalletDir.In the future the menu can be replaced by a custom dialog.