test: fix script_p2sh_tests OP_PUSHBACK2/4 missing #15140
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes commit 6b25f29 where opcodes where lost in translation.
maflcko
reviewed
Jan 10, 2019
| BOOST_CHECK(CScript(direct.begin(), direct.end()).IsPayToScriptHash()); | ||
|
|
||
| //---------><----- cut here | ||
| // orig version fixed by re-adding OP_PUSHDATA2/4 |
Member
There was a problem hiding this comment.
Can you explain what cut here and orig version means? I think those are confusion to test readers.
Author
There was a problem hiding this comment.
Oh, sorry my commit comment was a bit short.
I've made two versions of the fix since I didn't know what you prefer.
The orig version is clearer in what it fixes.
The block below that is perhaps less code, though not perhaps the quickest to understand at-a-glance.
Member
maflcko
reviewed
Feb 13, 2019
| BOOST_CHECK(!CScript(script.begin(), script.end()).IsPayToScriptHash()); | ||
| } | ||
|
|
||
| //---------><----- cut here |
Member
There was a problem hiding this comment.
Could you either please remove the comments here or remove the whole second hunk. I think the fixup should be standalone and minimal.
Member
|
utACK first version |
Member
|
ACK, sorry this was my oversight |
Contributor
|
Good catch, sorry for missing the Also, please squash the two commits. |
Member
|
This has been waiting for the author for more than half a year. Closing with "up for grabs". |
maflcko
pushed a commit
that referenced
this pull request
Nov 1, 2019
5710dad test: fix script_p2sh_tests OP_PUSHBACK2/4 missing (kodslav) Pull request description: Cleans up #15140 which fixes commit 6b25f29 where opcodes were lost in translation. ACKs for top commit: laanwj: code review ACK 5710dad Tree-SHA512: 3f7fbcaf0dd199626d9ec9fdf3c5b5c5c2a91c4cfe81fae5b1d5662a48e52cf4bd27c94f8f42ebdfe7a076c5d600ada5661a6902b03eb5dc3dc953f4524345ac
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 2, 2019
5710dad test: fix script_p2sh_tests OP_PUSHBACK2/4 missing (kodslav) Pull request description: Cleans up bitcoin#15140 which fixes commit 6b25f29 where opcodes were lost in translation. ACKs for top commit: laanwj: code review ACK 5710dad Tree-SHA512: 3f7fbcaf0dd199626d9ec9fdf3c5b5c5c2a91c4cfe81fae5b1d5662a48e52cf4bd27c94f8f42ebdfe7a076c5d600ada5661a6902b03eb5dc3dc953f4524345ac
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
5710dad test: fix script_p2sh_tests OP_PUSHBACK2/4 missing (kodslav) Pull request description: Cleans up bitcoin#15140 which fixes commit 6b25f29 where opcodes were lost in translation. ACKs for top commit: laanwj: code review ACK 5710dad Tree-SHA512: 3f7fbcaf0dd199626d9ec9fdf3c5b5c5c2a91c4cfe81fae5b1d5662a48e52cf4bd27c94f8f42ebdfe7a076c5d600ada5661a6902b03eb5dc3dc953f4524345ac
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
5710dad test: fix script_p2sh_tests OP_PUSHBACK2/4 missing (kodslav) Pull request description: Cleans up bitcoin#15140 which fixes commit 6b25f29 where opcodes were lost in translation. ACKs for top commit: laanwj: code review ACK 5710dad Tree-SHA512: 3f7fbcaf0dd199626d9ec9fdf3c5b5c5c2a91c4cfe81fae5b1d5662a48e52cf4bd27c94f8f42ebdfe7a076c5d600ada5661a6902b03eb5dc3dc953f4524345ac
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 14, 2021
5710dad test: fix script_p2sh_tests OP_PUSHBACK2/4 missing (kodslav) Pull request description: Cleans up bitcoin#15140 which fixes commit 6b25f29 where opcodes were lost in translation. ACKs for top commit: laanwj: code review ACK 5710dad Tree-SHA512: 3f7fbcaf0dd199626d9ec9fdf3c5b5c5c2a91c4cfe81fae5b1d5662a48e52cf4bd27c94f8f42ebdfe7a076c5d600ada5661a6902b03eb5dc3dc953f4524345ac
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes commit 6b25f29 where opcodes where probably lost in translation.
Made two versions, the looped test using the '<<' operator also (stream api).