qt: "Peers" tab overhaul #15136
Merged
qt: "Peers" tab overhaul #15136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the QSplitter and QScrollArea classes.
Effectevely reverts e059726 commit.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
|
Did a quick test and looks good (https://bitcoin.jonasschnelli.ch/build/946). utACK 3537c83 |
Contributor
|
tACK 3537c83 on macOS 10.14.2, keeping the selection looks better to me. Will review changes to |
promag
reviewed
Jan 14, 2019
| </spacer> | ||
| </item> | ||
| </layout> | ||
| <widget class="QWidget" name="widget_1" native="true"> |
Member
Author
There was a problem hiding this comment.
Note: Adding a QLayout to a QSplitter is not supported (either through setLayout() or making the QSplitter a parent of the QLayout); use addWidget() instead.
So, it cannot be a table or other kind of QLayout.
Member
|
utACK 3537c83 |
laanwj
added a commit
that referenced
this pull request
Jan 16, 2019
3537c83 Do not deselect peer when switching away from tab (Hennadii Stepanov) b0037c5 Improve Peers tab layout (Hennadii Stepanov) Pull request description: This is an alternative to #14798. The "Peers" tab of the "Debug" window improved to address comments #6209 (comment) (by @jonasschnelli) and #14798 (comment) (by @promag). This allows to keep the peer selection while navigating to other places and effectively reverts e059726. Screenshots with this PR:    Tree-SHA512: 3d086007f6d72930bc2fc3c395175adda0f1a7722de3842bc246ee4f3bfc5ebda4b9a626fb68a7ee8663a88d0842deb37c0c460ad84cc58e22f138acf8bc71ea
Contributor
|
On macOS this broke the visibility of the Services (scrolled all way to the right end)
|
Member
Author
|
@HashUnlimited you can adjust a view by moving
|
Contributor
|
ah OK... thanks. pretty confusing though that scrolling doesn't reveal all contents. |
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 28, 2020
Summary: 3537c8345c788a527bb4e1d00683ca7f8ee5fb1a Do not deselect peer when switching away from tab (Hennadii Stepanov) b0037c51909dc55e279baa81f063c169c9735105 Improve Peers tab layout (Hennadii Stepanov) Pull request description: This is an alternative to #14798. The "Peers" tab of the "Debug" window improved to address comments bitcoin/bitcoin#6209 (comment) (by @jonasschnelli) and bitcoin/bitcoin#14798 (comment) (by @promag). This allows to keep the peer selection while navigating to other places and effectively reverts e059726. Screenshots with this PR:    --- Backport of Core [[bitcoin/bitcoin#15136 | PR15136]] Test Plan: ninja all ./qt/bitcoin-qt -testnet check out the Peers tab for correctness Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Differential Revision: https://reviews.bitcoinabc.org/D8547
christiancfifi
pushed a commit
to christiancfifi/dash
that referenced
this pull request
Oct 3, 2021
3537c83 Do not deselect peer when switching away from tab (Hennadii Stepanov) b0037c5 Improve Peers tab layout (Hennadii Stepanov) Pull request description: This is an alternative to bitcoin#14798. The "Peers" tab of the "Debug" window improved to address comments bitcoin#6209 (comment) (by @jonasschnelli) and bitcoin#14798 (comment) (by @promag). This allows to keep the peer selection while navigating to other places and effectively reverts e059726. Screenshots with this PR:    Tree-SHA512: 3d086007f6d72930bc2fc3c395175adda0f1a7722de3842bc246ee4f3bfc5ebda4b9a626fb68a7ee8663a88d0842deb37c0c460ad84cc58e22f138acf8bc71ea
christiancfifi
added a commit
to christiancfifi/dash
that referenced
this pull request
Oct 3, 2021
christiancfifi
pushed a commit
to christiancfifi/dash
that referenced
this pull request
Oct 11, 2021
3537c83 Do not deselect peer when switching away from tab (Hennadii Stepanov) b0037c5 Improve Peers tab layout (Hennadii Stepanov) Pull request description: This is an alternative to bitcoin#14798. The "Peers" tab of the "Debug" window improved to address comments bitcoin#6209 (comment) (by @jonasschnelli) and bitcoin#14798 (comment) (by @promag). This allows to keep the peer selection while navigating to other places and effectively reverts e059726. Screenshots with this PR:    Tree-SHA512: 3d086007f6d72930bc2fc3c395175adda0f1a7722de3842bc246ee4f3bfc5ebda4b9a626fb68a7ee8663a88d0842deb37c0c460ad84cc58e22f138acf8bc71ea
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
3537c83 Do not deselect peer when switching away from tab (Hennadii Stepanov) b0037c5 Improve Peers tab layout (Hennadii Stepanov) Pull request description: This is an alternative to bitcoin#14798. The "Peers" tab of the "Debug" window improved to address comments bitcoin#6209 (comment) (by @jonasschnelli) and bitcoin#14798 (comment) (by @promag). This allows to keep the peer selection while navigating to other places and effectively reverts e059726. Screenshots with this PR:    Tree-SHA512: 3d086007f6d72930bc2fc3c395175adda0f1a7722de3842bc246ee4f3bfc5ebda4b9a626fb68a7ee8663a88d0842deb37c0c460ad84cc58e22f138acf8bc71ea
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #14798.
The "Peers" tab of the "Debug" window improved to address comments #6209 (comment) (by @jonasschnelli) and #14798 (comment) (by @promag).
This allows to keep the peer selection while navigating to other places and effectively reverts e059726.
Screenshots with this PR:
