Changed a comment about a QVariant type #1508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the type-casting to int instead of short a problem here? I'm asking because I'm working on the proxy-options in the GUI currently. ACK to the pull. |
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
…#1508) * Only store and connect to NODE_NETWORK nodes * Keep addrman's nService bits consistent with outbound observations * Verify that outbound connections have expected services * Don't require services in -addnode * Introduce enum ServiceFlags for service flags * Introduce REQUIRED_SERVICES constant
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 22, 2019
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
May 6, 2020
…ature collateral 7830c17 [BUG] Prevent StartAll from starting mns with immature collateral (random-zebra) Pull request description: Extends the fix of bitcoin#1389 (point 2) also to `startAll` (not only `startAlias`). Additional ref: PIVX-Project#1226 ACKs for top commit: Fuzzbawls: utACK 7830c17 furszy: utACK 7830c17 Tree-SHA512: 74798a075aab71d27b3e65827e625eb876ddc7d0a0a6a641864aa5bfa8bc720ee8200020dc497b03e436b6e4df25bef09955397dbdc7f267cdbd3f5781b08223
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OptionsModel::data that set it has changed. Now it's
GetPort() returns an unsigned short, that is upcasted by the QVariant (that doesn't directly support shorts)