Improve CScriptNum error reporting #15074
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
| catch (ScriptError runtime_error) | ||
| { | ||
| return set_error(serror, runtime_error); | ||
|
|
Contributor
There was a problem hiding this comment.
Nit: Remove redundant newline at end of block :-)
Member
There was a problem hiding this comment.
Also our catch syntax is } catch (ScriptError runtime_error) { — but let's first get Concept ACKs on this before nitting it
Contributor
|
utACK 50605f0 |
Member
|
Going to take this over in a new PR. |
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Sep 16, 2019
Instead of reporting "unknown error", more specific messages are returned for CScriptNum related errors. Original PR: bitcoin#15074 Co-Authored-By: Johnson Lau <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of reporting "unknown error", more specific messages are returned for CScriptNum related errors.
Also replaced
throwwithassertin caseopcodeis negative or bigger than 0xff, which should never happen