Build: add names to Travis jobs #15020
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Concept ACK |
gkrizek
force-pushed
the
travis-job-names
branch
from
f1eda12 to
30922a7
Compare
|
As previously commented, when you add a name to your jobs the Travis UI removes the environment variables from the build when in the list view. (They still show up when you view an individual build's page). I think having a build name is more valuable in the list view than the variables. We can always add some sort of 'tag' to the job name if we feel that's needed. |
|
Here's an example where a new "disable bip 70" build was added - I challenge you to quickly identify which build it is: https://travis-ci.org/bitcoin/bitcoin/builds/473735618?utm_source=github_status&utm_medium=notification #15063 It could be helpful to describe the build more fully, e.g. "no depends, only system libs, sanitizers: thread (TSan)" is relevant IMO. Also possibly: |
gkrizek
force-pushed
the
travis-job-names
branch
from
30922a7 to
6b486c2
Compare
|
@Empact That's why I thought this PR could be helpful. Same for someone new looking at the project. Very hard to tell what's going on in the current state. I just pushed a commit that adds more details to the job names as it seems like more are in agreement that it would be helpful. |
gkrizek
force-pushed
the
travis-job-names
branch
from
6b486c2 to
5af7d0b
Compare
|
@fanquake Thanks for the review! I've pushed a commit with your changes added. |
|
Concept ACK |
This also removes job name comments from .travis.yml because they are no longer necessary
gkrizek
force-pushed
the
travis-job-names
branch
from
5af7d0b to
1db71d4
Compare
1db71d4 Add names to Travis jobs (Graham Krizek) Pull request description: This adds the `name` field to all the TravisCI jobs. This will make it more obvious in the Travis UI what job is failing or passing. Tree-SHA512: d65841bab0a80d098a46a4bb54af2f9a93db7abca93b848aa00d25dcf4cd74323371c7c0b78b4dbf390b197e7ba32262a91631e201fc505f834021753f700b28
|
Great! I've been wanting this for a long time. utACK 1db71d4. |
1db71d4 Add names to Travis jobs (Graham Krizek) Pull request description: This adds the `name` field to all the TravisCI jobs. This will make it more obvious in the Travis UI what job is failing or passing. Tree-SHA512: d65841bab0a80d098a46a4bb54af2f9a93db7abca93b848aa00d25dcf4cd74323371c7c0b78b4dbf390b197e7ba32262a91631e201fc505f834021753f700b28
8 participants
This adds the
namefield to all the TravisCI jobs. This will make it more obvious in the Travis UI what job is failing or passing.