Add option to create an encrypted wallet #15006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
|
Concept ACK |
achow101
force-pushed
the
create-encrypted-wallet
branch
from
73efe2b to
1733089
Compare
Member
|
Concept ACK. Today on IRC: |
achow101
force-pushed
the
create-encrypted-wallet
branch
from
1733089 to
3205e6e
Compare
Contributor
|
Concept ACK |
Contributor
There was a problem hiding this comment.
Missing whitespace after ,. Please run this newly added file through black to make sure formatting is correct :-)
Member
There was a problem hiding this comment.
@practicalswift that's an upstream test from #14938, where this has been fixed.
Member
|
Concept ACK |
Member
|
This fails travis: |
achow101
force-pushed
the
create-encrypted-wallet
branch
2 times, most recently
from
780a296 to
3f17cbe
Compare
Member
Author
|
Fixed by rebasing |
achow101
force-pushed
the
create-encrypted-wallet
branch
from
3f17cbe to
e2f447f
Compare
Member
Author
achow101
force-pushed
the
create-encrypted-wallet
branch
2 times, most recently
from
18886a2 to
b7918ad
Compare
achow101
force-pushed
the
create-encrypted-wallet
branch
from
b7918ad to
51a477f
Compare
Member
Author
|
Rebased |
laanwj
reviewed
Jan 31, 2019
src/interfaces/wallet.cpp
Outdated
Member
There was a problem hiding this comment.
handleCanGetAddressesChanged is a terrible method name in itself, took me at least 5 minutes to decode it, please add a comment saying it's a handler for changes in whether addresses can be generated or not :-)
Member
Author
There was a problem hiding this comment.
That's a change from #15225 and out of scope for this pr. sorry.
Member
There was a problem hiding this comment.
Fwiw I find it easy enough to read, but I'm used to similar nomenclature from iOs :-)
laanwj
reviewed
Jan 31, 2019
Member
There was a problem hiding this comment.
I remember I had a comment on this (please factor out the value→cli functionality to a function instead of duplicating it) but somehow it got lost …
Member
Author
There was a problem hiding this comment.
Since this issue affects multiple PRs, I've split the fix into a separate PR: #15301
Contributor
There was a problem hiding this comment.
hmmm, bizarre. You definitely did have a comment here because I responded to it!
achow101
force-pushed
the
create-encrypted-wallet
branch
from
51a477f to
f2bed74
Compare
achow101
force-pushed
the
create-encrypted-wallet
branch
from
f2bed74 to
5e3d2b9
Compare
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jun 8, 2019
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Dec 3, 2019
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jun 5, 2020
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jun 5, 2020
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jun 7, 2020
Summary: bitcoin/bitcoin@662d117 --- Backport of Core [[bitcoin/bitcoin#15006 | PR15006]] Test Plan: ninja check ./test/functional/test_runner.py wallet_createwallet.py Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6423
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jun 16, 2020
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
achow101
pushed a commit
to achow101/bitcoin
that referenced
this pull request
Jun 22, 2020
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jun 25, 2020
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jun 25, 2020
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jun 25, 2020
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jul 2, 2020
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jul 2, 2020
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jul 11, 2020
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jul 11, 2020
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jul 13, 2020
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jul 13, 2020
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jul 23, 2020
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jul 23, 2020
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jul 23, 2020
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jul 23, 2020
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jul 23, 2020
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Aug 13, 2020
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Aug 13, 2020
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Aug 13, 2020
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Aug 13, 2020
This maintains a persistent list of wallets stored in settings that will automatically be loaded on startup. Being able to load a wallet automatically on startup will be more useful in the GUI when the option to create wallets is added in bitcoin#15006, but it's reasonable to expose this feature by RPC as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
passphraseargument tocreatewalletwhich will create a wallet that is encrypted with that passphrase.This is built on #15226 because it needs to first create an empty wallet, then encrypt the empty wallet and generate new keys that have only been stored in an encrypted state.