rpc: Fix data race (UB) in InterruptRPC() #14993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
utACK 10f8244a777392f87c2671d743b14201d24351be I don't think this can actually result in a data race but an atomic is certainly more appropriate here. |
promag
reviewed
Dec 18, 2018
practicalswift
force-pushed
the
rpc-datarace
branch
from
10f8244 to
9ed8713
Compare
Contributor
|
utACK 9ed8713. |
maflcko
reviewed
Dec 18, 2018
Member
maflcko
left a comment
maflcko
left a comment
There was a problem hiding this comment.
Remove from the suppressions file?
practicalswift
force-pushed
the
rpc-datarace
branch
from
9ed8713 to
b693a22
Compare
practicalswift
force-pushed
the
rpc-datarace
branch
from
b693a22 to
6c10037
Compare
Contributor
Author
|
@MarcoFalke Done! Please re-review :-) |
Contributor
|
utACK 6c10037. |
laanwj
added a commit
that referenced
this pull request
Dec 19, 2018
6c10037 rpc: Fix data race (UB) in InterruptRPC() (practicalswift) Pull request description: Fix data race (UB) in `InterruptRPC()`. Before: ``` $ ./configure --with-sanitizers=thread $ make $ test/functional/test_runner.py feature_shutdown.py … SUMMARY: ThreadSanitizer: data race rpc/server.cpp:314 in InterruptRPC() … ALL | ✖ Failed | 2 s (accumulated) ``` After: ``` $ ./configure --with-sanitizers=thread $ make $ test/functional/test_runner.py feature_shutdown.py … ALL | ✓ Passed | 3 s (accumulated) ``` Tree-SHA512: b139ca1a0480258f8caa7730cabd7783a821d906630f51487750a6b15b7842675ed679747e1ff1bdade77d248807e9d77bae7bb88da54d1df84a179cd9b9b987
Member
|
I'm still getting |
Contributor
|
(introduced in #14670) |
LarryRuane
pushed a commit
to LarryRuane/zcash
that referenced
this pull request
Apr 29, 2021
zcash: cherry picked from commit 6c10037 zcash: bitcoin/bitcoin#14993
LarryRuane
pushed a commit
to LarryRuane/zcash
that referenced
this pull request
Jun 1, 2021
zcash: cherry picked from commit 6c10037 zcash: bitcoin/bitcoin#14993
This was referenced Dec 8, 2021
This was referenced Dec 12, 2021
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
May 23, 2022
6c10037 rpc: Fix data race (UB) in InterruptRPC() (practicalswift) Pull request description: Fix data race (UB) in `InterruptRPC()`. Before: ``` $ ./configure --with-sanitizers=thread $ make $ test/functional/test_runner.py feature_shutdown.py … SUMMARY: ThreadSanitizer: data race rpc/server.cpp:314 in InterruptRPC() … ALL | ✖ Failed | 2 s (accumulated) ``` After: ``` $ ./configure --with-sanitizers=thread $ make $ test/functional/test_runner.py feature_shutdown.py … ALL | ✓ Passed | 3 s (accumulated) ``` Tree-SHA512: b139ca1a0480258f8caa7730cabd7783a821d906630f51487750a6b15b7842675ed679747e1ff1bdade77d248807e9d77bae7bb88da54d1df84a179cd9b9b987
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix data race (UB) in
InterruptRPC().Before:
After: