test: Remove thread_local from test_bitcoin #14985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
reviewed
Dec 17, 2018
| thread_local extern FastRandomContext g_insecure_rand_ctx; | ||
| extern FastRandomContext g_insecure_rand_ctx; | ||
|
|
||
| static inline void SeedInsecureRand(bool deterministic = false) |
Member
There was a problem hiding this comment.
Would make sense to add a warning comment for these helper functions to only use them from the main thread.
maflcko
force-pushed
the
Mf1812-testNoThreadLocal
branch
from
fac748e to
fa61202
Compare
Member
|
utACK fa61202 |
Contributor
|
utACK fa61202. |
promag
reviewed
Dec 18, 2018
| // create a bunch of threads that repeatedly process a block generated above at random | ||
| // this will create parallelism and randomness inside validation - the ValidationInterface | ||
| // will subscribe to events generated during block validation and assert on ordering invariance | ||
| boost::thread_group threads; |
maflcko
pushed a commit
that referenced
this pull request
Dec 18, 2018
fa61202 test: Add comment to g_insecure_rand_ctx (MarcoFalke) fa0d3c4 test: Undo thread_local g_insecure_rand_ctx (MarcoFalke) Pull request description: `thread_local` seems to be highly controversial according to the discussion in #14953, so remove it again from the tests. Also remove boost::thread_group in the test that uses it, since I am touching it anyway. Tree-SHA512: 977c1f597e3cfbd0e97d0b037d998fdbc701f62e9a2f57e02dbe1727b63ae8ff478dbd9d3d6dc4ffdfa23f2058b331f04949d51f23a8f55b41ecb75f088f1cbe
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Aug 11, 2021
fa61202 test: Add comment to g_insecure_rand_ctx (MarcoFalke) fa0d3c4 test: Undo thread_local g_insecure_rand_ctx (MarcoFalke) Pull request description: `thread_local` seems to be highly controversial according to the discussion in bitcoin#14953, so remove it again from the tests. Also remove boost::thread_group in the test that uses it, since I am touching it anyway. Tree-SHA512: 977c1f597e3cfbd0e97d0b037d998fdbc701f62e9a2f57e02dbe1727b63ae8ff478dbd9d3d6dc4ffdfa23f2058b331f04949d51f23a8f55b41ecb75f088f1cbe
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Aug 15, 2021
fa61202 test: Add comment to g_insecure_rand_ctx (MarcoFalke) fa0d3c4 test: Undo thread_local g_insecure_rand_ctx (MarcoFalke) Pull request description: `thread_local` seems to be highly controversial according to the discussion in bitcoin#14953, so remove it again from the tests. Also remove boost::thread_group in the test that uses it, since I am touching it anyway. Tree-SHA512: 977c1f597e3cfbd0e97d0b037d998fdbc701f62e9a2f57e02dbe1727b63ae8ff478dbd9d3d6dc4ffdfa23f2058b331f04949d51f23a8f55b41ecb75f088f1cbe
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thread_localseems to be highly controversial according to the discussion in #14953, so remove it again from the tests.Also remove boost::thread_group in the test that uses it, since I am touching it anyway.