rpc: Add getrpcinfo command #14982
Merged
rpc: Add getrpcinfo command #14982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promag
commented
Dec 17, 2018
Member
|
Concept ACK |
Empact
reviewed
Dec 18, 2018
Empact
reviewed
Dec 18, 2018
Contributor
Author
|
@Empact @practicalswift I guess you concept ACK? |
Contributor
|
Concept Ack. Does Line 733 in 24b3b78 |
Contributor
|
Concept ACK.
|
Contributor
|
Concept ACK |
Member
|
concept ACK . could it add things like port it's listening to? |
Contributor
Author
|
I guess you have to know that to call this RPC? |
Member
|
@promag the computer knows this, yes ;P |
Member
|
So I'd say if everyone is Concept ACK, I think it makes sense to fix the nits, utACK and merge this and add further ideas in later PRs. |
promag
force-pushed
the
2018-12-getrpcinfo
branch
from
9d4d3ab to
a0ac154
Compare
Contributor
Author
|
@laanwj updated. |
Member
|
utACK a0ac154 |
Contributor
|
tested ACK 251a91c It currently mildly useful and I can't follow the discussion why uptime is gone. But this is a great starting point for a general RPC state report. |
laanwj
added a commit
that referenced
this pull request
Jan 14, 2019
a0ac154 doc: Add getrpcinfo release notes (João Barbosa) 251a91c qa: Add tests for getrpcinfo (João Barbosa) d0730f5 rpc: Add getrpcinfo command (João Barbosa) 068a8fc rpc: Track active commands (João Barbosa) bf43832 rpc: Remove unused PreCommand signal (João Barbosa) Pull request description: The new `getrpcinfo` command exposes details of the RPC interface. The details can be configuration properties or runtime values/stats. This can be particular useful to coordinate concurrent functional tests (see #14958 from where this was extracted). Tree-SHA512: 7292cb6087f4c429973d991aa2b53ffa1327d5a213df7d6ba5fc69b01b2e1a411f6d1609fed9234896293317dab05f65064da48b8f2b4a998eba532591d31882
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Oct 31, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Nov 6, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Nov 14, 2021
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
getrpcinfocommand exposes details of the RPC interface. The details can be configuration properties or runtime values/stats.This can be particular useful to coordinate concurrent functional tests (see #14958 from where this was extracted).