qa: Remove race between connecting and shutdown on separate connections #14958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promag
force-pushed
the
2018-12-improve-shutdown-test
branch
from
410ce75 to
406204f
Compare
promag
force-pushed
the
2018-12-improve-shutdown-test
branch
from
406204f to
e2b0fec
Compare
laanwj
reviewed
Dec 14, 2018
promag
force-pushed
the
2018-12-improve-shutdown-test
branch
2 times, most recently
from
b3f27ea to
eeb8e04
Compare
promag
commented
Dec 14, 2018
This was referenced Dec 17, 2018
promag
force-pushed
the
2018-12-improve-shutdown-test
branch
from
eeb8e04 to
9be0dce
Compare
laanwj
added a commit
that referenced
this pull request
Jan 14, 2019
a0ac154 doc: Add getrpcinfo release notes (João Barbosa) 251a91c qa: Add tests for getrpcinfo (João Barbosa) d0730f5 rpc: Add getrpcinfo command (João Barbosa) 068a8fc rpc: Track active commands (João Barbosa) bf43832 rpc: Remove unused PreCommand signal (João Barbosa) Pull request description: The new `getrpcinfo` command exposes details of the RPC interface. The details can be configuration properties or runtime values/stats. This can be particular useful to coordinate concurrent functional tests (see #14958 from where this was extracted). Tree-SHA512: 7292cb6087f4c429973d991aa2b53ffa1327d5a213df7d6ba5fc69b01b2e1a411f6d1609fed9234896293317dab05f65064da48b8f2b4a998eba532591d31882
promag
force-pushed
the
2018-12-improve-shutdown-test
branch
from
9be0dce to
49a79d4
Compare
maflcko
reviewed
Jan 15, 2019
test/functional/feature_shutdown.py
Outdated
Member
There was a problem hiding this comment.
Is this required given that we wait anyway until node.waitfornewblock is called, which in turn should set up the connection?
Contributor
Author
There was a problem hiding this comment.
For the test to pass this is not required, but this is here to note that there's still a race after connection establishment. Let me know if it's not important.
Member
|
utACK 49a79d454284df7758f83ccd3121afb3e6799342 |
promag
changed the title
promag
force-pushed
the
2018-12-improve-shutdown-test
branch
from
49a79d4 to
4412a59
Compare
Member
|
utACK 4412a59 |
laanwj
added a commit
that referenced
this pull request
Jan 16, 2019
…rate connections 4412a59 qa: Remove race between connecting and shutdown on separate connections (João Barbosa) Pull request description: Fixes the error #14670 (comment) reported by @ken2812221. There is a race between RPC stop and another concurrent call in the test framework. The connection must be established and the command `waitfornewblock` running before calling `stop`. See also #14670 (comment). Tree-SHA512: 77feb8628d3b9c025ec0cf83565d4d6680cad4fb182fc93a65df8b573f3e799ba4c44e06d9001dd8a375ca0b1ee17f10e66c3902b6256d0ae2acbc64539185d7
scravy
added a commit
to dtr-org/unit-e
that referenced
this pull request
Feb 28, 2019
Ignore disconnects when stopping node - fixes #367 This is a port of bitcoin/bitcoin#14670 This problem is related to the "stop" RPC call. It turns out that sometimes the node stops before it sends the response. That causes the client to retry the call and lead to "ConnectionRefusedError". I found out that there is a fix in bitcoin repo (in master branch, actually), related to this bug. In the nutshell, this changes removes forced exit of libevent loop, which allows to process all the requests gracefully. Test feature_shutdown.py wasn't ported because it introduces a bug bitcoin/bitcoin#14670 (comment) The "improvement" bitcoin/bitcoin#14958 requires RPC method "getrpcinfo" which isn't ported from the bitcoin codebase yet. There are other floating tests with a similar error (ConnectionRefusedError): fixes #373 fixes #484 fixes #544 Signed-off-by: Dmitry Saveliev <[email protected]>
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
…on separate connections 4412a59 qa: Remove race between connecting and shutdown on separate connections (João Barbosa) Pull request description: Fixes the error bitcoin#14670 (comment) reported by @ken2812221. There is a race between RPC stop and another concurrent call in the test framework. The connection must be established and the command `waitfornewblock` running before calling `stop`. See also bitcoin#14670 (comment). Tree-SHA512: 77feb8628d3b9c025ec0cf83565d4d6680cad4fb182fc93a65df8b573f3e799ba4c44e06d9001dd8a375ca0b1ee17f10e66c3902b6256d0ae2acbc64539185d7
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this pull request
Sep 12, 2021
…on separate connections 4412a59 qa: Remove race between connecting and shutdown on separate connections (João Barbosa) Pull request description: Fixes the error bitcoin#14670 (comment) reported by @ken2812221. There is a race between RPC stop and another concurrent call in the test framework. The connection must be established and the command `waitfornewblock` running before calling `stop`. See also bitcoin#14670 (comment). Tree-SHA512: 77feb8628d3b9c025ec0cf83565d4d6680cad4fb182fc93a65df8b573f3e799ba4c44e06d9001dd8a375ca0b1ee17f10e66c3902b6256d0ae2acbc64539185d7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the error #14670 (comment) reported by @ken2812221.
There is a race between RPC stop and another concurrent call in the test framework. The connection must be established and the command
waitfornewblockrunning before callingstop.See also #14670 (comment).