travis: fix travis would always be green even if it fail #14937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Fine with me, but maybe it is not worth the code complexity in the travis yaml to support saving the cache in case of a test (or compile) failure? |
Member
I think that's a good point. Also I think not saving the cache in cache of failure makes sense, can you be certain what the state of things is when there's a failure? |
Contributor
Author
|
Ok. Let's revert #14231 |
This reverts commit d3ecc3d.
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Dec 13, 2018
… it fail fc91c1f Revert "travis: Save cache on build error" (Chun Kuan Lee) Pull request description: The current travis-ci job would fail only if the last command failed. It would be succeed if other commands than the last one fail. This PR execute the script in another shell instance, so we should export those variables and bash functions. It would return 1 if the script fail no matter if it's the last command. Sorry for ruin the travis ci system in bitcoin#14231 Test: https://travis-ci.org/ken2812221/bitcoin/jobs/467086010 Tree-SHA512: 4d9d144fe4c7038b4eff6bf8496e821af603d81677142c0884ed52aea6ce3a50150669be4fdad72a5d372456a33a2452d75ec35e8a7ec2bc4bdfbeaeb93e9acb
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 11, 2021
… it fail fc91c1f Revert "travis: Save cache on build error" (Chun Kuan Lee) Pull request description: The current travis-ci job would fail only if the last command failed. It would be succeed if other commands than the last one fail. This PR execute the script in another shell instance, so we should export those variables and bash functions. It would return 1 if the script fail no matter if it's the last command. Sorry for ruin the travis ci system in bitcoin#14231 Test: https://travis-ci.org/ken2812221/bitcoin/jobs/467086010 Tree-SHA512: 4d9d144fe4c7038b4eff6bf8496e821af603d81677142c0884ed52aea6ce3a50150669be4fdad72a5d372456a33a2452d75ec35e8a7ec2bc4bdfbeaeb93e9acb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current travis-ci job would fail only if the last command failed. It would be succeed if other commands than the last one fail.
This PR execute the script in another shell instance, so we should export those variables and bash functions. It would return 1 if the script fail no matter if it's the last command.
Sorry for ruin the travis ci system in #14231
Test: https://travis-ci.org/ken2812221/bitcoin/jobs/467086010