Descriptor expansion cache clarifications #14934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sjors
force-pushed
the
2018/12/rename_m_script_arg
branch
from
5925770 to
b2211c6
Compare
Member
|
Might as well fixup the other (trivial) nits. |
Sjors
force-pushed
the
2018/12/rename_m_script_arg
branch
from
b2211c6 to
acb6f9d
Compare
Member
Author
|
@fanquake done, I snuck those into the second commit. |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
flack
reviewed
Dec 12, 2018
Sjors
force-pushed
the
2018/12/rename_m_script_arg
branch
from
acb6f9d to
5cb58b8
Compare
Member
|
Ping @sipa, as this is your code it'd help if you give your opinion on this. |
Contributor
|
|
sipa
reviewed
Jan 27, 2019
-BEGIN VERIFY SCRIPT- sed -i -e 's/m_script_arg/m_subdescriptor_arg/g' src/script/descriptor.cpp -END VERIFY SCRIPT-
Member
Author
|
Rebased. @meshcollider I added a comment referencing By the way, I noticed that neither |
Sjors
force-pushed
the
2018/12/rename_m_script_arg
branch
from
5cb58b8 to
ee15d27
Compare
Plus a few typo fixes.
Sjors
force-pushed
the
2018/12/rename_m_script_arg
branch
from
ee15d27 to
2e68ffa
Compare
Member
Author
|
Miraculously this doesn't need another rebase... |
Contributor
|
FWIW: I've verified that a disassembly of the |
Member
|
ACK 2e68ffa |
laanwj
added a commit
that referenced
this pull request
Aug 14, 2019
2e68ffa [doc] descriptor: explain GetPubKey() usage with cached public key (Sjors Provoost) 2290269 scripted-diff: rename DescriptorImpl m_script_arg to m_subdescriptor_arg (Sjors Provoost) Pull request description: I found the name `m_script_arg` to be confusing while reviewing #14646 (comment). @sipa let me know if `m_subdescriptor_arg` is completely wrong. I also added an explanation of why we call `GetPubKey` when we don't ask it for a public key. ACKs for top commit: laanwj: ACK 2e68ffa Tree-SHA512: 06698e9a91cdda93c043a82732793f0ad3cd91daa2513565953e9fa048d5573322fb534e9d0ea9ab736e6366be5921e2b8699c4f4b3693edab48039aaae06f78
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Aug 14, 2019
maflcko
pushed a commit
that referenced
this pull request
Aug 14, 2019
3963856 descriptor: fix missed m_script_arg arg renaming in #14934 (fanquake) Pull request description: Fixes a missed renaming from #14934. ACKs for top commit: Sjors: ACK 3963856 Tree-SHA512: da2972301b2b83556f1f3f3b72758bb69570422cdd57c65aa7657b4e3dcc597dde03e7f1cf8988e8c3b6737737b4c0bee4aefb329376e24e7dedc2cab73fcf88
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 17, 2019
2e68ffa [doc] descriptor: explain GetPubKey() usage with cached public key (Sjors Provoost) 2290269 scripted-diff: rename DescriptorImpl m_script_arg to m_subdescriptor_arg (Sjors Provoost) Pull request description: I found the name `m_script_arg` to be confusing while reviewing bitcoin#14646 (comment). @sipa let me know if `m_subdescriptor_arg` is completely wrong. I also added an explanation of why we call `GetPubKey` when we don't ask it for a public key. ACKs for top commit: laanwj: ACK 2e68ffa Tree-SHA512: 06698e9a91cdda93c043a82732793f0ad3cd91daa2513565953e9fa048d5573322fb534e9d0ea9ab736e6366be5921e2b8699c4f4b3693edab48039aaae06f78
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 17, 2019
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 7, 2020
Summary: 2e68ffaf205866e4cea71f64e79bbfb89e17280a [doc] descriptor: explain GetPubKey() usage with cached public key (Sjors Provoost) 2290269759ad10cc2e35958c7b0a63f3a7608621 scripted-diff: rename DescriptorImpl m_script_arg to m_subdescriptor_arg (Sjors Provoost) Pull request description: I found the name `m_script_arg` to be confusing while reviewing bitcoin/bitcoin#14646 (comment). @sipa let me know if `m_subdescriptor_arg` is completely wrong. I also added an explanation of why we call `GetPubKey` when we don't ask it for a public key. ACKs for top commit: laanwj: ACK 2e68ffaf205866e4cea71f64e79bbfb89e17280a --- Backport of Core [[bitcoin/bitcoin#14934 | PR14934]] Test Plan: ninja all check check-functional Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7806
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Nov 30, 2021
2e68ffa [doc] descriptor: explain GetPubKey() usage with cached public key (Sjors Provoost) 2290269 scripted-diff: rename DescriptorImpl m_script_arg to m_subdescriptor_arg (Sjors Provoost) Pull request description: I found the name `m_script_arg` to be confusing while reviewing bitcoin#14646 (comment). @sipa let me know if `m_subdescriptor_arg` is completely wrong. I also added an explanation of why we call `GetPubKey` when we don't ask it for a public key. ACKs for top commit: laanwj: ACK 2e68ffa Tree-SHA512: 06698e9a91cdda93c043a82732793f0ad3cd91daa2513565953e9fa048d5573322fb534e9d0ea9ab736e6366be5921e2b8699c4f4b3693edab48039aaae06f78
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the name
m_script_argto be confusing while reviewing #14646 (comment). @sipa let me know ifm_subdescriptor_argis completely wrong.I also added an explanation of why we call
GetPubKeywhen we don't ask it for a public key.