refactor: Add and use HaveTxsDownloaded() where appropriate #14863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
force-pushed
the
Mf1812-docNchainTx
branch
2 times, most recently
from
fa92430 to
fac019a
Compare
promag
reviewed
Dec 3, 2018
Contributor
promag
left a comment
promag
left a comment
There was a problem hiding this comment.
Concept ACK
Could also update these?:
bitcoin/src/net_processing.cpp
Line 569 in c62b151
bitcoin/src/net_processing.cpp
Line 1127 in c62b151
bitcoin/src/rpc/blockchain.cpp
Line 1461 in c62b151
Contributor
|
Concept ACK
|
maflcko
force-pushed
the
Mf1812-docNchainTx
branch
2 times, most recently
from
fab51e1 to
fa55fa9
Compare
maflcko
force-pushed
the
Mf1812-docNchainTx
branch
from
fa55fa9 to
fa4fc88
Compare
Contributor
|
utACK fa4fc88. |
Contributor
|
utACK fa4fc88 |
Member
|
utACK fa4fc88 |
laanwj
added a commit
that referenced
this pull request
Dec 7, 2018
…iate fa4fc88 validation: Add and use HaveTxsDownloaded where appropriate (MarcoFalke) Pull request description: `nChainTx` is an implementation detail that shouldn't be exposed without a wrapper that comes with appropriate documentation. Tree-SHA512: 56ab7378c2ce97794498724c271f861de982de69099e90ec09632a26230ae6fded3c59668adb378bd64dcb8ef714769b970210977b88a53fc7550774ddba3d59
laanwj
added a commit
that referenced
this pull request
Oct 28, 2019
…yHeaderTip fa39809 Avoid unused call to GuessVerificationProgress in NotifyHeaderTip (MarcoFalke) Pull request description: `GuessVerificationProgress` for a header (not a block) is always 0 because the number of txs in the block can not be determined from the header alone. Anyway, this result was never used, so we can optimize this call by hardcoding 0. This is the next commit in a series of changes toward removing nChainTx (see #14863, #13875) ACKs for top commit: promag: Code review ACK fa39809, missed that. laanwj: ACK fa39809 Tree-SHA512: 11016f8dbb1af1cf75241948d1ad35eac0c79d1311cd0db8c6ec806df2a9e3dc5f998dbd66ccbad5d84564e6cec7fe21ce7a2a13c2b34c746e2d3b31aa1db53a
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Dec 6, 2019
Summary: `nChainTx` is an implementation detail that shouldn't be exposed without a wrapper that comes with appropriate documentation. Backport of Bitcoin Core PR14863 bitcoin/bitcoin#14863 Test Plan: ``` make check ``` Reviewers: Fabien, #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D4552
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Oct 2, 2020
Summary: `nChainTx` is an implementation detail that shouldn't be exposed without a wrapper that comes with appropriate documentation. Backport of Bitcoin Core PR14863 bitcoin/bitcoin#14863 Test Plan: ``` make check ``` Reviewers: Fabien, #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D4552
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Oct 5, 2020
Summary: `nChainTx` is an implementation detail that shouldn't be exposed without a wrapper that comes with appropriate documentation. Backport of Bitcoin Core PR14863 bitcoin/bitcoin#14863 Test Plan: ``` make check ``` Reviewers: Fabien, #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D4552
jonspock
pushed a commit
to devaultcrypto/devault
that referenced
this pull request
Oct 10, 2020
Summary: `nChainTx` is an implementation detail that shouldn't be exposed without a wrapper that comes with appropriate documentation. Backport of Bitcoin Core PR14863 bitcoin/bitcoin#14863 Test Plan: ``` make check ``` Reviewers: Fabien, #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D4552
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Aug 11, 2021
…appropriate fa4fc88 validation: Add and use HaveTxsDownloaded where appropriate (MarcoFalke) Pull request description: `nChainTx` is an implementation detail that shouldn't be exposed without a wrapper that comes with appropriate documentation. Tree-SHA512: 56ab7378c2ce97794498724c271f861de982de69099e90ec09632a26230ae6fded3c59668adb378bd64dcb8ef714769b970210977b88a53fc7550774ddba3d59
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Aug 15, 2021
…appropriate fa4fc88 validation: Add and use HaveTxsDownloaded where appropriate (MarcoFalke) Pull request description: `nChainTx` is an implementation detail that shouldn't be exposed without a wrapper that comes with appropriate documentation. Tree-SHA512: 56ab7378c2ce97794498724c271f861de982de69099e90ec09632a26230ae6fded3c59668adb378bd64dcb8ef714769b970210977b88a53fc7550774ddba3d59
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nChainTxis an implementation detail that shouldn't be exposed without a wrapper that comes with appropriate documentation.