tests: Modify rpc_bind to conform to #14532 behaviour. #14861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongcarl
changed the title
Member
|
Concept ACK |
- Even when rpcallowip is specified, only bind localhost - Explicitly bind in run_allowip_test
dongcarl
force-pushed
the
2018-12-fix-rpc-bind-tests
branch
from
eddd50d to
f3cf95f
Compare
dongcarl
changed the title
Contributor
Author
|
All tests should pass now. Ready for review. |
Member
|
tested ACK f3cf95f |
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Apr 29, 2020
… interfaces" Summary: We don't support binding to untrusted networks, so avoid a default where that is typical (luke-jr) 3615003952ffbc814bdb53d9d0e45790f152bd2f net: Always default rpcbind to localhost, never "all interfaces" d6a1287481428d982dc03be3a6d9aeef8398f468 CNetAddr: Add IsBindAny method to check for INADDR_ANY 27c44ef9c61f64d941ab82ec232a68141a2fde90 rpcbind: Warn about exposing RPC to untrusted networks f3cf95ffdfda935f28260eb34bf20c1449a200c5 tests: Modify rpc_bind to conform to #14532 behaviour. --- This is a backport of Core [[bitcoin/bitcoin#14532 | PR14532]] and Core [[bitcoin/bitcoin#14861 | PR14861]] Test Plan: ninja check ./test/functional/test_runner/rpc_bind Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5880
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jul 9, 2020
… behaviour. f3cf95f tests: Modify rpc_bind to conform to bitcoin#14532 behaviour. (Carl Dong) Pull request description: Fixes: bitcoin#14792 Tree-SHA512: 5ee63a06c92dae5406515e9e483188309b82e07b760f363d8c8ec46a42fe5f75f88724759b0ac8ef596ee28a135626e0582f575855c5dfec2fbfff2249a109f7
UdjinM6
added a commit
to dashpay/dash
that referenced
this pull request
Jul 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14792