-
Notifications
You must be signed in to change notification settings - Fork 38.7k
depends: latest RapidCheck #14853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
depends: latest RapidCheck #14853
Conversation
123e4d8 to
a989c40
Compare
a989c40 to
d4de513
Compare
|
Apologies for the |
|
Managed to get a backtrace in what should have been an equivalent environment. cc @Christewart |
d4de513 to
ac67582
Compare
|
Gitian builds for commit 7b13c64 (master):
Gitian builds for commit b7c9b7cb20b8c748e14e6c3f9b6d90ce4b05b857 (master and this pull):
|
| $(package)_file_name=$(package)-$($(package)_version).tar.gz | ||
| $(package)_sha256_hash=9640926223c00af45bce4c7df8b756b5458a89b2ba74cfe3e404467f13ce26df | ||
| $(package)_version=3eb9b4ff69f4ff2d9932e8f852c2b2a61d7c20d3 | ||
| $(package)_download_path=https://github.com/emil-e/rapidcheck/archive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we don't use the bitcoin core fork? https://github.com/bitcoin-core/rapidcheck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't actually made any changes yet, so I think sticking with upstream is best for now.
|
utACK ac67582 |
|
utack ac67582 |
ac67582 depends: latest rapidcheck, use INSTALL_ALL_EXTRAS (fanquake) Pull request description: This updates RapidCheck to the latest version available from https://github.com/emil-e/rapidcheck. RapidCheck now uses the new `RC_INSTALL_ALL_EXTRAS` option, to install the extra `boost_test` packages, which should unblock progress in #14430. ACKs for commit ac6758: MarcoFalke: utACK ac67582 Tree-SHA512: a4a4ef0ec09cf61cdc0de241703f5f8e98f6fa92f4024a0fbbf4d4ef91d9d3bc8d662c55d896aced8de68aa9429728b2bc5001c91c6f92d63d60c47f5adf41a0
Summary: ``` This updates RapidCheck to the latest version available from https://github.com/emil-e/rapidcheck. RapidCheck now uses the new RC_INSTALL_ALL_EXTRAS option, to install the extra boost_test packages, which should unblock progress in #14430. ``` Backport of core [[bitcoin/bitcoin#14853 | PR14853]]. Depends on D5323. Test Plan: Assuming you are running a 64-bit Linux machine: cd depends RAPIDCHECK=1 make build-linux64 Check the rapidcheck package is built. cd .. && mkdir buildLinux64 && cd buildLinux64 cmake -GNinja .. \ -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Linux64.cmake \ -DENABLE_PROPERTY_BASED_TESTS=ON Check the rapidcheck lib found is the one from the depends. ninja check Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D5324
Summary: ``` This updates RapidCheck to the latest version available from https://github.com/emil-e/rapidcheck. RapidCheck now uses the new RC_INSTALL_ALL_EXTRAS option, to install the extra boost_test packages, which should unblock progress in #14430. ``` Backport of core [[bitcoin/bitcoin#14853 | PR14853]]. Depends on D5323. Test Plan: Assuming you are running a 64-bit Linux machine: cd depends RAPIDCHECK=1 make build-linux64 Check the rapidcheck package is built. cd .. && mkdir buildLinux64 && cd buildLinux64 cmake -GNinja .. \ -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Linux64.cmake \ -DENABLE_PROPERTY_BASED_TESTS=ON Check the rapidcheck lib found is the one from the depends. ninja check Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D5324
This updates RapidCheck to the latest version available from https://github.com/emil-e/rapidcheck.
RapidCheck now uses the new
RC_INSTALL_ALL_EXTRASoption, to install the extraboost_testpackages, which should unblock progress in #14430.