[tests] Add wallet_balance.py #14845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
👍 |
Contributor
|
Concept ACK |
kallewoof
reviewed
Nov 30, 2018
Contributor
kallewoof
left a comment
kallewoof
left a comment
There was a problem hiding this comment.
utACK b31985d8c9a1cac749250a8f976fa6ccc2095b1e
A little confused by "getbalance with a minconf incorrectly excludes coins that have been spent more recently than the minconf blocks ago". Isn't it supposed to ignore balance for UTXOs whose confirmations < minconf?
Adds a test specifically to test the wallet's getbalance and getunconfirmedbalance RPCs.
jnewbery
force-pushed
the
balance_tests
branch
from
b31985d to
c1825b9
Compare
Contributor
Author
|
Thanks for the review @kallewoof and @practicalswift !
Yes, there's currently a bug when getbalance is called with minconf=0, that it checks for UTXO creation, but not UTXO spending. That's fixed in this commit: cfa948d, but there's more work to be done before that PR is ready for merge. |
Member
|
utACK c1825b9 (Also checked that the test passes on 0.17, which qualifies it for backport) |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Nov 30, 2018
c1825b9 [tests] Add wallet_balance.py (John Newbery) Pull request description: Adds a test specifically to test the wallet's getbalance and getunconfirmedbalance RPCs. `wallet_basic.py` is too large and should be broken down into more focused test cases. I wrote `wallet_balance.py` to test the changes in bitcoin#14602. Offering as a PR in case people think it's more generally useful. Tree-SHA512: 573ae8faf377df3d87d5112870b40690efb285fc5578fff8acc2ac1a0e4625ae65d3dfa8abbac577c87bec015038f425833783fa09f014f87906e8d098ed30d7
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Nov 30, 2018
Adds a test specifically to test the wallet's getbalance and getunconfirmedbalance RPCs. Github-Pull: bitcoin#14845 Rebased-From: c1825b9
Contributor
Author
|
Backported in #14852 |
dartdart26
added a commit
to projectpai/paicoin
that referenced
this pull request
Dec 28, 2018
Adds a test specifically to test the wallet's getbalance and getunconfirmedbalance RPCs. Changes were made to make it work with paicoin's implementation of getbalance.
dartdart26
added a commit
to projectpai/paicoin
that referenced
this pull request
Dec 28, 2018
Adds a test specifically to test the wallet's getbalance and getunconfirmedbalance RPCs. Changes were made to make it work with paicoin's implementation of getbalance.
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
May 4, 2020
Summary: Adds a test specifically to test the wallet's getbalance and getunconfirmedbalance RPCs. --- This is a backport of Core [[bitcoin/bitcoin#14845 | PR14845]] Test Plan: cmake .. -GNinja -DCMAKE_BUILD_TYPE=Debug ./test/functional/test_runner,py wallet_balance wallet_basic Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5950
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Aug 17, 2020
Summary: Adds a test specifically to test the wallet's getbalance and getunconfirmedbalance RPCs. --- This is a backport of Core [[bitcoin/bitcoin#14845 | PR14845]] Test Plan: cmake .. -GNinja -DCMAKE_BUILD_TYPE=Debug ./test/functional/test_runner,py wallet_balance wallet_basic Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5950
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test specifically to test the wallet's getbalance and
getunconfirmedbalance RPCs.
wallet_basic.pyis too large and should be broken down into more focused test cases.I wrote
wallet_balance.pyto test the changes in #14602. Offering as a PR in case people think it's more generally useful.