travis: Enable functional tests in the ThreadSanitizer (TSan) build job #14829

practicalswift · 2018-11-28T20:32:48Z

Enable functional tests in the ThreadSanitizer (TSan) build job.

This is a follow-up to @MarcoFalke's #14764 which added TSan but for unit tests only.

DrahtBot · 2018-11-28T23:21:38Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#14841 (consensus: Move CheckBlock() call to critical section by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

maflcko · 2018-11-29T20:19:52Z

.travis.yml

Why are they excluded?

feature_block.py and p2p_invalid_message.py fail for some unknown reason. Unfortunately the error log is not very informative so I haven't figured out why or what suppression (if any) would solve it.

They are timing out because the tsan slows down bitcoind so much. You'd probably have to up all the various timeouts (rpcwait and the timeout for polling loops)

At least that is what I assume based on my tsan runs a few days ago

@MarcoFalke Ah, I see. What do you think about doing that in a follow-up PR once this is merged? It would be nice to keep this initial PR minimal to get basic functional testing under Travis. Debugging Travis is quite time consuming so I'd rather split the task in two if possible.

maflcko · 2018-11-29T20:20:09Z

.travis.yml

Why is the wallet and DEBUG_LOCKORDER disabled?

For some strange reasons all functional wallets tests fail under Travis (wallet_basic, wallet_dump, etc.). The failure reason is not clear from the logging so I haven't been able to solve this yet.

I've now re-added CPPFLAGS=-DDEBUG_LOCKORDER since it doesn't seem to cause any problems.

Looks like they time out with

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

https://travis-ci.org/MarcoFalke/bitcoin/jobs/462970867

which shouldn't happen, since we should be printing dots all the time. Not sure what is going on :(

test/sanitizer_suppressions/tsan

practicalswift · 2018-12-03T13:41:49Z

@MarcoFalke Please review the latest version.

I've now re-introduced CPPFLAGS=-DDEBUG_LOCKORDER.

However, I've been unable to make the Travis build pass without FUNCTIONAL_TESTS_CONFIG="--exclude feature_block.py,p2p_invalid_messages.py" and --disable-wallet.

.travis/test_06_script.sh

practicalswift · 2018-12-15T15:25:48Z

@MarcoFalke @ken2812221 Updated. Please re-review :-)

maflcko · 2018-12-17T22:04:46Z

utACK 5e5138a

practicalswift · 2018-12-18T09:19:18Z

@MarcoFalke Added suppression (race:InterruptRPC, fix in #14993). Please re-review :-)

@MarcoFalke

…(TSan) build job eaf4070 Add suppression for InterruptRPC (fRPCRunning) data race (practicalswift) 5e5138a travis: Use trap and set -e errtrace (Chun Kuan Lee) 069752b build: Enable functional tests in the ThreadSanitizer (TSan) build job (practicalswift) Pull request description: Enable functional tests in the ThreadSanitizer (TSan) build job. This is a follow-up to @MarcoFalke's #14764 which added TSan but for unit tests only. Tree-SHA512: dcc24d311fa124772c3036b16c2bf94732ece36c3e22b4bb8fe941772e52157ab2b1a90b1880b81079c2eef2d344ca7e1da58324b75dbf82d16204d591ad49fb

…se of uninitialized memory 870f0cd build: Add MemorySanitizer (MSan) in Travis to detect use of uninitialized memory (practicalswift) Pull request description: Add MemorySanitizer (MSan) in Travis to detect use of uninitialized memory. First UBSan, then ASan followed by TSan... and now: yes, the wait is over -- **MSan is finally here!** :) Some historical context: * 2017: Continuous compilation with Clang Thread Safety analysis enabled (#10866, #10923) * 2018: Continuous testing with trapping on signed integer overflows (`-ftrapv`) (#12686) * 2018: Continuous testing of use of locale dependent functions (#13041) * 2018: Continuous testing of format strings (#13705) * 2018: Continuous compilation with MSVC `TreatWarningAsError` (#14151) * 2018: Continuous testing under UndefinedBehaviorSanitizer – UBSan (#14252, #14673, #17006) * 2018: Continuous testing under AddressSanitizer – ASan (#14794, #17205, #17674) * 2018: Continuous testing under ThreadSanitizer – TSan (#14829) * 2019: Continuous testing in an unsigned char environment (`-funsigned-char`) (#15134) * 2019: Continuous compile-time testing of assumptions we're making (#15391) * 2019: Continuous testing of fuzz test cases under Valgrind (#17633, #18159, #18166) * 2020: Finally... MemorySanitizer – MSAN! :) What is the next step? What tools should we add to CI to keep bugs from entering `master`? :) ACKs for top commit: MarcoFalke: ACK 870f0cd Tree-SHA512: 38327c8b75679d97d469fe42e704cacd1217447a5a603701dd8a58ee50b3be2c10248f8d68a479ed081c0c4b254589d3081c9183f991640b06ef689061f75578

@MarcoFalke

…itizer (TSan) build job eaf4070 Add suppression for InterruptRPC (fRPCRunning) data race (practicalswift) 5e5138a travis: Use trap and set -e errtrace (Chun Kuan Lee) 069752b build: Enable functional tests in the ThreadSanitizer (TSan) build job (practicalswift) Pull request description: Enable functional tests in the ThreadSanitizer (TSan) build job. This is a follow-up to @MarcoFalke's bitcoin#14764 which added TSan but for unit tests only. Tree-SHA512: dcc24d311fa124772c3036b16c2bf94732ece36c3e22b4bb8fe941772e52157ab2b1a90b1880b81079c2eef2d344ca7e1da58324b75dbf82d16204d591ad49fb

@MarcoFalke

…itizer (TSan) build job eaf4070 Add suppression for InterruptRPC (fRPCRunning) data race (practicalswift) 5e5138a travis: Use trap and set -e errtrace (Chun Kuan Lee) 069752b build: Enable functional tests in the ThreadSanitizer (TSan) build job (practicalswift) Pull request description: Enable functional tests in the ThreadSanitizer (TSan) build job. This is a follow-up to @MarcoFalke's bitcoin#14764 which added TSan but for unit tests only. Tree-SHA512: dcc24d311fa124772c3036b16c2bf94732ece36c3e22b4bb8fe941772e52157ab2b1a90b1880b81079c2eef2d344ca7e1da58324b75dbf82d16204d591ad49fb

fanquake added the Tests label Nov 29, 2018

fanquake requested a review from maflcko November 29, 2018 11:01

practicalswift mentioned this pull request Nov 29, 2018

consensus: Move CheckBlock() call to critical section #14841

Merged

maflcko reviewed Nov 29, 2018

View reviewed changes

test/sanitizer_suppressions/tsan Outdated Show resolved Hide resolved

DrahtBot added the Needs rebase label Dec 1, 2018

practicalswift force-pushed the tsan branch 5 times, most recently from 92a27e0 to f7a33ab Compare December 3, 2018 12:57

practicalswift force-pushed the tsan branch from f7a33ab to 167ad3c Compare December 3, 2018 13:47

ken2812221 reviewed Dec 3, 2018

View reviewed changes

.travis/test_06_script.sh Outdated Show resolved Hide resolved

DrahtBot removed the Needs rebase label Dec 3, 2018

practicalswift and others added 2 commits December 17, 2018 09:24

build: Enable functional tests in the ThreadSanitizer (TSan) build job

069752b

travis: Use trap and set -e errtrace

5e5138a

practicalswift force-pushed the tsan branch 2 times, most recently from 320d80d to 5e5138a Compare December 17, 2018 08:28

Add suppression for InterruptRPC (fRPCRunning) data race

eaf4070

practicalswift force-pushed the tsan branch from 9746c40 to eaf4070 Compare December 18, 2018 09:16

practicalswift mentioned this pull request Dec 18, 2018

rpc: Fix data race (UB) in InterruptRPC() #14993

Merged

maflcko merged commit eaf4070 into bitcoin:master Dec 18, 2018

Empact mentioned this pull request Mar 7, 2019

Enable -fsanitize flags in Travis #12691

Closed

practicalswift mentioned this pull request Mar 7, 2020

build: Add MemorySanitizer (MSan) in Travis to detect use of uninitialized memory #18288

Merged

practicalswift deleted the tsan branch April 10, 2021 19:37

bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022

travis: Enable functional tests in the ThreadSanitizer (TSan) build job #14829

travis: Enable functional tests in the ThreadSanitizer (TSan) build job #14829

Uh oh!

Conversation

practicalswift commented Nov 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Nov 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

maflcko Nov 29, 2018

Choose a reason for hiding this comment

Uh oh!

practicalswift Dec 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maflcko Dec 3, 2018

Choose a reason for hiding this comment

Uh oh!

maflcko Dec 3, 2018

Choose a reason for hiding this comment

Uh oh!

practicalswift Dec 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maflcko Nov 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

practicalswift Dec 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

practicalswift Dec 3, 2018

Choose a reason for hiding this comment

Uh oh!

maflcko Dec 3, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

practicalswift commented Dec 3, 2018

Uh oh!

Uh oh!

practicalswift commented Dec 15, 2018

Uh oh!

maflcko commented Dec 17, 2018

Uh oh!

practicalswift commented Dec 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

practicalswift commented Nov 28, 2018 •

edited

Loading

DrahtBot commented Nov 28, 2018 •

edited

Loading

practicalswift Dec 3, 2018 •

edited

Loading

practicalswift Dec 3, 2018 •

edited

Loading

maflcko Nov 29, 2018 •

edited

Loading

practicalswift Dec 3, 2018 •

edited

Loading

practicalswift commented Dec 18, 2018 •

edited

Loading